2024-09-09 09:13.53: New job: test ocaml-ppx/ppxlib https://github.com/ocaml-ppx/ppxlib.git#refs/pull/514/head (d22f931ee2a1e63f53b8191af493e4e7ff63c1c5) (linux-x86_64:debian-12-5.1_opam-2.2) Base: ocaml/opam:debian-12-ocaml-5.1@sha256:77150679cb3c9870c76e77cb76ec1ad0fc2e3e3cf93b98fb6255d07eb938ea0a Opam project build To reproduce locally: git clone --recursive "https://github.com/ocaml-ppx/ppxlib.git" && cd "ppxlib" && git fetch origin "refs/pull/514/head" && git reset --hard d22f931e cat > Dockerfile <<'END-OF-DOCKERFILE' FROM ocaml/opam:debian-12-ocaml-5.1@sha256:77150679cb3c9870c76e77cb76ec1ad0fc2e3e3cf93b98fb6255d07eb938ea0a # debian-12-5.1_opam-2.2 USER 1000:1000 ENV CLICOLOR_FORCE="1" ENV OPAMCOLOR="always" WORKDIR /src RUN sudo ln -f /usr/bin/opam-2.2 /usr/bin/opam RUN opam init --reinit -ni RUN uname -rs && opam exec -- ocaml -version && opam --version WORKDIR /src RUN sudo chown opam /src RUN cd ~/opam-repository && (git cat-file -e b92ae980c0437e8cdeac9f8f2c24a7800f1ed171 || git fetch origin master) && git reset -q --hard b92ae980c0437e8cdeac9f8f2c24a7800f1ed171 && git log --no-decorate -n1 --oneline && opam update -u RUN mkdir -p 'bench/vendored/ppx_sexp_conv.v0.15.1/' COPY --chown=1000:1000 ppxlib.opam ppxlib-bench.opam ./ COPY --chown=1000:1000 bench/vendored/ppx_sexp_conv.v0.15.1/ppx_sexp_conv.opam bench/vendored/ppx_sexp_conv.v0.15.1/ RUN opam pin add -yn ppxlib.dev './' && \ opam pin add -yn ppxlib-bench.dev './' && \ opam pin add -yn ppx_sexp_conv 'bench/vendored/ppx_sexp_conv.v0.15.1/' ENV DEPS="base.v0.17.1 base-bigarray.base base-domains.base base-nnp.base base-threads.base base-unix.base cinaps.v0.15.1 csexp.1.5.2 dune.3.16.0 dune-configurator.3.16.0 host-arch-x86_64.1 host-system-other.1 ocaml.5.1.1 ocaml-base-compiler.5.1.1 ocaml-compiler-libs.v0.12.4 ocaml-config.3 ocaml-options-vanilla.1 ocaml_intrinsics_kernel.v0.17.1 ocamlfind.1.9.6 ppx_derivers.1.2.1 re.1.12.0 seq.base sexplib0.v0.17.0 stdlib-shims.0.3.0 yojson.2.2.2" ENV CI="true" ENV OCAMLCI="true" RUN opam update --depexts && opam install --cli=2.2 --depext-only -y ppxlib.dev ppxlib-bench.dev $DEPS RUN opam install $DEPS COPY --chown=1000:1000 . /src RUN opam exec -- dune build @install @check @runtest && rm -rf _build END-OF-DOCKERFILE docker build . END-REPRO-BLOCK 2024-09-09 09:13.53: Using cache hint "ocaml-ppx/ppxlib-ocaml/opam:debian-12-ocaml-5.1@sha256:77150679cb3c9870c76e77cb76ec1ad0fc2e3e3cf93b98fb6255d07eb938ea0a-debian-12-5.1_opam-2.2-c4e5840013cc10939cdd043c4952636e" 2024-09-09 09:13.53: Using OBuilder spec: ((from ocaml/opam:debian-12-ocaml-5.1@sha256:77150679cb3c9870c76e77cb76ec1ad0fc2e3e3cf93b98fb6255d07eb938ea0a) (comment debian-12-5.1_opam-2.2) (user (uid 1000) (gid 1000)) (env CLICOLOR_FORCE 1) (env OPAMCOLOR always) (workdir /src) (run (shell "sudo ln -f /usr/bin/opam-2.2 /usr/bin/opam")) (run (shell "opam init --reinit -ni")) (run (shell "uname -rs && opam exec -- ocaml -version && opam --version")) (workdir /src) (run (shell "sudo chown opam /src")) (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "cd ~/opam-repository && (git cat-file -e b92ae980c0437e8cdeac9f8f2c24a7800f1ed171 || git fetch origin master) && git reset -q --hard b92ae980c0437e8cdeac9f8f2c24a7800f1ed171 && git log --no-decorate -n1 --oneline && opam update -u")) (run (shell "mkdir -p 'bench/vendored/ppx_sexp_conv.v0.15.1/'")) (copy (src ppxlib.opam ppxlib-bench.opam) (dst ./)) (copy (src bench/vendored/ppx_sexp_conv.v0.15.1/ppx_sexp_conv.opam) (dst bench/vendored/ppx_sexp_conv.v0.15.1/)) (run (network host) (shell "opam pin add -yn ppxlib.dev './' && \ \nopam pin add -yn ppxlib-bench.dev './' && \ \nopam pin add -yn ppx_sexp_conv 'bench/vendored/ppx_sexp_conv.v0.15.1/'")) (env DEPS "base.v0.17.1 base-bigarray.base base-domains.base base-nnp.base base-threads.base base-unix.base cinaps.v0.15.1 csexp.1.5.2 dune.3.16.0 dune-configurator.3.16.0 host-arch-x86_64.1 host-system-other.1 ocaml.5.1.1 ocaml-base-compiler.5.1.1 ocaml-compiler-libs.v0.12.4 ocaml-config.3 ocaml-options-vanilla.1 ocaml_intrinsics_kernel.v0.17.1 ocamlfind.1.9.6 ppx_derivers.1.2.1 re.1.12.0 seq.base sexplib0.v0.17.0 stdlib-shims.0.3.0 yojson.2.2.2") (env CI true) (env OCAMLCI true) (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam update --depexts && opam install --cli=2.2 --depext-only -y ppxlib.dev ppxlib-bench.dev $DEPS")) (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam install $DEPS")) (copy (src .) (dst /src)) (run (shell "opam exec -- dune build @install @check @runtest && rm -rf _build")) ) 2024-09-09 09:13.53: Waiting for resource in pool OCluster 2024-09-09 09:13.53: Waiting for worker… 2024-09-09 09:13.53: Got resource from pool OCluster Building on x86-bm-c14.sw.ocaml.org All commits already cached HEAD is now at d22f931e Add coalesce_arity to Ast_builder and use it in metaquot (from ocaml/opam:debian-12-ocaml-5.1@sha256:77150679cb3c9870c76e77cb76ec1ad0fc2e3e3cf93b98fb6255d07eb938ea0a) 2024-09-09 09:14.47 ---> saved as "7f1fc91569c4944f2a42384167d6a5257d51f4f823a2dc27fc5cd059b17040d7" /: (comment debian-12-5.1_opam-2.2) /: (user (uid 1000) (gid 1000)) /: (env CLICOLOR_FORCE 1) /: (env OPAMCOLOR always) /: (workdir /src) /src: (run (shell "sudo ln -f /usr/bin/opam-2.2 /usr/bin/opam")) 2024-09-09 09:14.47 ---> saved as "036a7bb6e1bdba099190225dec00d9d6e0e4cb4ae29b7c9d714670d242f0d49a" /src: (run (shell "opam init --reinit -ni")) Configuring from /home/opam/.opamrc and then from built-in defaults. Checking for available remotes: rsync and local, git. - you won't be able to use mercurial repositories unless you install the hg command on your system. - you won't be able to use darcs repositories unless you install the darcs command on your system. This development version of opam requires an update to the layout of /home/opam/.opam from version 2.0 to version 2.2, which can't be reverted. You may want to back it up before going further. Continue? [y/n] y Format upgrade done. <><> Updating repositories ><><><><><><><><><><><><><><><><><><><><><><><><><><> [default] synchronised from file:///home/opam/opam-repository 2024-09-09 09:16.27 ---> saved as "778c9e3b9a4e18ca808b58448759b9e77092fb5019d8a0dc36f0bc0ecfb6ca11" /src: (run (shell "uname -rs && opam exec -- ocaml -version && opam --version")) Linux 5.15.0-119-generic The OCaml toplevel, version 5.1.1 2.2.1 2024-09-09 09:16.28 ---> saved as "fa02a047810f43cee0eedbfe62a881da47abd3ef4815b88010538deb5fb318d9" /src: (workdir /src) /src: (run (shell "sudo chown opam /src")) 2024-09-09 09:16.28 ---> saved as "3b690807b5ffa23f2ec9ecbff11fc38b891c4cee739a729de0ee72fa62e54484" /src: (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "cd ~/opam-repository && (git cat-file -e b92ae980c0437e8cdeac9f8f2c24a7800f1ed171 || git fetch origin master) && git reset -q --hard b92ae980c0437e8cdeac9f8f2c24a7800f1ed171 && git log --no-decorate -n1 --oneline && opam update -u")) From https://github.com/ocaml/opam-repository * branch master -> FETCH_HEAD e89899ac28..16e8d80cc5 master -> origin/master b92ae980c0 Merge pull request #26439 from rgrinberg/release-re-1.12.0 <><> Updating package repositories ><><><><><><><><><><><><><><><><><><><><><><> [default] synchronised from file:///home/opam/opam-repository Everything as up-to-date as possible (run with --verbose to show unavailable upgrades). However, you may "opam upgrade" these packages explicitly, which will ask permission to downgrade or uninstall the conflicting packages. Nothing to do. # Run eval $(opam env) to update the current shell environment 2024-09-09 09:17.46 ---> saved as "e2d94173a926c050eb82516a60ac8a712b37f89feb5e03d37ad5267af64b9fa2" /src: (run (shell "mkdir -p 'bench/vendored/ppx_sexp_conv.v0.15.1/'")) 2024-09-09 09:17.46 ---> saved as "16f66c539bc92c70b0e523a20189c8c12e3c90e83ee3ae7db64e962bed567803" /src: (copy (src ppxlib.opam ppxlib-bench.opam) (dst ./)) 2024-09-09 09:17.46 ---> saved as "670f7f616e920167761ad81d3b5faa80c2be9b5e6c059a6cd15000a82b5452d6" /src: (copy (src bench/vendored/ppx_sexp_conv.v0.15.1/ppx_sexp_conv.opam) (dst bench/vendored/ppx_sexp_conv.v0.15.1/)) 2024-09-09 09:17.46 ---> saved as "1fe8fc5c9c7897b079997ab2b4faf4666aec0e099294c7a072a31cb96a17d424" /src: (run (network host) (shell "opam pin add -yn ppxlib.dev './' && \ \nopam pin add -yn ppxlib-bench.dev './' && \ \nopam pin add -yn ppx_sexp_conv 'bench/vendored/ppx_sexp_conv.v0.15.1/'")) [ppxlib.dev] synchronised (file:///src) ppxlib is now pinned to file:///src (version dev) Package ppxlib-bench does not exist, create as a NEW package? [y/n] y [ppxlib-bench.dev] synchronised (file:///src) ppxlib-bench is now pinned to file:///src (version dev) [ppx_sexp_conv.v0.17.0] synchronised (file:///src/bench/vendored/ppx_sexp_conv.v0.15.1) ppx_sexp_conv is now pinned to file:///src/bench/vendored/ppx_sexp_conv.v0.15.1 (version v0.15.0) 2024-09-09 09:17.51 ---> saved as "61ee6544e925cd88211d488f093e8d7c3a95a7d72ba67d9fac4df9db5f428d1d" /src: (env DEPS "base.v0.17.1 base-bigarray.base base-domains.base base-nnp.base base-threads.base base-unix.base cinaps.v0.15.1 csexp.1.5.2 dune.3.16.0 dune-configurator.3.16.0 host-arch-x86_64.1 host-system-other.1 ocaml.5.1.1 ocaml-base-compiler.5.1.1 ocaml-compiler-libs.v0.12.4 ocaml-config.3 ocaml-options-vanilla.1 ocaml_intrinsics_kernel.v0.17.1 ocamlfind.1.9.6 ppx_derivers.1.2.1 re.1.12.0 seq.base sexplib0.v0.17.0 stdlib-shims.0.3.0 yojson.2.2.2") /src: (env CI true) /src: (env OCAMLCI true) /src: (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam update --depexts && opam install --cli=2.2 --depext-only -y ppxlib.dev ppxlib-bench.dev $DEPS")) + /usr/bin/sudo "apt-get" "update" - Get:1 http://deb.debian.org/debian bookworm InRelease [151 kB] - Get:2 http://deb.debian.org/debian bookworm-updates InRelease [55.4 kB] - Get:3 http://deb.debian.org/debian-security bookworm-security InRelease [47.9 kB] - Get:4 http://deb.debian.org/debian bookworm/main amd64 Packages [8787 kB] - Get:5 http://deb.debian.org/debian-security bookworm-security/main amd64 Packages [179 kB] - Fetched 9221 kB in 1s (7572 kB/s) - Reading package lists... <><> Synchronising pinned packages ><><><><><><><><><><><><><><><><><><><><><><> [ppxlib.dev] synchronised (no changes) [ppxlib-bench.dev] synchronised (no changes) [NOTE] Package ocaml-options-vanilla is already installed (current version is 1). [NOTE] Package ocaml-config is already installed (current version is 3). [NOTE] Package ocaml-base-compiler is already installed (current version is 5.1.1). [NOTE] Package ocaml is already installed (current version is 5.1.1). [NOTE] Package host-system-other is already installed (current version is 1). [NOTE] Package host-arch-x86_64 is already installed (current version is 1). [NOTE] Package base-unix is already installed (current version is base). [NOTE] Package base-threads is already installed (current version is base). [NOTE] Package base-nnp is already installed (current version is base). [NOTE] Package base-domains is already installed (current version is base). [NOTE] Package base-bigarray is already installed (current version is base). 2024-09-09 09:18.12 ---> saved as "06614d437986c991cd86035601176f6347e094da615e09139e186ce908266a28" /src: (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam install $DEPS")) [NOTE] Package ocaml-options-vanilla is already installed (current version is 1). [NOTE] Package ocaml-config is already installed (current version is 3). [NOTE] Package ocaml-base-compiler is already installed (current version is 5.1.1). [NOTE] Package ocaml is already installed (current version is 5.1.1). [NOTE] Package host-system-other is already installed (current version is 1). [NOTE] Package host-arch-x86_64 is already installed (current version is 1). [NOTE] Package base-unix is already installed (current version is base). [NOTE] Package base-threads is already installed (current version is base). [NOTE] Package base-nnp is already installed (current version is base). [NOTE] Package base-domains is already installed (current version is base). [NOTE] Package base-bigarray is already installed (current version is base). The following actions will be performed: === install 14 packages - install base v0.17.1 - install cinaps v0.15.1 - install csexp 1.5.2 - install dune 3.16.0 - install dune-configurator 3.16.0 - install ocaml-compiler-libs v0.12.4 - install ocaml_intrinsics_kernel v0.17.1 - install ocamlfind 1.9.6 - install ppx_derivers 1.2.1 - install re 1.12.0 - install seq base - install sexplib0 v0.17.0 - install stdlib-shims 0.3.0 - install yojson 2.2.2 <><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><> -> retrieved cinaps.v0.15.1 (cached) -> retrieved base.v0.17.1 (cached) -> retrieved csexp.1.5.2 (cached) -> retrieved ocaml-compiler-libs.v0.12.4 (cached) -> retrieved ocaml_intrinsics_kernel.v0.17.1 (cached) -> retrieved ppx_derivers.1.2.1 (cached) -> retrieved ocamlfind.1.9.6 (cached) -> retrieved seq.base (cached) -> installed seq.base -> retrieved dune.3.16.0, dune-configurator.3.16.0 (cached) -> retrieved re.1.12.0 (cached) -> retrieved sexplib0.v0.17.0 (cached) -> retrieved stdlib-shims.0.3.0 (cached) -> retrieved yojson.2.2.2 (cached) -> installed ocamlfind.1.9.6 -> installed dune.3.16.0 -> installed ppx_derivers.1.2.1 -> installed csexp.1.5.2 -> installed ocaml-compiler-libs.v0.12.4 -> installed ocaml_intrinsics_kernel.v0.17.1 -> installed re.1.12.0 -> installed sexplib0.v0.17.0 -> installed stdlib-shims.0.3.0 -> installed yojson.2.2.2 -> installed cinaps.v0.15.1 -> installed dune-configurator.3.16.0 -> installed base.v0.17.1 Done. # Run eval $(opam env) to update the current shell environment 2024-09-09 09:19.10 ---> saved as "87c13080f965937503d0eb454d75622ce4ea7cbf5666ca11aad9a0f98a45085f" /src: (copy (src .) (dst /src)) 2024-09-09 09:19.10 ---> saved as "0b5a8ddda2b6f3d47140ce8fbbb312993a657714d0d102263b3192dd9854b52e" /src: (run (shell "opam exec -- dune build @install @check @runtest && rm -rf _build")) File "test/501_migrations/one_migration.t", line 1, characters 0-0: /usr/bin/git --no-pager diff --no-index --color=always -u _build/.sandbox/2b9f794e318ab8baffa9e381288d1b03/default/test/501_migrations/one_migration.t _build/.sandbox/2b9f794e318ab8baffa9e381288d1b03/default/test/501_migrations/one_migration.t.corrected diff --git a/_build/.sandbox/2b9f794e318ab8baffa9e381288d1b03/default/test/501_migrations/one_migration.t b/_build/.sandbox/2b9f794e318ab8baffa9e381288d1b03/default/test/501_migrations/one_migration.t.corrected index 48e8444..fdd0793 100644 --- a/_build/.sandbox/2b9f794e318ab8baffa9e381288d1b03/default/test/501_migrations/one_migration.t +++ b/_build/.sandbox/2b9f794e318ab8baffa9e381288d1b03/default/test/501_migrations/one_migration.t.corrected @@ -94,17 +94,49 @@ So let's only keep one example. (pos_cnum -1))) (loc_ghost true)))) ((pexp_desc - (Pexp_construct - ((txt (Lident [])) - (loc - ((loc_start - ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) - (pos_cnum -1))) - (loc_end - ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) - (pos_cnum -1))) - (loc_ghost true)))) - ())) + (Pexp_tuple + (((pexp_desc + (Pexp_construct + ((txt (Lident [])) + (loc + ((loc_start + ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) + (pos_cnum -1))) + (loc_end + ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) + (pos_cnum -1))) + (loc_ghost true)))) + ())) + (pexp_loc + ((loc_start + ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) + (pos_cnum -1))) + (loc_end + ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) + (pos_cnum -1))) + (loc_ghost true))) + (pexp_loc_stack ()) (pexp_attributes ())) + ((pexp_desc + (Pexp_construct + ((txt (Lident [])) + (loc + ((loc_start + ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) + (pos_cnum -1))) + (loc_end + ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) + (pos_cnum -1))) + (loc_ghost true)))) + ())) + (pexp_loc + ((loc_start + ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) + (pos_cnum -1))) + (loc_end + ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) + (pos_cnum -1))) + (loc_ghost true))) + (pexp_loc_stack ()) (pexp_attributes ()))))) (pexp_loc ((loc_start ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) @@ -472,93 +504,52 @@ So let's only keep one example. (Pstr_value Nonrecursive (((pvb_pat ((ppat_desc - (Ppat_constraint - ((ppat_desc - (Ppat_var - ((txt x) - (loc - ((loc_start - ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 4))) - (loc_end - ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 5))) - (loc_ghost false)))))) - (ppat_loc + (Ppat_var + ((txt x) + (loc ((loc_start ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 4))) (loc_end ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 5))) - (loc_ghost false))) - (ppat_loc_stack ()) (ppat_attributes ())) - ((ptyp_desc - (Ptyp_poly () - ((ptyp_desc - (Ptyp_constr - ((txt (Lident int)) - (loc - ((loc_start - ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) - (pos_cnum 8))) - (loc_end - ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) - (pos_cnum 11))) - (loc_ghost false)))) - ())) - (ptyp_loc - ((loc_start - ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 8))) - (loc_end - ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 11))) - (loc_ghost false))) - (ptyp_loc_stack ()) (ptyp_attributes ())))) - (ptyp_loc - ((loc_start - ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 8))) - (loc_end - ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 11))) - (loc_ghost true))) - (ptyp_loc_stack ()) (ptyp_attributes ())))) + (loc_ghost false)))))) (ppat_loc ((loc_start ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 4))) (loc_end - ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 11))) - (loc_ghost true))) + ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 5))) + (loc_ghost false))) (ppat_loc_stack ()) (ppat_attributes ()))) (pvb_expr - ((pexp_desc - (Pexp_constraint - ((pexp_desc (Pexp_constant (Pconst_integer 5 ()))) - (pexp_loc - ((loc_start - ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 14))) - (loc_end - ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 15))) - (loc_ghost false))) - (pexp_loc_stack ()) (pexp_attributes ())) - ((ptyp_desc - (Ptyp_constr - ((txt (Lident int)) - (loc - ((loc_start - ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 8))) - (loc_end - ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 11))) - (loc_ghost false)))) - ())) - (ptyp_loc - ((loc_start - ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 8))) - (loc_end - ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 11))) - (loc_ghost false))) - (ptyp_loc_stack ()) (ptyp_attributes ())))) + ((pexp_desc (Pexp_constant (Pconst_integer 5 ()))) (pexp_loc ((loc_start - ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 4))) + ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 14))) (loc_end ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 15))) (loc_ghost false))) (pexp_loc_stack ()) (pexp_attributes ()))) + (pvb_constraint + ((Pvc_constraint + ((locally_abstract_univars ()) + (typ + ((ptyp_desc + (Ptyp_constr + ((txt (Lident int)) + (loc + ((loc_start + ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 8))) + (loc_end + ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) + (pos_cnum 11))) + (loc_ghost false)))) + ())) + (ptyp_loc + ((loc_start + ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 8))) + (loc_end + ((pos_fname file.ml) (pos_lnum 1) (pos_bol 0) (pos_cnum 11))) + (loc_ghost false))) + (ptyp_loc_stack ()) (ptyp_attributes ()))))))) (pvb_attributes ()) (pvb_loc ((loc_start @@ -661,17 +652,49 @@ So let's only keep one example. (pos_cnum -1))) (loc_ghost true)))) ((pexp_desc - (Pexp_construct - ((txt (Lident [])) - (loc - ((loc_start - ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) - (pos_cnum -1))) - (loc_end - ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) - (pos_cnum -1))) - (loc_ghost true)))) - ())) + (Pexp_tuple + (((pexp_desc + (Pexp_construct + ((txt (Lident [])) + (loc + ((loc_start + ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) + (pos_cnum -1))) + (loc_end + ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) + (pos_cnum -1))) + (loc_ghost true)))) + ())) + (pexp_loc + ((loc_start + ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) + (pos_cnum -1))) + (loc_end + ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) + (pos_cnum -1))) + (loc_ghost true))) + (pexp_loc_stack ()) (pexp_attributes ())) + ((pexp_desc + (Pexp_construct + ((txt (Lident [])) + (loc + ((loc_start + ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) + (pos_cnum -1))) + (loc_end + ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) + (pos_cnum -1))) + (loc_ghost true)))) + ())) + (pexp_loc + ((loc_start + ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) + (pos_cnum -1))) + (loc_end + ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) + (pos_cnum -1))) + (loc_ghost true))) + (pexp_loc_stack ()) (pexp_attributes ()))))) (pexp_loc ((loc_start ((pos_fname _none_) (pos_lnum 0) (pos_bol 0) @@ -1085,7 +1108,7 @@ So let's only keep one example. (loc_ghost false))))) (pmb_expr ((pmod_desc - (Pmod_apply + (Pmod_apply_unit ((pmod_desc (Pmod_ident ((txt (Lident F)) @@ -1101,14 +1124,6 @@ So let's only keep one example. (loc_end ((pos_fname file.ml) (pos_lnum 2) (pos_bol 25) (pos_cnum 37))) (loc_ghost false))) - (pmod_attributes ())) - ((pmod_desc (Pmod_structure ())) - (pmod_loc - ((loc_start - ((pos_fname file.ml) (pos_lnum 2) (pos_bol 25) (pos_cnum 36))) - (loc_end - ((pos_fname file.ml) (pos_lnum 2) (pos_bol 25) (pos_cnum 40))) - (loc_ghost false))) (pmod_attributes ())))) (pmod_loc ((loc_start File "test/501_migrations/normal_migrations.t", line 1, characters 0-0: /usr/bin/git --no-pager diff --no-index --color=always -u _build/.sandbox/14c30f1881e1445ecab2485d0a18887d/default/test/501_migrations/normal_migrations.t _build/.sandbox/14c30f1881e1445ecab2485d0a18887d/default/test/501_migrations/normal_migrations.t.corrected diff --git a/_build/.sandbox/14c30f1881e1445ecab2485d0a18887d/default/test/501_migrations/normal_migrations.t b/_build/.sandbox/14c30f1881e1445ecab2485d0a18887d/default/test/501_migrations/normal_migrations.t.corrected index 8e0de5f..4af5a9d 100644 --- a/_build/.sandbox/14c30f1881e1445ecab2485d0a18887d/default/test/501_migrations/normal_migrations.t +++ b/_build/.sandbox/14c30f1881e1445ecab2485d0a18887d/default/test/501_migrations/normal_migrations.t.corrected @@ -65,45 +65,7 @@ Here might be a problem in the upward migration: the 5.1.0 parser parses the con However, the upward migration makes a value binding constraint out of it. $ echo "let ((x,y) : (int*int)) = (assert false: int * int)" > file.ml $ ./compare_on.exe file.ml ./identity_driver.exe | grep -v "without_migrations" | grep -v "with_migrations" - @@ -6,20 +6,18 @@ - - pattern (file.ml[1,0+4]..[1,0+23]) - - Ppat_constraint - - pattern (file.ml[1,0+5]..[1,0+10]) - - Ppat_tuple - - [ - - pattern (file.ml[1,0+6]..[1,0+7]) - - Ppat_var "x" (file.ml[1,0+6]..[1,0+7]) - - pattern (file.ml[1,0+8]..[1,0+9]) - - Ppat_var "y" (file.ml[1,0+8]..[1,0+9]) - - ] - - core_type (file.ml[1,0+14]..[1,0+21]) - - Ptyp_tuple - - [ - - core_type (file.ml[1,0+14]..[1,0+17]) - - Ptyp_constr "int" (file.ml[1,0+14]..[1,0+17]) - - [] - - core_type (file.ml[1,0+18]..[1,0+21]) - - Ptyp_constr "int" (file.ml[1,0+18]..[1,0+21]) - - [] - - ] - + pattern (file.ml[1,0+5]..[1,0+10]) - + Ppat_tuple - + [ - + pattern (file.ml[1,0+6]..[1,0+7]) - + Ppat_var "x" (file.ml[1,0+6]..[1,0+7]) - + pattern (file.ml[1,0+8]..[1,0+9]) - + Ppat_var "y" (file.ml[1,0+8]..[1,0+9]) - + ] - + core_type (file.ml[1,0+14]..[1,0+21]) - + Ptyp_tuple - + [ - + core_type (file.ml[1,0+14]..[1,0+17]) - + Ptyp_constr "int" (file.ml[1,0+14]..[1,0+17]) - + [] - + core_type (file.ml[1,0+18]..[1,0+21]) - + Ptyp_constr "int" (file.ml[1,0+18]..[1,0+21]) - + [] - + ] + [1] $ echo "let f: type a. a option -> _ = assert false" > file.ml $ ./compare_on.exe file.ml ./identity_driver.exe | grep -v "without_migrations" | grep -v "with_migrations" File "ast/dune", line 19, characters 2-47: 19 | (pps ppxlib_traverse -deriving-keep-w32=impl))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ (cd _build/default && .ppx/3134a5298fb2c80808cc94dd434856cb/ppx.exe -deriving-keep-w32=impl --cookie 'library-name="ppxlib_ast"' --impl ast/ast.ml -corrected-suffix .lint-corrected -diff-cmd - -null) sh: 1: patdiff: not found diff: /tmp/build_6dd632_dune/ppxlib229a64: No such file or directory diff: /tmp/build_6dd632_dune/ppxlib354b34: No such file or directory File "ast/ast.ml", lines 1086-2416, characters 0-5: 1086 | class virtual map = 1087 | object (self) 1088 | method virtual bool : bool -> bool 1089 | method virtual char : char -> char 1090 | method virtual int : int -> int ... 2413 | Pdir_bool a 2414 | 2415 | method cases : cases -> cases = self#list self#case 2416 | end Error: ppxlib: the corrected code doesn't round-trip. This is probably a bug in the OCaml printer: <no differences produced by diff> File "test/metaquot/test.ml", line 1, characters 0-0: /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/test/metaquot/test.ml _build/default/test/metaquot/test.ml.corrected diff --git a/_build/default/test/metaquot/test.ml b/_build/default/test/metaquot/test.ml.corrected index b33049e..2ec72ba 100644 --- a/_build/default/test/metaquot/test.ml +++ b/_build/default/test/metaquot/test.ml.corrected @@ -613,5 +613,7 @@ let _ = [%%expect{| -- : string = "fun x y z -> (x + y) + z" +Line _, characters 44-48: +Error: This expression has type Ppxlib.expression + but an expression was expected of type Parsetree.expression |}] "/usr/bin/env" "bash" "-c" "opam exec -- dune build @install @check @runtest && rm -rf _build" failed with exit status 1 2024-09-09 09:19.39: Job failed: Failed: Build failed