Getting StartedDocumentation
Organisationsocaml-multicoremulticore-bench298c5d ()debian-12-5.2_s390x_opam-2.2

debian-12-5.2_s390x_opam-2.2

Link Copied
Code Copied

Logs

Show raw logs
2024-09-11 13:30.32: New job: test ocaml-multicore/multicore-bench https://github.com/ocaml-multicore/multicore-bench.git#refs/heads/main (298c5d1e24da82a9640825ef4a68b9aef88daaca) (linux-s390x:debian-12-5.2_s390x_opam-2.2)
Base: ocaml/opam:debian-12-ocaml-5.2@sha256:f1214d035f156f0c179bea17b48ffe43588d665368b61b14875e02564f92acec
Opam project build


To reproduce locally:


git clone --recursive "https://github.com/ocaml-multicore/multicore-bench.git" -b "main" && cd "multicore-bench" && git reset --hard 298c5d1e
cat > Dockerfile <<'END-OF-DOCKERFILE'
FROM ocaml/opam:debian-12-ocaml-5.2@sha256:f1214d035f156f0c179bea17b48ffe43588d665368b61b14875e02564f92acec
# debian-12-5.2_s390x_opam-2.2
USER 1000:1000
ENV CLICOLOR_FORCE="1"
ENV OPAMCOLOR="always"
WORKDIR /src
RUN sudo ln -f /usr/bin/opam-2.2 /usr/bin/opam
RUN opam init --reinit -ni
RUN uname -rs && opam exec -- ocaml -version && opam --version
WORKDIR /src
RUN sudo chown opam /src
RUN cd ~/opam-repository && (git cat-file -e 0329818dcfd3de1a722ea09eeeed94cd24caa375 || git fetch origin master) && git reset -q --hard 0329818dcfd3de1a722ea09eeeed94cd24caa375 && git log --no-decorate -n1 --oneline && opam update -u
COPY --chown=1000:1000 multicore-bench.opam ./
RUN opam pin add -yn multicore-bench.dev './'
ENV DEPS="astring.0.8.5 backoff.0.1.0 base-bigarray.base base-domains.base base-nnp.base base-threads.base base-unix.base camlp-streams.5.0.1 cmdliner.1.3.0 cppo.1.7.0 csexp.1.5.2 domain-local-await.1.0.1 domain_shims.0.1.0 dune.3.16.0 fmt.0.9.0 host-arch-s390x.1 host-system-other.1 logs.0.7.0 mdx.2.4.1 mtime.2.1.0 multicore-magic.2.3.0 ocaml.5.2.0 ocaml-base-compiler.5.2.0 ocaml-config.3 ocaml-options-vanilla.1 ocaml-version.3.6.8 ocamlbuild.0.15.0 ocamlfind.1.9.6 re.1.12.0 result.1.5 seq.base thread-table.1.0.0 topkg.1.0.7 yojson.2.2.2"
ENV CI="true"
ENV OCAMLCI="true"
RUN opam update --depexts && opam install --cli=2.2 --depext-only -y multicore-bench.dev $DEPS
RUN opam install $DEPS
COPY --chown=1000:1000 . /src
RUN opam exec -- dune build @install @check @runtest && rm -rf _build


END-OF-DOCKERFILE
docker build .
END-REPRO-BLOCK


2024-09-11 13:30.32: Using cache hint "ocaml-multicore/multicore-bench-ocaml/opam:debian-12-ocaml-5.2@sha256:f1214d035f156f0c179bea17b48ffe43588d665368b61b14875e02564f92acec-debian-12-5.2_s390x_opam-2.2-e74cb543392168d16ccfe7c261aa8991"
2024-09-11 13:30.32: Using OBuilder spec:
((from ocaml/opam:debian-12-ocaml-5.2@sha256:f1214d035f156f0c179bea17b48ffe43588d665368b61b14875e02564f92acec)
 (comment debian-12-5.2_s390x_opam-2.2)
 (user (uid 1000) (gid 1000))
 (env CLICOLOR_FORCE 1)
 (env OPAMCOLOR always)
 (workdir /src)
 (run (shell "sudo ln -f /usr/bin/opam-2.2 /usr/bin/opam"))
 (run (shell "opam init --reinit -ni"))
 (run (shell "uname -rs && opam exec -- ocaml -version && opam --version"))
 (workdir /src)
 (run (shell "sudo chown opam /src"))
 (run (cache (opam-archives (target /home/opam/.opam/download-cache)))
      (network host)
      (shell "cd ~/opam-repository && (git cat-file -e 0329818dcfd3de1a722ea09eeeed94cd24caa375 || git fetch origin master) && git reset -q --hard 0329818dcfd3de1a722ea09eeeed94cd24caa375 && git log --no-decorate -n1 --oneline && opam update -u"))
 (copy (src multicore-bench.opam) (dst ./))
 (run (network host)
      (shell "opam pin add -yn multicore-bench.dev './'"))
 (env DEPS "astring.0.8.5 backoff.0.1.0 base-bigarray.base base-domains.base base-nnp.base base-threads.base base-unix.base camlp-streams.5.0.1 cmdliner.1.3.0 cppo.1.7.0 csexp.1.5.2 domain-local-await.1.0.1 domain_shims.0.1.0 dune.3.16.0 fmt.0.9.0 host-arch-s390x.1 host-system-other.1 logs.0.7.0 mdx.2.4.1 mtime.2.1.0 multicore-magic.2.3.0 ocaml.5.2.0 ocaml-base-compiler.5.2.0 ocaml-config.3 ocaml-options-vanilla.1 ocaml-version.3.6.8 ocamlbuild.0.15.0 ocamlfind.1.9.6 re.1.12.0 result.1.5 seq.base thread-table.1.0.0 topkg.1.0.7 yojson.2.2.2")
 (env CI true)
 (env OCAMLCI true)
 (run (cache (opam-archives (target /home/opam/.opam/download-cache)))
      (network host)
      (shell "opam update --depexts && opam install --cli=2.2 --depext-only -y multicore-bench.dev $DEPS"))
 (run (cache (opam-archives (target /home/opam/.opam/download-cache)))
      (network host)
      (shell "opam install $DEPS"))
 (copy (src .) (dst /src))
 (run (shell "opam exec -- dune build @install @check @runtest && rm -rf _build"))
)


2024-09-11 13:30.32: Waiting for resource in pool OCluster
2024-09-11 13:30.32: Waiting for worker…
2024-09-11 17:01.38: Got resource from pool OCluster
Building on s390x-worker-02.marist.ci.dev
All commits already cached
HEAD is now at 298c5d1 Add a naïve bounded queue benchmark


(from ocaml/opam:debian-12-ocaml-5.2@sha256:f1214d035f156f0c179bea17b48ffe43588d665368b61b14875e02564f92acec)
Unable to find image 'ocaml/opam:debian-12-ocaml-5.2@sha256:f1214d035f156f0c179bea17b48ffe43588d665368b61b14875e02564f92acec' locally
docker.io/ocaml/opam@sha256:f1214d035f156f0c179bea17b48ffe43588d665368b61b14875e02564f92acec: Pulling from ocaml/opam
cdec94ed2b92: Pulling fs layer
cdec94ed2b92: Verifying Checksum
cdec94ed2b92: Download complete
cdec94ed2b92: Pull complete
Digest: sha256:f1214d035f156f0c179bea17b48ffe43588d665368b61b14875e02564f92acec
Status: Downloaded newer image for ocaml/opam@sha256:f1214d035f156f0c179bea17b48ffe43588d665368b61b14875e02564f92acec
2024-09-11 17:01.38 ---> using "ce6df162ea28e95b07f4d0581d6a753ba9be8d949ea57a935286ba01d9d5c858" from cache


/: (comment debian-12-5.2_s390x_opam-2.2)


/: (user (uid 1000) (gid 1000))


/: (env CLICOLOR_FORCE 1)


/: (env OPAMCOLOR always)


/: (workdir /src)


/src: (run (shell "sudo ln -f /usr/bin/opam-2.2 /usr/bin/opam"))
2024-09-11 17:01.38 ---> using "9335f8d0a853253be1b31eb84ba4a5007028f139cc71114fcec639d0b581c6b4" from cache


/src: (run (shell "opam init --reinit -ni"))
Configuring from /home/opam/.opamrc and then from built-in defaults.
Checking for available remotes: rsync and local, git.
  - you won't be able to use mercurial repositories unless you install the hg command on your system.
  - you won't be able to use darcs repositories unless you install the darcs command on your system.


This development version of opam requires an update to the layout of /home/opam/.opam from version 2.0 to version 2.2, which can't be reverted.
You may want to back it up before going further.


Continue? [y/n] y
Format upgrade done.


<><> Updating repositories ><><><><><><><><><><><><><><><><><><><><><><><><><><>
[default] synchronised from file:///home/opam/opam-repository
2024-09-11 17:01.38 ---> using "5beff6346ab6f412482654184bb77cfbfadd782c00d47bf1d02ca7fd89ccbf6b" from cache


/src: (run (shell "uname -rs && opam exec -- ocaml -version && opam --version"))
Linux 5.15.0-119-generic
The OCaml toplevel, version 5.2.0
2.2.1
2024-09-11 17:01.38 ---> using "31cd3a19cdb7dca6c345c938cef73cdd165e9cb657ff3af05e9836a74c7eb8d9" from cache


/src: (workdir /src)


/src: (run (shell "sudo chown opam /src"))
2024-09-11 17:01.38 ---> using "102af61e7e3524d3c2e9236b3852a712d8aacda8870c0e1eed6b333ba96532a3" from cache


/src: (run (cache (opam-archives (target /home/opam/.opam/download-cache)))
           (network host)
           (shell "cd ~/opam-repository && (git cat-file -e 0329818dcfd3de1a722ea09eeeed94cd24caa375 || git fetch origin master) && git reset -q --hard 0329818dcfd3de1a722ea09eeeed94cd24caa375 && git log --no-decorate -n1 --oneline && opam update -u"))
From https://github.com/ocaml/opam-repository
 * branch                  master     -> FETCH_HEAD
   e89899ac28..0329818dcf  master     -> origin/master
0329818dcf Merge pull request #26527 from dbuenzli/b0-publish-mtime.2.1.0-etc-b00ab5a8b3cb608d


<><> Updating package repositories ><><><><><><><><><><><><><><><><><><><><><><>
[default] synchronised from file:///home/opam/opam-repository


Everything as up-to-date as possible (run with --verbose to show unavailable upgrades).
However, you may "opam upgrade" these packages explicitly, which will ask permission to downgrade or uninstall the conflicting packages.
Nothing to do.
# Run eval $(opam env) to update the current shell environment
2024-09-11 17:01.38 ---> using "4c35eb5709231b23564a4b5427d3823e105b0351117152fe6e0276f1a7451f06" from cache


/src: (copy (src multicore-bench.opam) (dst ./))
2024-09-11 17:01.39 ---> saved as "5f6959c74df2132d1c5be93239eec0f6ebf2eba5948e2cd969e104b67dc3c2db"


/src: (run (network host)
           (shell "opam pin add -yn multicore-bench.dev './'"))
[multicore-bench.dev] synchronised (file:///src)
multicore-bench is now pinned to file:///src (version dev)
2024-09-11 17:01.43 ---> saved as "e3cdf60e6df59dfb71ebd424390c085ca340da16edf8110c6cdfe33dc19259e1"


/src: (env DEPS "astring.0.8.5 backoff.0.1.0 base-bigarray.base base-domains.base base-nnp.base base-threads.base base-unix.base camlp-streams.5.0.1 cmdliner.1.3.0 cppo.1.7.0 csexp.1.5.2 domain-local-await.1.0.1 domain_shims.0.1.0 dune.3.16.0 fmt.0.9.0 host-arch-s390x.1 host-system-other.1 logs.0.7.0 mdx.2.4.1 mtime.2.1.0 multicore-magic.2.3.0 ocaml.5.2.0 ocaml-base-compiler.5.2.0 ocaml-config.3 ocaml-options-vanilla.1 ocaml-version.3.6.8 ocamlbuild.0.15.0 ocamlfind.1.9.6 re.1.12.0 result.1.5 seq.base thread-table.1.0.0 topkg.1.0.7 yojson.2.2.2")


/src: (env CI true)


/src: (env OCAMLCI true)


/src: (run (cache (opam-archives (target /home/opam/.opam/download-cache)))
           (network host)
           (shell "opam update --depexts && opam install --cli=2.2 --depext-only -y multicore-bench.dev $DEPS"))
+ /usr/bin/sudo "apt-get" "update"
- Get:1 http://deb.debian.org/debian bookworm InRelease [151 kB]
- Get:2 http://deb.debian.org/debian bookworm-updates InRelease [55.4 kB]
- Get:3 http://deb.debian.org/debian-security bookworm-security InRelease [48.0 kB]
- Get:4 http://deb.debian.org/debian bookworm/main s390x Packages [8454 kB]
- Get:5 http://deb.debian.org/debian bookworm-updates/main s390x Packages.diff/Index [11.7 kB]
- Get:6 http://deb.debian.org/debian-security bookworm-security/main s390x Packages [170 kB]
- Get:7 http://deb.debian.org/debian bookworm-updates/main s390x Packages T-2024-09-10-2011.55-F-2024-09-10-2011.55.pdiff [1105 B]
- Get:7 http://deb.debian.org/debian bookworm-updates/main s390x Packages T-2024-09-10-2011.55-F-2024-09-10-2011.55.pdiff [1105 B]
- Fetched 8891 kB in 2s (4939 kB/s)
- Reading package lists...
- 


<><> Synchronising pinned packages ><><><><><><><><><><><><><><><><><><><><><><>
[multicore-bench.dev] synchronised (no changes)


[NOTE] Package ocaml-options-vanilla is already installed (current version is 1).
[NOTE] Package ocaml-config is already installed (current version is 3).
[NOTE] Package ocaml-base-compiler is already installed (current version is 5.2.0).
[NOTE] Package ocaml is already installed (current version is 5.2.0).
[NOTE] Package host-system-other is already installed (current version is 1).
[NOTE] Package host-arch-s390x is already installed (current version is 1).
[NOTE] Package base-unix is already installed (current version is base).
[NOTE] Package base-threads is already installed (current version is base).
[NOTE] Package base-nnp is already installed (current version is base).
[NOTE] Package base-domains is already installed (current version is base).
[NOTE] Package base-bigarray is already installed (current version is base).
2024-09-11 17:02.02 ---> saved as "ca81496833e5470a98a067ffc328d1e1db32e28a069c75843de7f2a3500d0163"


/src: (run (cache (opam-archives (target /home/opam/.opam/download-cache)))
           (network host)
           (shell "opam install $DEPS"))
[NOTE] Package ocaml-options-vanilla is already installed (current version is 1).
[NOTE] Package ocaml-config is already installed (current version is 3).
[NOTE] Package ocaml-base-compiler is already installed (current version is 5.2.0).
[NOTE] Package ocaml is already installed (current version is 5.2.0).
[NOTE] Package host-system-other is already installed (current version is 1).
[NOTE] Package host-arch-s390x is already installed (current version is 1).
[NOTE] Package base-unix is already installed (current version is base).
[NOTE] Package base-threads is already installed (current version is base).
[NOTE] Package base-nnp is already installed (current version is base).
[NOTE] Package base-domains is already installed (current version is base).
[NOTE] Package base-bigarray is already installed (current version is base).
The following actions will be performed:
=== install 23 packages
  - install astring            0.8.5
  - install backoff            0.1.0
  - install camlp-streams      5.0.1
  - install cmdliner           1.3.0
  - install cppo               1.7.0
  - install csexp              1.5.2
  - install domain-local-await 1.0.1
  - install domain_shims       0.1.0
  - install dune               3.16.0
  - install fmt                0.9.0
  - install logs               0.7.0
  - install mdx                2.4.1
  - install mtime              2.1.0
  - install multicore-magic    2.3.0
  - install ocaml-version      3.6.8
  - install ocamlbuild         0.15.0
  - install ocamlfind          1.9.6
  - install re                 1.12.0
  - install result             1.5
  - install seq                base
  - install thread-table       1.0.0
  - install topkg              1.0.7
  - install yojson             2.2.2


<><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><>
-> retrieved backoff.0.1.0  (cached)
-> retrieved astring.0.8.5  (cached)
-> retrieved camlp-streams.5.0.1  (cached)
-> retrieved cmdliner.1.3.0  (cached)
-> retrieved cppo.1.7.0  (cached)
-> retrieved csexp.1.5.2  (cached)
-> retrieved domain-local-await.1.0.1  (cached)
-> retrieved domain_shims.0.1.0  (cached)
-> retrieved fmt.0.9.0  (cached)
-> retrieved logs.0.7.0  (cached)
-> retrieved mdx.2.4.1  (cached)
-> retrieved mtime.2.1.0  (cached)
-> retrieved multicore-magic.2.3.0  (cached)
-> retrieved dune.3.16.0  (cached)
-> retrieved ocaml-version.3.6.8  (cached)
-> retrieved ocamlbuild.0.15.0  (cached)
-> retrieved ocamlfind.1.9.6  (cached)
-> retrieved seq.base  (cached)
-> retrieved re.1.12.0  (cached)
-> retrieved result.1.5  (cached)
-> retrieved thread-table.1.0.0  (cached)
-> retrieved topkg.1.0.7  (cached)
-> installed cmdliner.1.3.0
-> retrieved yojson.2.2.2  (cached)
-> installed ocamlfind.1.9.6
-> installed seq.base
-> installed ocamlbuild.0.15.0
-> installed topkg.1.0.7
-> installed fmt.0.9.0
-> installed astring.0.8.5
-> installed mtime.2.1.0
-> installed logs.0.7.0
-> installed dune.3.16.0
-> installed backoff.0.1.0
-> installed camlp-streams.5.0.1
-> installed domain_shims.0.1.0
-> installed csexp.1.5.2
-> installed ocaml-version.3.6.8
-> installed multicore-magic.2.3.0
-> installed cppo.1.7.0
-> installed result.1.5
-> installed thread-table.1.0.0
-> installed domain-local-await.1.0.1
-> installed re.1.12.0
-> installed yojson.2.2.2
-> installed mdx.2.4.1
Done.
# Run eval $(opam env) to update the current shell environment
2024-09-11 17:03.02 ---> saved as "601c2b78a4931f395953fea01f6671d7c6b7e5ed8c3367182829454689c2bf05"


/src: (copy (src .) (dst /src))
2024-09-11 17:03.03 ---> saved as "17cf7359261fb6a204098c798f028af66263a13e6fceedceceb29c548e4b25ae"


/src: (run (shell "opam exec -- dune build @install @check @runtest && rm -rf _build"))
(cd _build/default/bench && ./main.exe -brief)
Atomic:
  time per op/get:
    1.65 ns
  ops over time/get:
    606.63 M/s
  time per op/incr:
    3.43 ns
  ops over time/incr:
    291.21 M/s
  time per op/push & pop:
    11.25 ns
  ops over time/push & pop:
    88.90 M/s
  time per op/cas int:
    4.65 ns
  ops over time/cas int:
    214.99 M/s
  time per op/xchg int:
    4.80 ns
  ops over time/xchg int:
    208.52 M/s
  time per op/swap:
    8.23 ns
  ops over time/swap:
    121.53 M/s
Atomic incr:
  time per op/CAS, 1 domains:
    3.74 ns
  ops over time/CAS, 1 domains:
    267.08 M/s
  time per op/CAS, 2 domains:
    11.78 ns
  ops over time/CAS, 2 domains:
    169.77 M/s
  time per op/CAS, 4 domains:
    24.50 ns
  ops over time/CAS, 4 domains:
    163.29 M/s
  time per op/CAS with backoff, 1 domains:
    5.13 ns
  ops over time/CAS with backoff, 1 domains:
    194.82 M/s
  time per op/CAS with backoff, 2 domains:
    11.65 ns
  ops over time/CAS with backoff, 2 domains:
    171.63 M/s
  time per op/CAS with backoff, 4 domains:
    31.50 ns
  ops over time/CAS with backoff, 4 domains:
    126.98 M/s
  time per op/Incr, 1 domains:
    2.57 ns
  ops over time/Incr, 1 domains:
    389.13 M/s
  time per op/Incr, 2 domains:
    6.39 ns
  ops over time/Incr, 2 domains:
    313.15 M/s
  time per op/Incr, 4 domains:
    246.41 ns
  ops over time/Incr, 4 domains:
    16.23 M/s
Bounded_q:
  time per message/one domain:
    75.85 ns
  messages over time/one domain:
    13.18 M/s
  time per message/1 adder, 1 taker:
    298.71 ns
  messages over time/1 adder, 1 taker:
    6.70 M/s
  time per message/1 adder, 2 takers:
    422.84 ns
  messages over time/1 adder, 2 takers:
    7.09 M/s
  time per message/2 adders, 1 taker:
    488.61 ns
  messages over time/2 adders, 1 taker:
    6.14 M/s
  time per message/2 adders, 2 takers:
    752.31 ns
  messages over time/2 adders, 2 takers:
    5.32 M/s
Hashtbl:
  time per operation/one domain, 10% reads:
    38.50 ns
  operations over time/one domain, 10% reads:
    25.97 M/s
  time per operation/one domain, 50% reads:
    49.40 ns
  operations over time/one domain, 50% reads:
    20.24 M/s
  time per operation/one domain, 90% reads:
    30.07 ns
  operations over time/one domain, 90% reads:
    33.26 M/s
  time per operation/1 worker, 10% reads:
    54.36 ns
  operations over time/1 worker, 10% reads:
    18.40 M/s
  time per operation/2 workers, 10% reads:
    231.67 ns
  operations over time/2 workers, 10% reads:
    8.63 M/s
  time per operation/4 workers, 10% reads:
    569.67 ns
  operations over time/4 workers, 10% reads:
    7.02 M/s
  time per operation/8 workers, 10% reads:
    1437.48 ns
  operations over time/8 workers, 10% reads:
    5.57 M/s
  time per operation/1 worker, 50% reads:
    53.75 ns
  operations over time/1 worker, 50% reads:
    18.61 M/s
  time per operation/2 workers, 50% reads:
    212.98 ns
  operations over time/2 workers, 50% reads:
    9.39 M/s
  time per operation/4 workers, 50% reads:
    392.36 ns
  operations over time/4 workers, 50% reads:
    10.19 M/s
  time per operation/8 workers, 50% reads:
    1287.28 ns
  operations over time/8 workers, 50% reads:
    6.21 M/s
  time per operation/1 worker, 90% reads:
    51.29 ns
  operations over time/1 worker, 90% reads:
    19.50 M/s
  time per operation/2 workers, 90% reads:
    151.59 ns
  operations over time/2 workers, 90% reads:
    13.19 M/s
  time per operation/4 workers, 90% reads:
    340.98 ns
  operations over time/4 workers, 90% reads:
    11.73 M/s
  time per operation/8 workers, 90% reads:
    1112.34 ns
  operations over time/8 workers, 90% reads:
    7.19 M/s
Queue:
  time per message/one domain:
    30.10 ns
  messages over time/one domain:
    33.23 M/s
Ref with Mutex:
  time per op/get:
    16.43 ns
  ops over time/get:
    60.86 M/s
  time per op/incr:
    16.80 ns
  ops over time/incr:
    59.52 M/s
  time per op/push & pop:
    23.44 ns
  ops over time/push & pop:
    42.67 M/s
  time per op/cas int:
    19.90 ns
  ops over time/cas int:
    50.25 M/s
  time per op/xchg int:
    19.70 ns
  ops over time/xchg int:
    50.76 M/s
  time per op/swap:
    20.73 ns
  ops over time/swap:
    48.23 M/s
Ref with [@poll error]:
  time per op/get:
    1.67 ns
  ops over time/get:
    599.55 M/s
  time per op/incr:
    2.05 ns
  ops over time/incr:
    488.67 M/s
  time per op/push & pop:
    19.75 ns
  ops over time/push & pop:
    50.63 M/s
  time per op/cas int:
    4.83 ns
  ops over time/cas int:
    207.12 M/s
  time per op/xchg int:
    4.95 ns
  ops over time/xchg int:
    202.14 M/s
  time per op/swap:
    7.76 ns
  ops over time/swap:
    128.86 M/s
Stack:
  time per message/one domain:
    22.82 ns
  messages over time/one domain:
    43.82 M/s
Unix:
  time per blocking read/1 worker:
    448.89 ns
  blocking reads over time/1 worker:
    2.23 M/s
  time per blocking read/2 workers:
    380.62 ns
  blocking reads over time/2 workers:
    5.25 M/s
  time per blocking read/4 workers:
    807.56 ns
  blocking reads over time/4 workers:
    4.95 M/s
2024-09-11 17:03.37 ---> saved as "c1024f6a9b58c83c25caeb3d58e8ae1072112eec8c81840f6902b9f60fddec01"
Job succeeded
2024-09-11 17:03.38: Job succeeded