2024-06-30 13:59.47: New job: test mirage/ocaml-cohttp https://github.com/mirage/ocaml-cohttp.git#refs/pull/1035/head (c29f936c9132cbe09b1dec85f61847bbada53f31) (linux-x86_64:(lint-fmt)) Base: ocaml/opam@sha256:2a1f8dec7c586360764c898993d435aea0db4200799babfa08b3b600d6bf4609 ocamlformat version: version 0.20.0 (from opam) To reproduce locally: git clone --recursive "https://github.com/mirage/ocaml-cohttp.git" && cd "ocaml-cohttp" && git fetch origin "refs/pull/1035/head" && git reset --hard c29f936c cat > Dockerfile <<'END-OF-DOCKERFILE' FROM ocaml/opam@sha256:2a1f8dec7c586360764c898993d435aea0db4200799babfa08b3b600d6bf4609 USER 1000:1000 RUN cd ~/opam-repository && (git cat-file -e a6069b9eebba0e2b70cdbbd834bc800eb6d671fb || git fetch origin master) && git reset -q --hard a6069b9eebba0e2b70cdbbd834bc800eb6d671fb && git log --no-decorate -n1 --oneline && opam update -u RUN opam depext -i dune WORKDIR /src RUN opam depext -i ocamlformat=0.20.0 COPY --chown=1000:1000 . /src/ RUN opam exec -- dune build @fmt --ignore-promoted-rules || (echo "dune build @fmt failed"; exit 2) END-OF-DOCKERFILE docker build . END-REPRO-BLOCK 2024-06-30 13:59.47: Using cache hint "mirage/ocaml-cohttp-ocaml/opam@sha256:2a1f8dec7c586360764c898993d435aea0db4200799babfa08b3b600d6bf4609-debian-12-4.08_opam-2.1-ocamlformat-a6069b9eebba0e2b70cdbbd834bc800eb6d671fb" 2024-06-30 13:59.47: Using OBuilder spec: ((from ocaml/opam@sha256:2a1f8dec7c586360764c898993d435aea0db4200799babfa08b3b600d6bf4609) (user (uid 1000) (gid 1000)) (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "cd ~/opam-repository && (git cat-file -e a6069b9eebba0e2b70cdbbd834bc800eb6d671fb || git fetch origin master) && git reset -q --hard a6069b9eebba0e2b70cdbbd834bc800eb6d671fb && git log --no-decorate -n1 --oneline && opam update -u")) (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam depext -i dune")) (workdir /src) (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam depext -i ocamlformat=0.20.0")) (copy (src .) (dst /src/)) (run (shell "opam exec -- dune build @fmt --ignore-promoted-rules || (echo \"dune build @fmt failed\"; exit 2)")) ) 2024-06-30 13:59.47: Waiting for resource in pool OCluster 2024-06-30 14:10.19: Waiting for worker… 2024-06-30 14:13.59: Got resource from pool OCluster Building on x86-bm-c1.sw.ocaml.org All commits already cached HEAD is now at c29f936c Fix Cohttp EOF read with Lwt_unix recv MSG_PEEK (from ocaml/opam@sha256:2a1f8dec7c586360764c898993d435aea0db4200799babfa08b3b600d6bf4609) Unable to find image 'ocaml/opam@sha256:2a1f8dec7c586360764c898993d435aea0db4200799babfa08b3b600d6bf4609' locally docker.io/ocaml/opam@sha256:2a1f8dec7c586360764c898993d435aea0db4200799babfa08b3b600d6bf4609: Pulling from ocaml/opam 32aa6089d8b4: Pulling fs layer 32aa6089d8b4: Verifying Checksum 32aa6089d8b4: Download complete 32aa6089d8b4: Pull complete Digest: sha256:2a1f8dec7c586360764c898993d435aea0db4200799babfa08b3b600d6bf4609 Status: Downloaded newer image for ocaml/opam@sha256:2a1f8dec7c586360764c898993d435aea0db4200799babfa08b3b600d6bf4609 2024-06-30 14:13.59 ---> using "20ade4b6db603de4c3d3c7688e2141ab550c5db85c35791db0d4befd2f9e45d0" from cache /: (user (uid 1000) (gid 1000)) /: (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "cd ~/opam-repository && (git cat-file -e a6069b9eebba0e2b70cdbbd834bc800eb6d671fb || git fetch origin master) && git reset -q --hard a6069b9eebba0e2b70cdbbd834bc800eb6d671fb && git log --no-decorate -n1 --oneline && opam update -u")) a6069b9eeb [new release] dune (15 packages) (3.16.0) <><> Updating package repositories ><><><><><><><><><><><><><><><><><><><><><><> [default] synchronised from file:///home/opam/opam-repository default (at file:///home/opam/opam-repository): [INFO] opam 2.1 includes many performance improvements over 2.0; please consider upgrading (https://opam.ocaml.org/doc/Install.html) Everything as up-to-date as possible (run with --verbose to show unavailable upgrades). However, you may "opam upgrade" these packages explicitly, which will ask permission to downgrade or uninstall the conflicting packages. Nothing to do. # Run eval $(opam env) to update the current shell environment 2024-06-30 14:13.59 ---> using "611f99113b8eff40d7b05496ac40878251881d20d0d0f82061a58449451818e0" from cache /: (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam depext -i dune")) # Detecting depexts using vars: arch=x86_64, os=linux, os-distribution=debian, os-family=debian # No extra OS packages requirements found. # All required OS packages found. # Now letting opam install the packages The following actions will be performed: - install dune 3.16.0 <><> Gathering sources ><><><><><><><><><><><><><><><><><><><><><><><><><><><><> [dune.3.16.0] found in cache <><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><> -> installed dune.3.16.0 Done. # Run eval $(opam env) to update the current shell environment 2024-06-30 14:13.59 ---> using "93fe4dba2ad9c2d06e78131314a07326068c040feffac1658ff18606c4876dbd" from cache /: (workdir /src) /src: (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam depext -i ocamlformat=0.20.0")) # Detecting depexts using vars: arch=x86_64, os=linux, os-distribution=debian, os-family=debian # No extra OS packages requirements found. # All required OS packages found. # Now letting opam install the packages The following actions will be performed: - install sexplib0 v0.14.0 [required by base] - install ocamlbuild 0.14.3 [required by fpath, uuseg] - install menhirCST 20231231 [required by menhir] - install either 1.0.0 [required by ocamlformat] - install menhirSdk 20231231 [required by ocamlformat] - install ocaml-version 3.5.0 [required by ocamlformat] - install ocamlfind 1.9.6 [required by ocp-indent, fpath, uuseg] - install cmdliner 1.3.0 [required by ocamlformat] - install menhirLib 20231231 [required by ocamlformat] - install result 1.5 [required by odoc-parser] - install seq base [required by re] - install csexp 1.5.2 [required by dune-configurator] - install dune-build-info 3.16.0 [required by ocamlformat] - install fix 20230505 [required by ocamlformat] - install topkg 1.0.7 [required by fpath, uuseg] - install base-bytes base [required by ocp-indent] - install menhir 20231231 [required by ocamlformat] - install re 1.11.0 [required by ocamlformat] - install dune-configurator 3.16.0 [required by base] - install uutf 1.0.3 [required by ocamlformat] - install astring 0.8.5 [required by fpath, odoc-parser] - install ocp-indent 1.8.1 [required by ocamlformat] - install base v0.14.3 [required by ocamlformat] - install uucp 15.0.0 [required by uuseg] - install odoc-parser 0.9.0 [required by ocamlformat] - install fpath 0.7.3 [required by ocamlformat] - install stdio v0.14.0 [required by ocamlformat] - install uuseg 15.0.0 [required by ocamlformat] - install ocamlformat 0.20.0 ===== 29 to install ===== <><> Gathering sources ><><><><><><><><><><><><><><><><><><><><><><><><><><><><> [astring.0.8.5] found in cache [base.v0.14.3] found in cache [cmdliner.1.3.0] found in cache [csexp.1.5.2] found in cache [dune-build-info.3.16.0] found in cache [dune-configurator.3.16.0] found in cache [either.1.0.0] found in cache [fix.20230505] found in cache [fpath.0.7.3] found in cache [menhir.20231231] found in cache [menhirCST.20231231] found in cache [menhirLib.20231231] found in cache [menhirSdk.20231231] found in cache [ocaml-version.3.5.0] found in cache [ocamlbuild.0.14.3] found in cache [ocamlfind.1.9.6] found in cache [ocamlformat.0.20.0] found in cache [ocp-indent.1.8.1] found in cache [odoc-parser.0.9.0] found in cache [re.1.11.0] found in cache [result.1.5] found in cache [sexplib0.v0.14.0] found in cache [stdio.v0.14.0] found in cache [topkg.1.0.7] found in cache [uucp.15.0.0] found in cache [uuseg.15.0.0] found in cache [uutf.1.0.3] found in cache <><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><> -> installed seq.base -> installed csexp.1.5.2 -> installed cmdliner.1.3.0 -> installed either.1.0.0 -> installed fix.20230505 -> installed menhirCST.20231231 -> installed menhirLib.20231231 -> installed menhirSdk.20231231 -> installed ocaml-version.3.5.0 -> installed result.1.5 -> installed sexplib0.v0.14.0 -> installed re.1.11.0 -> installed dune-build-info.3.16.0 -> installed dune-configurator.3.16.0 -> installed ocamlfind.1.9.6 -> installed base-bytes.base -> installed ocamlbuild.0.14.3 -> installed ocp-indent.1.8.1 -> installed base.v0.14.3 -> installed topkg.1.0.7 -> installed stdio.v0.14.0 -> installed uutf.1.0.3 -> installed astring.0.8.5 -> installed odoc-parser.0.9.0 -> installed fpath.0.7.3 -> installed menhir.20231231 -> installed uucp.15.0.0 -> installed uuseg.15.0.0 -> installed ocamlformat.0.20.0 Done. <><> ocp-indent.1.8.1 installed successfully ><><><><><><><><><><><><><><><><><> => This package requires additional configuration for use in editors. Install package 'user-setup', or manually: * for Emacs, add these lines to ~/.emacs: (add-to-list 'load-path "/home/opam/.opam/4.08/share/emacs/site-lisp") (require 'ocp-indent) * for Vim, add this line to ~/.vimrc: set rtp^="/home/opam/.opam/4.08/share/ocp-indent/vim" # Run eval $(opam env) to update the current shell environment 2024-06-30 14:15.51 ---> saved as "8fb8db7f20734b96640d65c7cbdfde513ea96f677694a818e2e7981a9a0e4a08" /src: (copy (src .) (dst /src/)) 2024-06-30 14:15.51 ---> saved as "ad45fa35c5ff86d6e723fe2641269a4367d8c0389cd8fa27303a7664fc346ff4" /src: (run (shell "opam exec -- dune build @fmt --ignore-promoted-rules || (echo \"dune build @fmt failed\"; exit 2)")) File "examples/async/dune", line 1, characters 0-0: diff --git a/_build/default/examples/async/dune b/_build/default/examples/async/.formatted/dune index 8d875dd..a8bf514 100644 --- a/_build/default/examples/async/dune +++ b/_build/default/examples/async/.formatted/dune @@ -1,6 +1,7 @@ (executables (names hello_world receive_post s3_cp) - (libraries mirage-crypto cohttp-async base async_kernel core_unix.command_unix)) + (libraries mirage-crypto cohttp-async base async_kernel + core_unix.command_unix)) (alias (name runtest) File "cohttp-lwt-unix/bin/dune", line 1, characters 0-0: diff --git a/_build/default/cohttp-lwt-unix/bin/dune b/_build/default/cohttp-lwt-unix/bin/.formatted/dune index b8ae61a..63e95e9 100644 --- a/_build/default/cohttp-lwt-unix/bin/dune +++ b/_build/default/cohttp-lwt-unix/bin/.formatted/dune @@ -1,14 +1,6 @@ (executables (names cohttp_curl_lwt cohttp_proxy_lwt cohttp_server_lwt) - (libraries - cohttp-lwt-unix - cohttp_server - logs - logs.lwt - logs.fmt - logs.cli - cmdliner - conduit-lwt - fmt.tty) + (libraries cohttp-lwt-unix cohttp_server logs logs.lwt logs.fmt logs.cli + cmdliner conduit-lwt fmt.tty) (package cohttp-lwt-unix) (public_names cohttp-curl-lwt cohttp-proxy-lwt cohttp-server-lwt)) File "cohttp-async/src/server.ml", line 1, characters 0-0: diff --git a/_build/default/cohttp-async/src/server.ml b/_build/default/cohttp-async/src/.formatted/server.ml index d269641..c3c1fa2 100644 --- a/_build/default/cohttp-async/src/server.ml +++ b/_build/default/cohttp-async/src/.formatted/server.ml @@ -87,14 +87,14 @@ let handle_client handle_request sock rd wr = Body.drain body >>| fun () -> Ivar.fill_if_empty finished () | `Response (req, body, (res, res_body)) -> (* There are scenarios if a client leaves before consuming the full response, - we might have a reference to an async Pipe that doesn't get drained. + we might have a reference to an async Pipe that doesn't get drained. - Not draining or closing a pipe can lead to issues if its holding a resource like - a file handle as those resources will never be closed, leading to a leak. + Not draining or closing a pipe can lead to issues if its holding a resource like + a file handle as those resources will never be closed, leading to a leak. - Async writers have a promise that's fulfilled whenever they are closed, - so we can use it to schedule a close operation on the stream to ensure that we - don't leave a stream open if the underlying channels are closed. *) + Async writers have a promise that's fulfilled whenever they are closed, + so we can use it to schedule a close operation on the stream to ensure that we + don't leave a stream open if the underlying channels are closed. *) (match res_body with | `Empty | `String _ | `Strings _ -> () | `Pipe stream -> File "cohttp-async/test/test_async_integration.ml", line 1, characters 0-0: diff --git a/_build/default/cohttp-async/test/test_async_integration.ml b/_build/default/cohttp-async/test/.formatted/test_async_integration.ml index 32a2a6a..8780017 100644 --- a/_build/default/cohttp-async/test/test_async_integration.ml +++ b/_build/default/cohttp-async/test/.formatted/test_async_integration.ml @@ -111,7 +111,8 @@ let ts = ("Pipe with empty strings", Pipe.of_list [ ""; ""; "" ], true); ] in - Deferred.List.iter ~how:`Sequential tests ~f:(fun (msg, pipe, expected) -> + Deferred.List.iter ~how:`Sequential tests + ~f:(fun (msg, pipe, expected) -> is_empty (`Pipe pipe) >>| fun real -> assert_equal ~msg expected real) >>= fun () -> File "examples/async/s3_cp.ml", line 1, characters 0-0: diff --git a/_build/default/examples/async/s3_cp.ml b/_build/default/examples/async/.formatted/s3_cp.ml index 48a6f64..735dcaf 100644 --- a/_build/default/examples/async/s3_cp.ml +++ b/_build/default/examples/async/.formatted/s3_cp.ml @@ -44,7 +44,6 @@ open Core open Async open Cohttp open Cohttp_async - module Time = Time_float let ksrt (k, _) (k', _) = String.compare k k' dune build @fmt failed "/usr/bin/env" "bash" "-c" "opam exec -- dune build @fmt --ignore-promoted-rules || (echo "dune build @fmt failed"; exit 2)" failed with exit status 2 2024-06-30 14:15.53: Job failed: Failed: Build failed