2025-10-15 10:13.31: New job: test dinosaure/caravan https://github.com/dinosaure/caravan.git#refs/heads/master (375c092fb24ac877a4d3aeccf5042ef389e87b32) (linux-arm64:debian-13-5.3_arm64_opam-2.4) Base: ocaml/opam:debian-13-ocaml-5.3@sha256:2f403ea38b73d4814a696d5b8204d90b4708d4da5cedfa25b2c6d6f4c809640b Opam project build To reproduce locally: git clone --recursive "https://github.com/dinosaure/caravan.git" -b "master" && cd "caravan" && git reset --hard 375c092f cat > Dockerfile <<'END-OF-DOCKERFILE' FROM ocaml/opam:debian-13-ocaml-5.3@sha256:2f403ea38b73d4814a696d5b8204d90b4708d4da5cedfa25b2c6d6f4c809640b # debian-13-5.3_arm64_opam-2.4 USER 1000:1000 ENV CLICOLOR_FORCE="1" ENV OPAMCOLOR="always" WORKDIR /src RUN sudo ln -f /usr/bin/opam-2.4 /usr/bin/opam RUN opam init --reinit -ni RUN uname -rs && opam exec -- ocaml -version && opam --version WORKDIR /src RUN sudo chown opam /src RUN cd ~/opam-repository && (git cat-file -e dbd126f1b3e13b70b1010ac087a896c6f0d80bc5 || git fetch origin master) && git reset -q --hard dbd126f1b3e13b70b1010ac087a896c6f0d80bc5 && git log --no-decorate -n1 --oneline && opam update -u COPY --chown=1000:1000 provision.opam caravan.opam ./ RUN opam pin add -yn provision.dev './' && \ opam pin add -yn caravan.dev './' RUN echo '(lang dune 3.0)' > './dune-project' ENV DEPS="astring.0.8.5 base-bigarray.base base-bytes.base base-domains.base base-effects.base base-nnp.base base-threads.base base-unix.base bigarray-compat.1.1.0 bigstringaf.0.10.0 bos.0.2.1 cmdliner.2.0.0 csexp.1.5.2 dune.3.20.2 dune-configurator.3.20.2 fmt.0.11.0 fpath.0.7.3 logs.0.9.0 mmap.1.2.0 ocaml.5.3.0 ocaml-base-compiler.5.3.0 ocaml-compiler.5.3.0 ocaml-config.3 ocaml-options-vanilla.1 ocamlbuild.0.16.1 ocamlfind.1.9.8 rresult.0.7.0 topkg.1.1.0" ENV CI="true" ENV OCAMLCI="true" RUN opam update --depexts && opam install --cli=2.4 --depext-only -y provision.dev caravan.dev $DEPS RUN opam install $DEPS COPY --chown=1000:1000 . /src RUN opam exec -- dune build @install @check @runtest && rm -rf _build END-OF-DOCKERFILE docker build . END-REPRO-BLOCK 2025-10-15 10:13.31: Using cache hint "dinosaure/caravan-ocaml/opam:debian-13-ocaml-5.3@sha256:2f403ea38b73d4814a696d5b8204d90b4708d4da5cedfa25b2c6d6f4c809640b-debian-13-5.3_arm64_opam-2.4-90ac6ba21f8e80fd74ea0dbffb58ebbb" 2025-10-15 10:13.31: Using OBuilder spec: ((from ocaml/opam:debian-13-ocaml-5.3@sha256:2f403ea38b73d4814a696d5b8204d90b4708d4da5cedfa25b2c6d6f4c809640b) (comment debian-13-5.3_arm64_opam-2.4) (user (uid 1000) (gid 1000)) (env CLICOLOR_FORCE 1) (env OPAMCOLOR always) (workdir /src) (run (shell "sudo ln -f /usr/bin/opam-2.4 /usr/bin/opam")) (run (shell "opam init --reinit -ni")) (run (shell "uname -rs && opam exec -- ocaml -version && opam --version")) (workdir /src) (run (shell "sudo chown opam /src")) (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "cd ~/opam-repository && (git cat-file -e dbd126f1b3e13b70b1010ac087a896c6f0d80bc5 || git fetch origin master) && git reset -q --hard dbd126f1b3e13b70b1010ac087a896c6f0d80bc5 && git log --no-decorate -n1 --oneline && opam update -u")) (copy (src provision.opam caravan.opam) (dst ./)) (run (network host) (shell "opam pin add -yn provision.dev './' && \ \nopam pin add -yn caravan.dev './'")) (run (network host) (shell "echo '(lang dune 3.0)' > './dune-project'")) (env DEPS "astring.0.8.5 base-bigarray.base base-bytes.base base-domains.base base-effects.base base-nnp.base base-threads.base base-unix.base bigarray-compat.1.1.0 bigstringaf.0.10.0 bos.0.2.1 cmdliner.2.0.0 csexp.1.5.2 dune.3.20.2 dune-configurator.3.20.2 fmt.0.11.0 fpath.0.7.3 logs.0.9.0 mmap.1.2.0 ocaml.5.3.0 ocaml-base-compiler.5.3.0 ocaml-compiler.5.3.0 ocaml-config.3 ocaml-options-vanilla.1 ocamlbuild.0.16.1 ocamlfind.1.9.8 rresult.0.7.0 topkg.1.1.0") (env CI true) (env OCAMLCI true) (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam update --depexts && opam install --cli=2.4 --depext-only -y provision.dev caravan.dev $DEPS")) (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam install $DEPS")) (copy (src .) (dst /src)) (run (shell "opam exec -- dune build @install @check @runtest && rm -rf _build")) ) 2025-10-15 10:13.31: Waiting for resource in pool OCluster 2025-10-15 10:31.52: Waiting for worker… 2025-10-15 10:48.38: Got resource from pool OCluster Building on kydoime.caelum.ci.dev hint: Using 'master' as the name for the initial branch. This default branch name hint: is subject to change. To configure the initial branch name to use in all hint: of your new repositories, which will suppress this warning, call: hint: hint: git config --global init.defaultBranch <name> hint: hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and hint: 'development'. The just-created branch can be renamed via this command: hint: hint: git branch -m <name> Initialized empty Git repository in /var/cache/obuilder/ocluster/git/caravan.git-9a809696812b71980feaf6cd6cbee0afaeef1e9a/.git/ HEAD is now at 375c092 Merge remote-tracking branch 'origin/master' (from ocaml/opam:debian-13-ocaml-5.3@sha256:2f403ea38b73d4814a696d5b8204d90b4708d4da5cedfa25b2c6d6f4c809640b) Unable to find image 'ocaml/opam:debian-13-ocaml-5.3@sha256:2f403ea38b73d4814a696d5b8204d90b4708d4da5cedfa25b2c6d6f4c809640b' locally docker.io/ocaml/opam@sha256:2f403ea38b73d4814a696d5b8204d90b4708d4da5cedfa25b2c6d6f4c809640b: Pulling from ocaml/opam b30f95c80de8: Pulling fs layer b30f95c80de8: Verifying Checksum b30f95c80de8: Download complete b30f95c80de8: Pull complete Digest: sha256:2f403ea38b73d4814a696d5b8204d90b4708d4da5cedfa25b2c6d6f4c809640b Status: Downloaded newer image for ocaml/opam@sha256:2f403ea38b73d4814a696d5b8204d90b4708d4da5cedfa25b2c6d6f4c809640b 2025-10-15 10:48.39 ---> using "4d615cdda566698bbcd9991a4a40be1d70fb4ef06a15b0fce6c66534a55a309b" from cache /: (comment debian-13-5.3_arm64_opam-2.4) /: (user (uid 1000) (gid 1000)) /: (env CLICOLOR_FORCE 1) /: (env OPAMCOLOR always) /: (workdir /src) /src: (run (shell "sudo ln -f /usr/bin/opam-2.4 /usr/bin/opam")) 2025-10-15 10:48.39 ---> using "4b8af8f5f3b9fb88c7285e72392c1160a2afce85a86b22e8ec02963ab4c7c4c8" from cache /src: (run (shell "opam init --reinit -ni")) Configuring from /home/opam/.opamrc and then from built-in defaults. Checking for available remotes: rsync and local, git. - you won't be able to use mercurial repositories unless you install the hg command on your system. - you won't be able to use darcs repositories unless you install the darcs command on your system. This version of opam requires an update to the layout of /home/opam/.opam from version 2.0 to version 2.2, which can't be reverted. You may want to back it up before going further. Continue? [Y/n] y Format upgrade done. <><> Updating repositories ><><><><><><><><><><><><><><><><><><><><><><><><><><> [default] Initialised 2025-10-15 10:48.39 ---> using "005a8ac471cf50e60a78876f87bd10bd44d6092b5f5aaa859da20d56469d42d7" from cache /src: (run (shell "uname -rs && opam exec -- ocaml -version && opam --version")) Linux 5.15.0-156-generic The OCaml toplevel, version 5.3.0 2.4.1 2025-10-15 10:48.39 ---> using "12e5c7be6d7a96f552afd07a1975e27a6a863b6f60993d81e810e799e38206a9" from cache /src: (workdir /src) /src: (run (shell "sudo chown opam /src")) 2025-10-15 10:48.39 ---> using "6f9f41224455052baf54a8b532b9b63157a1d747d6e5e272fcfef745461b11da" from cache /src: (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "cd ~/opam-repository && (git cat-file -e dbd126f1b3e13b70b1010ac087a896c6f0d80bc5 || git fetch origin master) && git reset -q --hard dbd126f1b3e13b70b1010ac087a896c6f0d80bc5 && git log --no-decorate -n1 --oneline && opam update -u")) dbd126f1b3 Merge pull request #28599 from dbuenzli/b0-publish-cmdliner.2.0.0 <><> Updating package repositories ><><><><><><><><><><><><><><><><><><><><><><> [default] synchronised from git+file:///home/opam/opam-repository Already up-to-date. Nothing to do. # To update the current shell environment, run: eval $(opam env) 2025-10-15 10:48.39 ---> using "bce89bfba266252bec53d99cb89b49433239957c0be59469276a858bf90ed5d9" from cache /src: (copy (src provision.opam caravan.opam) (dst ./)) 2025-10-15 10:48.39 ---> saved as "c2a57cfb3e0463f75412f32405411438f8ace8428a588abb065539edfcd5b206" /src: (run (network host) (shell "opam pin add -yn provision.dev './' && \ \nopam pin add -yn caravan.dev './'")) [NOTE] Package provision does not exist in opam repositories registered in the current switch. [provision.dev] synchronised (file:///src) provision is now pinned to file:///src (version dev) [NOTE] Package caravan does not exist in opam repositories registered in the current switch. [caravan.dev] synchronised (file:///src) caravan is now pinned to file:///src (version dev) 2025-10-15 10:48.42 ---> saved as "2783c05264a26533d2a5be917b48488072ece46ee4d529d41aad9322b44980b6" /src: (run (network host) (shell "echo '(lang dune 3.0)' > './dune-project'")) 2025-10-15 10:48.42 ---> saved as "44e26463a08f1121b553cab626a2fdc67ed4d244f78bebec78fbf56f742c24ff" /src: (env DEPS "astring.0.8.5 base-bigarray.base base-bytes.base base-domains.base base-effects.base base-nnp.base base-threads.base base-unix.base bigarray-compat.1.1.0 bigstringaf.0.10.0 bos.0.2.1 cmdliner.2.0.0 csexp.1.5.2 dune.3.20.2 dune-configurator.3.20.2 fmt.0.11.0 fpath.0.7.3 logs.0.9.0 mmap.1.2.0 ocaml.5.3.0 ocaml-base-compiler.5.3.0 ocaml-compiler.5.3.0 ocaml-config.3 ocaml-options-vanilla.1 ocamlbuild.0.16.1 ocamlfind.1.9.8 rresult.0.7.0 topkg.1.1.0") /src: (env CI true) /src: (env OCAMLCI true) /src: (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam update --depexts && opam install --cli=2.4 --depext-only -y provision.dev caravan.dev $DEPS")) + /usr/bin/sudo "apt-get" "update" - Hit:1 http://deb.debian.org/debian trixie InRelease - Get:2 http://deb.debian.org/debian trixie-updates InRelease [47.3 kB] - Get:3 http://deb.debian.org/debian-security trixie-security InRelease [43.4 kB] - Fetched 90.7 kB in 0s (1032 kB/s) - Reading package lists... <><> Synchronising pinned packages ><><><><><><><><><><><><><><><><><><><><><><> [caravan.dev] synchronised (file:///src) [provision.dev] synchronised (file:///src) [NOTE] Package ocaml-options-vanilla is already installed (current version is 1). [NOTE] Package ocaml-config is already installed (current version is 3). [NOTE] Package ocaml-compiler is already installed (current version is 5.3.0). [NOTE] Package ocaml-base-compiler is already installed (current version is 5.3.0). [NOTE] Package ocaml is already installed (current version is 5.3.0). [NOTE] Package base-unix is already installed (current version is base). [NOTE] Package base-threads is already installed (current version is base). [NOTE] Package base-nnp is already installed (current version is base). [NOTE] Package base-effects is already installed (current version is base). [NOTE] Package base-domains is already installed (current version is base). [NOTE] Package base-bigarray is already installed (current version is base). 2025-10-15 10:48.52 ---> saved as "ba0e057b3f717993a6827224513f9cdde70303711359a45b65ffa822d28b7837" /src: (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam install $DEPS")) [NOTE] Package ocaml-options-vanilla is already installed (current version is 1). [NOTE] Package ocaml-config is already installed (current version is 3). [NOTE] Package ocaml-compiler is already installed (current version is 5.3.0). [NOTE] Package ocaml-base-compiler is already installed (current version is 5.3.0). [NOTE] Package ocaml is already installed (current version is 5.3.0). [NOTE] Package base-unix is already installed (current version is base). [NOTE] Package base-threads is already installed (current version is base). [NOTE] Package base-nnp is already installed (current version is base). [NOTE] Package base-effects is already installed (current version is base). [NOTE] Package base-domains is already installed (current version is base). [NOTE] Package base-bigarray is already installed (current version is base). The following actions will be performed: === install 17 packages - install astring 0.8.5 - install base-bytes base - install bigarray-compat 1.1.0 - install bigstringaf 0.10.0 - install bos 0.2.1 - install cmdliner 2.0.0 - install csexp 1.5.2 - install dune 3.20.2 - install dune-configurator 3.20.2 - install fmt 0.11.0 - install fpath 0.7.3 - install logs 0.9.0 - install mmap 1.2.0 - install ocamlbuild 0.16.1 - install ocamlfind 1.9.8 - install rresult 0.7.0 - install topkg 1.1.0 <><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><> -> retrieved astring.0.8.5 (cached) -> retrieved bigarray-compat.1.1.0 (cached) -> retrieved bigstringaf.0.10.0 (cached) -> retrieved csexp.1.5.2 (cached) -> retrieved bos.0.2.1 (cached) -> retrieved cmdliner.2.0.0 (cached) -> retrieved fmt.0.11.0 (cached) -> retrieved fpath.0.7.3 (cached) -> retrieved logs.0.9.0 (cached) -> retrieved mmap.1.2.0 (cached) -> retrieved ocamlbuild.0.16.1 (cached) -> retrieved ocamlfind.1.9.8 (cached) -> retrieved rresult.0.7.0 (cached) -> retrieved topkg.1.1.0 (cached) -> retrieved dune.3.20.2, dune-configurator.3.20.2 (cached) -> installed cmdliner.2.0.0 -> installed ocamlbuild.0.16.1 -> installed ocamlfind.1.9.8 -> installed base-bytes.base -> installed topkg.1.1.0 -> installed rresult.0.7.0 -> installed fmt.0.11.0 -> installed astring.0.8.5 -> installed fpath.0.7.3 -> installed logs.0.9.0 -> installed bos.0.2.1 -> installed dune.3.20.2 -> installed csexp.1.5.2 -> installed bigarray-compat.1.1.0 -> installed mmap.1.2.0 -> installed dune-configurator.3.20.2 -> installed bigstringaf.0.10.0 Done. # To update the current shell environment, run: eval $(opam env) 2025-10-15 10:49.35 ---> saved as "47aab30f93b88554257268bcaf6db14823d92a813d7edbb62e93877d6a5b2591" /src: (copy (src .) (dst /src)) 2025-10-15 10:49.35 ---> saved as "8406705860fc8d71ad3d1da89230b5010e6b06153b647a52d9ea09e63f0083d0" /src: (run (shell "opam exec -- dune build @install @check @runtest && rm -rf _build")) File "example/dune", line 4, characters 12-22: 4 | (libraries hxd.string fmt provision)) ^^^^^^^^^^ Error: Library "hxd.string" not found. -> required by _build/default/example/ex01.exe -> required by %{exe:../example/ex01.exe} at test/dune:4 -> required by _build/default/test/ex01.c.exe -> required by %{exe:ex01.c.exe} at test/dune:6 -> required by _build/default/test/result.output -> required by alias test/runtest in test/dune:8 File "mirage/dune", line 14, characters 15-21: 14 | (run mirage configure -t hvt) ^^^^^^ Error: Program mirage not found in the tree or in PATH (context: default) File "mirage/dune", line 6, characters 15-21: 6 | (run mirage configure -t unix) ^^^^^^ Error: Program mirage not found in the tree or in PATH (context: default) (cd _build/default/lib/freestanding && ./cflags.sh) > _build/default/lib/freestanding/cflags.sexp [WARNING] var was deprecated in version 2.1 of the opam CLI. Use opam var instead or set OPAMCLI environment variable to 2.0. ./cflags.sh: 3: pkg-config: not found (cd _build/default/lib/xen && ./cflags.sh) > _build/default/lib/xen/cflags.sexp [WARNING] var was deprecated in version 2.1 of the opam CLI. Use opam var instead or set OPAMCLI environment variable to 2.0. ./cflags.sh: 3: pkg-config: not found (cd _build/default/lib && /usr/bin/gcc -O2 -fno-strict-aliasing -fwrapv -fPIC -pthread -D_FILE_OFFSET_BITS=64 -O2 -fno-strict-aliasing -fwrapv -fPIC -pthread -g -I /home/opam/.opam/5.3/lib/ocaml -I /home/opam/.opam/5.3/lib/bigstringaf -I /home/opam/.opam/5.3/lib/fmt -o load.o -c load.c) In file included from load.c:1: load.c: In function 'caml_load_vaddr_into_bytes': /home/opam/.opam/5.3/lib/ocaml/caml/mlvalues.h:365:23: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 365 | #define String_val(x) ((const char *) Bp_val(x)) | ^ load.c:9:19: note: in expansion of macro 'String_val' 9 | uint8_t * buf = String_val (v_buf) + Long_val (v_off) ; | ^~~~~~~~~~ (cd _build/default/lib/freestanding && /usr/bin/gcc -O2 -fno-strict-aliasing -fwrapv -fPIC -pthread -D_FILE_OFFSET_BITS=64 -std=c99 -g -I /home/opam/.opam/5.3/lib/ocaml -I /home/opam/.opam/5.3/lib/bigstringaf -I /home/opam/.opam/5.3/lib/fmt -o load.o -c load.c) In file included from lib/load.c:1: lib/load.c: In function 'caml_load_vaddr_into_bytes': /home/opam/.opam/5.3/lib/ocaml/caml/mlvalues.h:365:23: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 365 | #define String_val(x) ((const char *) Bp_val(x)) | ^ lib/load.c:9:19: note: in expansion of macro 'String_val' (cd _build/default/lib/xen && /usr/bin/gcc -O2 -fno-strict-aliasing -fwrapv -fPIC -pthread -D_FILE_OFFSET_BITS=64 -std=c99 -g -I /home/opam/.opam/5.3/lib/ocaml -I /home/opam/.opam/5.3/lib/bigstringaf -I /home/opam/.opam/5.3/lib/fmt -o load.o -c load.c) In file included from lib/load.c:1: lib/load.c: In function 'caml_load_vaddr_into_bytes': /home/opam/.opam/5.3/lib/ocaml/caml/mlvalues.h:365:23: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 365 | #define String_val(x) ((const char *) Bp_val(x)) | ^ lib/load.c:9:19: note: in expansion of macro 'String_val' (cd _build/default && /home/opam/.opam/5.3/bin/ocamlc.opt -w @1..3@5..28@30..39@43@46..47@49..57@61..62-40 -strict-sequence -strict-formats -short-paths -keep-locs -g -bin-annot -bin-annot-occurrences -I bin/.caravan.eobjs/byte -I /home/opam/.opam/5.3/lib/astring -I /home/opam/.opam/5.3/lib/bigarray-compat -I /home/opam/.opam/5.3/lib/bigstringaf -I /home/opam/.opam/5.3/lib/bos -I /home/opam/.opam/5.3/lib/cmdliner -I /home/opam/.opam/5.3/lib/fmt -I /home/opam/.opam/5.3/lib/fmt/cli -I /home/opam/.opam/5.3/lib/fmt/tty -I /home/opam/.opam/5.3/lib/fpath -I /home/opam/.opam/5.3/lib/logs -I /home/opam/.opam/5.3/lib/logs/cli -I /home/opam/.opam/5.3/lib/logs/fmt -I /home/opam/.opam/5.3/lib/mmap -I /home/opam/.opam/5.3/lib/ocaml/unix -I /home/opam/.opam/5.3/lib/rresult -no-alias-deps -opaque -o bin/.caravan.eobjs/byte/caravan.cmo -c -impl bin/caravan.ml) File "bin/caravan.ml", line 965, characters 32-40: 965 | else Bduff.copy ~name:(Fmt.strf "Segment %2d" i) ~src_off:off ~dst_off:off ~len:(Int64.of_int len) `Binary) ^^^^^^^^ Error (alert deprecated): Fmt.strf use Fmt.str instead. File "bin/caravan.ml", line 991, characters 30-38: 991 | Bduff.insert ~name:(Fmt.strf "Section %2d" n) ~off ~len { off= 0L; len; raw= shdr_to_bigstring ~ehdr shdr } ^^^^^^^^ Error (alert deprecated): Fmt.strf use Fmt.str instead. File "bin/caravan.ml", line 992, characters 31-39: 992 | else Bduff.copy ~name:(Fmt.strf "Section %2d" n) ~src_off ~dst_off:off ~len:(Int64.of_int len) `Binary) ^^^^^^^^ Error (alert deprecated): Fmt.strf use Fmt.str instead. File "bin/caravan.ml", line 1126, characters 32-40: 1126 | else Bduff.copy ~name:(Fmt.strf "Segment %2d" i) ~src_off:off ~dst_off:off ~len:(Int64.of_int len) `Binary) ^^^^^^^^ Error (alert deprecated): Fmt.strf use Fmt.str instead. File "bin/caravan.ml", line 1158, characters 45-53: 1158 | let old_hunk = Bduff.insert ~name:(Fmt.strf "Section %2d" on) ~off:Int64.(add off (of_int len)) ~len ^^^^^^^^ Error (alert deprecated): Fmt.strf use Fmt.str instead. File "bin/caravan.ml", line 1166, characters 41-49: 1166 | let hunk = Bduff.insert ~name:(Fmt.strf "Section %2d" on) ~off ~len { off= 0L; len; raw= shdr_to_bigstring ~ehdr shdr } in ^^^^^^^^ Error (alert deprecated): Fmt.strf use Fmt.str instead. File "bin/caravan.ml", line 1169, characters 39-47: 1169 | let hunk = Bduff.copy ~name:(Fmt.strf "Section %2d" on) ~src_off ~dst_off:off ~len:(Int64.of_int len) `Binary in ^^^^^^^^ Error (alert deprecated): Fmt.strf use Fmt.str instead. File "bin/caravan.ml", line 1200, characters 28-31: 1200 | let lenl = min Int64.(max - pos) maxl in ^^^ Error: The value max has type int64 -> int64 -> int64 but an expression was expected of type int64 "/usr/bin/env" "bash" "-c" "opam exec -- dune build @install @check @runtest && rm -rf _build" failed with exit status 1 2025-10-15 10:49.36: Job failed: Failed: Build failed