2025-08-27 20:57.07: New job: test ahrefs/ocannl https://github.com/ahrefs/ocannl.git#refs/heads/master (c8da5c46973490da0fb007cd473470170f97d5d1) (linux-x86_64:(lint-fmt)) Base: ocaml/opam:debian-12-ocaml-4.08@sha256:474656ea1593a299054f8966c700443fa0944c9534de3da94ca6dfab4a44c47a ocamlformat version: version 0.27.0 (from opam) To reproduce locally: git clone --recursive "https://github.com/ahrefs/ocannl.git" -b "master" && cd "ocannl" && git reset --hard c8da5c46 cat > Dockerfile <<'END-OF-DOCKERFILE' FROM ocaml/opam:debian-12-ocaml-4.08@sha256:474656ea1593a299054f8966c700443fa0944c9534de3da94ca6dfab4a44c47a USER 1000:1000 RUN cd ~/opam-repository && (git cat-file -e b8021439f8c57ba6435bc2263f6596671f4f4466 || git fetch origin master) && git reset -q --hard b8021439f8c57ba6435bc2263f6596671f4f4466 && git log --no-decorate -n1 --oneline && opam update -u RUN opam depext -i dune WORKDIR /src RUN opam depext -i ocamlformat=0.27.0 COPY --chown=1000:1000 . /src/ RUN opam exec -- dune build @fmt --ignore-promoted-rules || (echo "dune build @fmt failed"; exit 2) END-OF-DOCKERFILE docker build . END-REPRO-BLOCK 2025-08-27 20:57.07: Using cache hint "ahrefs/ocannl-ocaml/opam:debian-12-ocaml-4.08@sha256:474656ea1593a299054f8966c700443fa0944c9534de3da94ca6dfab4a44c47a-debian-12-4.08_opam-2.4-ocamlformat-b8021439f8c57ba6435bc2263f6596671f4f4466" 2025-08-27 20:57.07: Using OBuilder spec: ((from ocaml/opam:debian-12-ocaml-4.08@sha256:474656ea1593a299054f8966c700443fa0944c9534de3da94ca6dfab4a44c47a) (user (uid 1000) (gid 1000)) (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "cd ~/opam-repository && (git cat-file -e b8021439f8c57ba6435bc2263f6596671f4f4466 || git fetch origin master) && git reset -q --hard b8021439f8c57ba6435bc2263f6596671f4f4466 && git log --no-decorate -n1 --oneline && opam update -u")) (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam depext -i dune")) (workdir /src) (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam depext -i ocamlformat=0.27.0")) (copy (src .) (dst /src/)) (run (shell "opam exec -- dune build @fmt --ignore-promoted-rules || (echo \"dune build @fmt failed\"; exit 2)")) ) 2025-08-27 20:57.07: Waiting for resource in pool OCluster 2025-08-27 20:57.07: Waiting for worker… 2025-08-27 20:57.07: Got resource from pool OCluster Building on toxis.caelum.ci.dev HEAD is now at 43255edb Clarify the meaning of `~label` in `%op`, and a couple more tiny documentation fixes HEAD is now at c8da5c46 Merge pull request #378 from ahrefs/fix-label-parameter-type (from ocaml/opam:debian-12-ocaml-4.08@sha256:474656ea1593a299054f8966c700443fa0944c9534de3da94ca6dfab4a44c47a) 2025-08-27 20:57.08 ---> using "1d0024db739bd078f91b2384c47919652a4b72a425e3e24ce24cfd1f6debdfbc" from cache /: (user (uid 1000) (gid 1000)) /: (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "cd ~/opam-repository && (git cat-file -e b8021439f8c57ba6435bc2263f6596671f4f4466 || git fetch origin master) && git reset -q --hard b8021439f8c57ba6435bc2263f6596671f4f4466 && git log --no-decorate -n1 --oneline && opam update -u")) b8021439f8 Merge pull request #28261 from kit-ty-kate/deploy-fix-25819 <><> Updating package repositories ><><><><><><><><><><><><><><><><><><><><><><> [default] Initialised default (at git+file:///home/opam/opam-repository): [INFO] opam 2.1 and 2.2 include many performance and security improvements over 2.0; please consider upgrading (https://opam.ocaml.org/doc/Install.html) Everything as up-to-date as possible (run with --verbose to show unavailable upgrades). However, you may "opam upgrade" these packages explicitly, which will ask permission to downgrade or uninstall the conflicting packages. Nothing to do. # Run eval $(opam env) to update the current shell environment 2025-08-27 20:57.08 ---> using "76d9d96bb26da3c78200d383fd35f876d80571baf05962331a1fff5f47db0e2e" from cache /: (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam depext -i dune")) # Detecting depexts using vars: arch=x86_64, os=linux, os-distribution=debian, os-family=debian # No extra OS packages requirements found. # All required OS packages found. # Now letting opam install the packages The following actions will be performed: - install dune 3.19.1 <><> Gathering sources ><><><><><><><><><><><><><><><><><><><><><><><><><><><><> [dune.3.19.1] found in cache <><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><> -> installed dune.3.19.1 Done. # Run eval $(opam env) to update the current shell environment 2025-08-27 20:57.08 ---> using "da0888a20a067de19f6183f0b497dcc2d1ea7f7036861cc50f633c662efdce4f" from cache /: (workdir /src) /src: (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam depext -i ocamlformat=0.27.0")) # Detecting depexts using vars: arch=x86_64, os=linux, os-distribution=debian, os-family=debian # No extra OS packages requirements found. # All required OS packages found. # Now letting opam install the packages The following actions will be performed: - install sexplib0 v0.14.0 [required by base] - install menhirLib 20240715 [required by ocamlformat-lib] - install menhirCST 20240715 [required by menhir] - install ocamlbuild 0.16.1 [required by fpath, astring, uuseg] - install cmdliner 1.3.0 [required by ocamlformat] - install menhirSdk 20240715 [required by ocamlformat-lib] - install either 1.0.0 [required by ocamlformat-lib] - install csexp 1.5.2 [required by ocamlformat] - install dune-build-info 3.19.1 [required by ocamlformat-lib] - install camlp-streams 5.0.1 [required by ocamlformat-lib] - install seq base [required by re] - install fix 20250428 [required by ocamlformat-lib] - install ocaml-version 4.0.1 [required by ocamlformat-lib] - install ocamlfind 1.9.8 [required by ocp-indent, astring, fpath, uuseg] - install menhir 20240715 [required by ocamlformat-lib] - install dune-configurator 3.19.1 [required by base] - install re 1.11.0 [required by ocamlformat] - install topkg 1.1.0 [required by fpath, astring, uuseg] - install base-bytes base [required by ocp-indent] - install base v0.14.3 [required by ocamlformat-lib] - install uutf 1.0.4 [required by ocamlformat-lib] - install astring 0.8.5 [required by ocamlformat-lib] - install ocp-indent 1.8.1 [required by ocamlformat-lib] - install stdio v0.14.0 [required by ocamlformat-lib] - install uucp 15.0.0 [required by uuseg] - install fpath 0.7.3 [required by ocamlformat-lib] - install uuseg 15.0.0 [required by ocamlformat-lib] - install ocamlformat-lib 0.27.0 [required by ocamlformat] - install ocamlformat 0.27.0 ===== 29 to install ===== <><> Gathering sources ><><><><><><><><><><><><><><><><><><><><><><><><><><><><> [astring.0.8.5] found in cache [base.v0.14.3] found in cache [camlp-streams.5.0.1] found in cache [cmdliner.1.3.0] found in cache [csexp.1.5.2] found in cache [dune-build-info.3.19.1] found in cache [dune-configurator.3.19.1] found in cache [either.1.0.0] found in cache [fix.20250428] found in cache [fpath.0.7.3] found in cache [menhir.20240715] found in cache [menhirCST.20240715] found in cache [menhirLib.20240715] found in cache [menhirSdk.20240715] found in cache [ocaml-version.4.0.1] found in cache [ocamlbuild.0.16.1] found in cache [ocamlfind.1.9.8] found in cache [ocamlformat.0.27.0] found in cache [ocamlformat-lib.0.27.0] found in cache [ocp-indent.1.8.1] found in cache [re.1.11.0] found in cache [sexplib0.v0.14.0] found in cache [stdio.v0.14.0] found in cache [topkg.1.1.0] found in cache [uucp.15.0.0] found in cache [uuseg.15.0.0] found in cache [uutf.1.0.4] found in cache <><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><> -> installed seq.base -> installed camlp-streams.5.0.1 -> installed csexp.1.5.2 -> installed either.1.0.0 -> installed fix.20250428 -> installed menhirCST.20240715 -> installed cmdliner.1.3.0 -> installed menhirLib.20240715 -> installed menhirSdk.20240715 -> installed ocaml-version.4.0.1 -> installed re.1.11.0 -> installed sexplib0.v0.14.0 -> installed dune-build-info.3.19.1 -> installed dune-configurator.3.19.1 -> installed ocamlfind.1.9.8 -> installed base-bytes.base -> installed ocp-indent.1.8.1 -> installed ocamlbuild.0.16.1 -> installed base.v0.14.3 -> installed topkg.1.1.0 -> installed stdio.v0.14.0 -> installed menhir.20240715 -> installed uutf.1.0.4 -> installed astring.0.8.5 -> installed fpath.0.7.3 -> installed uucp.15.0.0 -> installed uuseg.15.0.0 -> installed ocamlformat-lib.0.27.0 -> installed ocamlformat.0.27.0 Done. <><> ocp-indent.1.8.1 installed successfully ><><><><><><><><><><><><><><><><><> => This package requires additional configuration for use in editors. Install package 'user-setup', or manually: * for Emacs, add these lines to ~/.emacs: (add-to-list 'load-path "/home/opam/.opam/4.08/share/emacs/site-lisp") (require 'ocp-indent) * for Vim, add this line to ~/.vimrc: set rtp^="/home/opam/.opam/4.08/share/ocp-indent/vim" # Run eval $(opam env) to update the current shell environment 2025-08-27 20:57.08 ---> using "86ec8dcb8046a1e5dacfb1841e8c026d30cfead67649bcb6d6a8f9ddd6fb153d" from cache /src: (copy (src .) (dst /src/)) 2025-08-27 20:57.08 ---> using "e6d5b6745d981a8fe94254dec2927a92f6d8e70bd7b95baee37951325caa189c" from cache /src: (run (shell "opam exec -- dune build @fmt --ignore-promoted-rules || (echo \"dune build @fmt failed\"; exit 2)")) File "arrayjit/lib/dune", line 7, characters 30-51: 7 | (libraries base stdio pprint ppx_minidebug.runtime) ^^^^^^^^^^^^^^^^^^^^^ Error: Library "ppx_minidebug.runtime" not found. -> required by library "arrayjit.utils" in _build/default/arrayjit/lib -> required by executable ocannl_read_config in test/operations/config/dune:5 -> required by _build/default/test/operations/config/ocannl_read_config.exe -> required by %{dep:ocannl_read_config.exe} at test/operations/dune:22 -> required by _build/default/test/operations/config/ocannl_backend.txt -> required by %{read:config/ocannl_backend.txt} at test/operations/dune:36 -> required by Computing directory contents of _build/default/test/operations File "lib/nn_blocks.ml", line 1, characters 0-0: diff --git a/_build/default/lib/nn_blocks.ml b/_build/default/lib/.formatted/nn_blocks.ml index 3c83abf..c7e1853 100644 --- a/_build/default/lib/nn_blocks.ml +++ b/_build/default/lib/.formatted/nn_blocks.ml @@ -9,7 +9,6 @@ let%op mlp_layer ~label ~hid_dim () x = relu (({ w = uniform () } * x) + { b = 0 let mlp ~hid_dims = let layers = - List.mapi hid_dims ~f:(fun i hid_dim -> - mlp_layer ~label:[ "L" ^ Int.to_string i ] ~hid_dim ()) + List.mapi hid_dims ~f:(fun i hid_dim -> mlp_layer ~label:[ "L" ^ Int.to_string i ] ~hid_dim ()) in fun x -> List.fold layers ~init:x ~f:(fun x layer -> layer x) File "test/ppx/test_ppx_op.ml", line 1, characters 0-0: diff --git a/_build/default/test/ppx/test_ppx_op.ml b/_build/default/test/ppx/.formatted/test_ppx_op.ml index cba1aa1..28a2027 100644 --- a/_build/default/test/ppx/test_ppx_op.ml +++ b/_build/default/test/ppx/.formatted/test_ppx_op.ml @@ -20,18 +20,14 @@ let z3 = [%op { hey9 } *+ "is*a+d*bc;b=>iac" { hey10 }] let () = ignore (y0, y1, y2, a, b, y, z, z2, z3) - let%op mlp_layer ~label ~hid_dim () x = relu (({ w } * x) + { b; o = [ hid_dim ] }) let%op _use_layer x = - mlp_layer ~label:[ "L" ] ~hid_dim:3 () - (mlp_layer ~label:[ "L2" ] ~hid_dim:3 () x) + mlp_layer ~label:[ "L" ] ~hid_dim:3 () (mlp_layer ~label:[ "L2" ] ~hid_dim:3 () x) let%op _config_layer ~config:_ x = mlp_layer ~label:[ "L" ] ~hid_dim:3 () x let%op _three_layer_perceptron ~label ~dim1 ~dim2 ~dim3 () x = - mlp_layer - ~label:(label @ [ "L3" ]) ~hid_dim:dim3 () - (mlp_layer - ~label:(label @ [ "L2" ]) ~hid_dim:dim2 () + mlp_layer ~label:(label @ [ "L3" ]) ~hid_dim:dim3 () + (mlp_layer ~label:(label @ [ "L2" ]) ~hid_dim:dim2 () (mlp_layer ~label:(label @ [ "L1" ]) ~hid_dim:dim1 () x)) File "lib/ppx_op.ml", line 1, characters 0-0: diff --git a/_build/default/lib/ppx_op.ml b/_build/default/lib/.formatted/ppx_op.ml index 561a7dc..df4f761 100644 --- a/_build/default/lib/ppx_op.ml +++ b/_build/default/lib/.formatted/ppx_op.ml @@ -4,9 +4,11 @@ open Ppx_arrayjit.Ppx_helper open Ppx_shared let make_p ~opt_label ~loc ?value ?values ?param_init ~extra_args name = - let more_label = match opt_label with + let more_label = + match opt_label with | Some (_label_name, label_pat) -> [%expr Some [%e pat2expr label_pat]] - | None -> [%expr None] in + | None -> [%expr None] + in let value = match value with Some c -> [%expr Some [%e c]] | None -> [%expr None] in let values = match values with Some c -> [%expr Some [%e c]] | None -> [%expr None] in let param_init = @@ -264,7 +266,7 @@ let rec translate ~num_configs ~is_toplevel ~opt_label ?label expr = (* Check if there's a unit parameter or a labeled parameter with label "label" *) let rec find_unit_pos idx = function | [] -> None - | { pparam_desc = Pparam_val (Nolabel, _, pat); _ } :: _ + | { pparam_desc = Pparam_val (Nolabel, _, pat); _ } :: _ when match pat.ppat_desc with | Ppat_construct ({ txt = Lident "()"; _ }, None) -> true | _ -> false -> @@ -280,9 +282,11 @@ let rec translate ~num_configs ~is_toplevel ~opt_label ?label expr = | Some unit_idx -> (* Split args at unit parameter *) let before_unit, unit_and_after = List.split_n args unit_idx in - let unit_param, after_unit = match unit_and_after with + let unit_param, after_unit = + match unit_and_after with | unit :: rest -> (unit, rest) - | [] -> failwith "Internal error: unit_and_after should not be empty" in + | [] -> failwith "Internal error: unit_and_after should not be empty" + in let opt_label = find_label_param before_unit in let vbs, inner_body = translate ~num_configs ~is_toplevel:false ~opt_label ?label @@ -293,54 +297,61 @@ let rec translate ~num_configs ~is_toplevel ~opt_label ?label expr = let new_body = inner_body in ( no_vbs, if List.is_empty before_unit then - { expr with pexp_desc = Pexp_function ([unit_param], constr, Pfunction_body new_body) } + { + expr with + pexp_desc = Pexp_function ([ unit_param ], constr, Pfunction_body new_body); + } else - { expr with pexp_desc = Pexp_function (before_unit @ [unit_param], constr, Pfunction_body new_body) } ) + { + expr with + pexp_desc = + Pexp_function (before_unit @ [ unit_param ], constr, Pfunction_body new_body); + } ) | None -> - (* No unit parameter, normal processing *) - let labels = - Option.to_list label - @ List.filter_map args ~f:(function - | { pparam_desc = Pparam_val (_, _, pat); _ } -> - let loc = pat.ppat_loc in - Some [%expr [%e pat2expr pat].Tensor.value.Ir.Tnode.label] - | _ -> None) - in - let label_locs = List.map labels ~f:(fun label -> label.pexp_loc) in - let label_starts = List.map label_locs ~f:(fun l -> l.loc_start) in - let label_ends = List.map label_locs ~f:(fun l -> l.loc_end) in - let label_loc = - if List.is_empty labels then loc - else - Location. - { - loc_start = List.reduce_exn label_starts ~f:min_pos; - loc_end = List.reduce_exn label_ends ~f:max_pos; - loc_ghost = false; - } - in - let label = - let loc = label_loc in - [%expr List.concat [%e Ast_builder.Default.elist ~loc labels]] - in - let vbs, body = - match body with - | Pfunction_body body -> - let vbs, body = loop ~label body in - (vbs, Pfunction_body body) - | Pfunction_cases (cases, loc, attrs) -> - let vbs, cases = - List.unzip - @@ List.map cases ~f:(fun ({ pc_rhs; _ } as c) -> - let vbs, pc_rhs = loop ~label pc_rhs in - (vbs, { c with pc_rhs })) - in - ( List.fold vbs - ~init:(Map.empty (module String)) - ~f:(fun acc vbs -> Map.merge_disjoint_exn acc vbs), - Pfunction_cases (cases, loc, attrs) ) - in - (vbs, { expr with pexp_desc = Pexp_function (args, constr, body) }) ) + (* No unit parameter, normal processing *) + let labels = + Option.to_list label + @ List.filter_map args ~f:(function + | { pparam_desc = Pparam_val (_, _, pat); _ } -> + let loc = pat.ppat_loc in + Some [%expr [%e pat2expr pat].Tensor.value.Ir.Tnode.label] + | _ -> None) + in + let label_locs = List.map labels ~f:(fun label -> label.pexp_loc) in + let label_starts = List.map label_locs ~f:(fun l -> l.loc_start) in + let label_ends = List.map label_locs ~f:(fun l -> l.loc_end) in + let label_loc = + if List.is_empty labels then loc + else + Location. + { + loc_start = List.reduce_exn label_starts ~f:min_pos; + loc_end = List.reduce_exn label_ends ~f:max_pos; + loc_ghost = false; + } + in + let label = + let loc = label_loc in + [%expr List.concat [%e Ast_builder.Default.elist ~loc labels]] + in + let vbs, body = + match body with + | Pfunction_body body -> + let vbs, body = loop ~label body in + (vbs, Pfunction_body body) + | Pfunction_cases (cases, loc, attrs) -> + let vbs, cases = + List.unzip + @@ List.map cases ~f:(fun ({ pc_rhs; _ } as c) -> + let vbs, pc_rhs = loop ~label pc_rhs in + (vbs, { c with pc_rhs })) + in + ( List.fold vbs + ~init:(Map.empty (module String)) + ~f:(fun acc vbs -> Map.merge_disjoint_exn acc vbs), + Pfunction_cases (cases, loc, attrs) ) + in + (vbs, { expr with pexp_desc = Pexp_function (args, constr, body) })) | { pexp_desc = Pexp_function (args, constr, body); _ } -> let vbs, body = match body with dune build @fmt failed "/usr/bin/env" "bash" "-c" "opam exec -- dune build @fmt --ignore-promoted-rules || (echo "dune build @fmt failed"; exit 2)" failed with exit status 2 2025-08-27 20:57.09: Job failed: Failed: Build failed