(lint-fmt)

2025-12-05 14:58.29: New job: test ahrefs/ocannl https://github.com/ahrefs/ocannl.git#refs/heads/master (bc4ce1f85f3fe1b6734f4477b575e730741ea2ba) (linux-x86_64:(lint-fmt))
Base: ocaml/opam:debian-13-ocaml-4.08@sha256:e3cc4e8fe5c00f48c72a719e3551b1d8a51c2862349a0f7507e8aa29fdf72321
ocamlformat version: version 0.28.1 (from opam)


To reproduce locally:


git clone --recursive "https://github.com/ahrefs/ocannl.git" -b "master" && cd "ocannl" && git reset --hard bc4ce1f8
cat > Dockerfile <<'END-OF-DOCKERFILE'
FROM ocaml/opam:debian-13-ocaml-4.08@sha256:e3cc4e8fe5c00f48c72a719e3551b1d8a51c2862349a0f7507e8aa29fdf72321
USER 1000:1000
RUN cd ~/opam-repository && (git cat-file -e 6c1b38620288b5bf349067f089a7b1fc91185d94 || git fetch origin master) && git reset -q --hard 6c1b38620288b5bf349067f089a7b1fc91185d94 && git log --no-decorate -n1 --oneline && opam update -u
RUN opam depext -i dune
WORKDIR /src
RUN opam depext -i ocamlformat=0.28.1
COPY --chown=1000:1000 . /src/
RUN opam exec -- dune build @fmt --ignore-promoted-rules || (echo "dune build @fmt failed"; exit 2)


END-OF-DOCKERFILE
docker build .
END-REPRO-BLOCK


2025-12-05 14:58.29: Using cache hint "ahrefs/ocannl-ocaml/opam:debian-13-ocaml-4.08@sha256:e3cc4e8fe5c00f48c72a719e3551b1d8a51c2862349a0f7507e8aa29fdf72321-debian-13-4.08_opam-2.4-ocamlformat-6c1b38620288b5bf349067f089a7b1fc91185d94"
2025-12-05 14:58.29: Using OBuilder spec:
((from ocaml/opam:debian-13-ocaml-4.08@sha256:e3cc4e8fe5c00f48c72a719e3551b1d8a51c2862349a0f7507e8aa29fdf72321)
(user (uid 1000) (gid 1000))
(run (cache (opam-archives (target /home/opam/.opam/download-cache)))
(network host)
(shell "cd ~/opam-repository && (git cat-file -e 6c1b38620288b5bf349067f089a7b1fc91185d94 || git fetch origin master) && git reset -q --hard 6c1b38620288b5bf349067f089a7b1fc91185d94 && git log --no-decorate -n1 --oneline && opam update -u"))
(run (cache (opam-archives (target /home/opam/.opam/download-cache)))
(network host)
(shell "opam depext -i dune"))
(workdir /src)
(run (cache (opam-archives (target /home/opam/.opam/download-cache)))
(network host)
(shell "opam depext -i ocamlformat=0.28.1"))
(copy (src .) (dst /src/))
(run (shell "opam exec -- dune build @fmt --ignore-promoted-rules || (echo \"dune build @fmt failed\"; exit 2)"))
)


2025-12-05 14:58.29: Waiting for resource in pool OCluster
2025-12-05 14:58.30: Waiting for worker…
2025-12-05 14:58.30: Got resource from pool OCluster
Building on bremusa.ocamllabs.io
All commits already cached
HEAD is now at bc4ce1f8 Fix max_pool2d and avg_pool2d to use 0 as kernel constant


(from ocaml/opam:debian-13-ocaml-4.08@sha256:e3cc4e8fe5c00f48c72a719e3551b1d8a51c2862349a0f7507e8aa29fdf72321)
2025-12-05 14:58.31 ---> using "d458486dd7823c592e7ea9c88366c5f90e1939c3b51f3abbd6760272096f8a3e" from cache


/: (user (uid 1000) (gid 1000))


/: (run (cache (opam-archives (target /home/opam/.opam/download-cache)))
(network host)
(shell "cd ~/opam-repository && (git cat-file -e 6c1b38620288b5bf349067f089a7b1fc91185d94 || git fetch origin master) && git reset -q --hard 6c1b38620288b5bf349067f089a7b1fc91185d94 && git log --no-decorate -n1 --oneline && opam update -u"))
6c1b386202 Merge pull request #28774 from Julow/release-ocamlformat-0.28.1


<><> Updating package repositories ><><><><><><><><><><><><><><><><><><><><><><>
[default] Initialised
default (at git+file:///home/opam/opam-repository):
[INFO] opam 2.1 and 2.2 include many performance and security improvements over 2.0; please consider upgrading (https://opam.ocaml.org/doc/Install.html)


Everything as up-to-date as possible (run with --verbose to show unavailable upgrades).
However, you may "opam upgrade" these packages explicitly, which will ask permission to downgrade or uninstall the conflicting packages.
Nothing to do.
# Run eval $(opam env) to update the current shell environment
2025-12-05 14:58.31 ---> using "a7d3c7d9f6aff7dc059c465a33e7ef3fda4b4a1ee9c79bef8645b5cd4da72b96" from cache


/: (run (cache (opam-archives (target /home/opam/.opam/download-cache)))
(network host)
(shell "opam depext -i dune"))
# Detecting depexts using vars: arch=x86_64, os=linux, os-distribution=debian, os-family=debian
# No extra OS packages requirements found.
# All required OS packages found.
# Now letting opam install the packages
The following actions will be performed:
- install dune 3.20.2


<><> Gathering sources ><><><><><><><><><><><><><><><><><><><><><><><><><><><><>
[dune.3.20.2] found in cache


<><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><>
-> installed dune.3.20.2
Done.
# Run eval $(opam env) to update the current shell environment
2025-12-05 14:58.31 ---> using "b8799a0f87a66bd49a9341889a0027044c03db80ad17a5edb3adaf72f166d8fd" from cache


/: (workdir /src)


/src: (run (cache (opam-archives (target /home/opam/.opam/download-cache)))
(network host)
(shell "opam depext -i ocamlformat=0.28.1"))
# Detecting depexts using vars: arch=x86_64, os=linux, os-distribution=debian, os-family=debian
# No extra OS packages requirements found.
# All required OS packages found.
# Now letting opam install the packages
The following actions will be performed:
- install sexplib0          v0.14.0  [required by base]
- install ocamlbuild        0.16.1   [required by fpath, astring, uuseg]
- install either            1.0.0    [required by ocamlformat-lib]
- install menhirLib         20250912 [required by ocamlformat-lib]
- install csexp             1.5.2    [required by ocamlformat]
- install camlp-streams     5.0.1    [required by ocamlformat-lib]
- install seq               base     [required by re]
- install menhirSdk         20250912 [required by ocamlformat-lib]
- install fix               20250919 [required by ocamlformat-lib]
- install menhirCST         20250912 [required by menhir]
- install ocamlfind         1.9.8    [required by ocp-indent, astring, fpath, uuseg]
- install dune-build-info   3.20.2   [required by ocamlformat-lib]
- install cmdliner          2.0.0    [required by ocamlformat]
- install ocaml-version     4.0.3    [required by ocamlformat-lib]
- install dune-configurator 3.20.2   [required by base]
- install re                1.11.0   [required by ocamlformat]
- install menhir            20250912 [required by ocamlformat-lib]
- install topkg             1.1.1    [required by fpath, astring, uuseg]
- install ocp-indent        1.9.0    [required by ocamlformat-lib]
- install base              v0.14.3  [required by ocamlformat-lib]
- install uutf              1.0.4    [required by ocamlformat-lib]
- install astring           0.8.5    [required by ocamlformat-lib]
- install stdio             v0.14.0  [required by ocamlformat-lib]
- install uucp              15.0.0   [required by uuseg]
- install fpath             0.7.3    [required by ocamlformat-lib]
- install uuseg             15.0.0   [required by ocamlformat-lib]
- install ocamlformat-lib   0.28.1   [required by ocamlformat]
- install ocamlformat       0.28.1
===== 28 to install =====


<><> Gathering sources ><><><><><><><><><><><><><><><><><><><><><><><><><><><><>
[astring.0.8.5] found in cache
[base.v0.14.3] found in cache
[camlp-streams.5.0.1] found in cache
[cmdliner.2.0.0] found in cache
[csexp.1.5.2] found in cache
[dune-build-info.3.20.2] found in cache
[dune-configurator.3.20.2] found in cache
[either.1.0.0] found in cache
[fix.20250919] found in cache
[fpath.0.7.3] found in cache
[menhir.20250912] found in cache
[menhirCST.20250912] found in cache
[menhirLib.20250912] found in cache
[menhirSdk.20250912] found in cache
[ocaml-version.4.0.3] found in cache
[ocamlbuild.0.16.1] found in cache
[ocamlfind.1.9.8] found in cache
[ocamlformat.0.28.1] found in cache
[ocamlformat-lib.0.28.1] found in cache
[ocp-indent.1.9.0] found in cache
[re.1.11.0] found in cache
[sexplib0.v0.14.0] found in cache
[stdio.v0.14.0] found in cache
[topkg.1.1.1] found in cache
[uucp.15.0.0] found in cache
[uuseg.15.0.0] found in cache
[uutf.1.0.4] found in cache


<><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><>
-> installed seq.base
-> installed camlp-streams.5.0.1
-> installed csexp.1.5.2
-> installed either.1.0.0
-> installed fix.20250919
-> installed menhirCST.20250912
-> installed cmdliner.2.0.0
-> installed menhirLib.20250912
-> installed menhirSdk.20250912
-> installed ocaml-version.4.0.3
-> installed re.1.11.0
-> installed sexplib0.v0.14.0
-> installed dune-build-info.3.20.2
-> installed dune-configurator.3.20.2
-> installed ocamlfind.1.9.8
-> installed ocp-indent.1.9.0
-> installed ocamlbuild.0.16.1
-> installed base.v0.14.3
-> installed topkg.1.1.1
-> installed stdio.v0.14.0
-> installed uutf.1.0.4
-> installed astring.0.8.5
-> installed fpath.0.7.3
-> installed menhir.20250912
-> installed uucp.15.0.0
-> installed uuseg.15.0.0
-> installed ocamlformat-lib.0.28.1
-> installed ocamlformat.0.28.1
Done.


<><> ocp-indent.1.9.0 installed successfully ><><><><><><><><><><><><><><><><><>
=> This package requires additional configuration for use in editors. Install package 'user-setup', or manually:


* for Emacs, add these lines to ~/.emacs:
(add-to-list 'load-path "/home/opam/.opam/4.08/share/emacs/site-lisp")
(require 'ocp-indent)


* for Vim, add this line to ~/.vimrc:
set rtp^="/home/opam/.opam/4.08/share/ocp-indent/vim"
# Run eval $(opam env) to update the current shell environment
2025-12-05 14:58.31 ---> using "7b71439e6ac9917292b28dc59ecc075d01d03dd2ef11c372809a6cf99e594a22" from cache


/src: (copy (src .) (dst /src/))
2025-12-05 14:58.31 ---> saved as "2c1ea5939c0c15115cec7410a6a88d7db1317e841d548daeb71cfb800d845711"


/src: (run (shell "opam exec -- dune build @fmt --ignore-promoted-rules || (echo \"dune build @fmt failed\"; exit 2)"))
Warning: Invalid documentation comment:
File "tensor/einsum_types.ml", line 38, characters 0-0:
End of text is not allowed in '[...]' (code).
File "tensor/einsum_types.ml", line 1, characters 0-0:
diff --git a/_build/default/tensor/einsum_types.ml b/_build/default/tensor/.formatted/einsum_types.ml
index 084d9ac..e357e66 100644
--- a/_build/default/tensor/einsum_types.ml
+++ b/_build/default/tensor/.formatted/einsum_types.ml
@@ -4,18 +4,16 @@


open Base


-(** Use_padding specification for convolutions. *)
type use_padding_spec = [ `True | `False | `Unspecified ] [@@deriving compare, sexp]
+(** Use_padding specification for convolutions. *)


-(** Convolution component for affine axis specifications.
-    Note: [dilation] is a string because it can be an identifier at parse time,
-    and is resolved to an int at runtime. *)
type conv_spec = { dilation : string; kernel_label : string; use_padding : use_padding_spec }
[@@deriving compare, sexp]
+(** Convolution component for affine axis specifications. Note: [dilation] is a string because it
+    can be an identifier at parse time, and is resolved to an int at runtime. *)


-(** Specification for individual axes in the einsum notation.
-    Note: [stride] is a string because it can be an identifier at parse time,
-    and is resolved to an int at runtime. *)
+(** Specification for individual axes in the einsum notation. Note: [stride] is a string because it
+    can be an identifier at parse time, and is resolved to an int at runtime. *)
type axis_spec =
| Label of string  (** A variable axis label. *)
| Fixed_index of int  (** A fixed index, used for projection. *)
@@ -25,8 +23,8 @@ type axis_spec =
conv : conv_spec option;  (** Optional convolution: dilation*kernel. *)
stride_offset : int;  (** Constant offset added after stride*over. *)
}
-      (** Affine axis specification: stride*over + stride_offset [+ dilation*kernel].
-          Corresponds to [Row.Affine] in shape inference. *)
+      (** Affine axis specification: stride*over + stride_offset [+ dilation*kernel]. Corresponds to
+          [Row.Affine] in shape inference. *)
[@@deriving compare, sexp]


(** An index pointing to any of a shape's axes, including the kind of the axis ([Batch, Input,
@@ -75,8 +73,8 @@ type parsed_axis_labels = {
(** The labels are strings assigned to [AxisKey] axes. Moreover the [bcast_] fields represent
whether additional leading/middle axes are allowed (corresponding to the dot-ellipsis syntax for
broadcasting). The string can be used to identify a row variable, and defaults to ["batch"],
-    ["input"], ["output"] respectively when parsing ["..."]. The [given_] fields are lists of
-    axis specs of the corresponding kind in [labels] where [from_end=true], [given_beg_] where
+    ["input"], ["output"] respectively when parsing ["..."]. The [given_] fields are lists of axis
+    specs of the corresponding kind in [labels] where [from_end=true], [given_beg_] where
[from_end=false]. *)


let axis_labels parsed = parsed.labels
File "datasets/rand.ml", line 1, characters 0-0:
diff --git a/_build/default/datasets/rand.ml b/_build/default/datasets/.formatted/rand.ml
index 22f8f7f..84ab9a6 100644
--- a/_build/default/datasets/rand.ml
+++ b/_build/default/datasets/.formatted/rand.ml
@@ -24,6 +24,7 @@ module Random_for_tests : Random = struct
(raw /. 10000. *. (high -. low)) +. low


let char () = Char.chr @@ Int32.(to_int @@ rem (rand_int32 ()) 256l)
+
let int high =
(* Use abs to handle negative random values from xor-shift RNG *)
Int32.(to_int @@ rem (abs (rand_int32 ())) @@ of_int high)
File "datasets/circles.ml", line 1, characters 0-0:
diff --git a/_build/default/datasets/circles.ml b/_build/default/datasets/.formatted/circles.ml
index 1c640a3..4fae3df 100644
--- a/_build/default/datasets/circles.ml
+++ b/_build/default/datasets/.formatted/circles.ml
@@ -11,21 +11,19 @@ module Config = struct
seed : int option;  (** Optional random seed for reproducibility *)
}


-  let default =
-    { image_size = 32; max_radius = 8; min_radius = 2; max_circles = 5; seed = None }
+  let default = { image_size = 32; max_radius = 8; min_radius = 2; max_circles = 5; seed = None }
end


module Random = Rand.Random_for_tests


-(** Draw a filled circle on the image at (cx, cy) with radius r.
-    Values are clamped to [0, 1] range. *)
+(** Draw a filled circle on the image at (cx, cy) with radius r. Values are clamped to [0, 1] range.
+*)
let draw_circle ~image_size image cx cy r =
for y = 0 to image_size - 1 do
for x = 0 to image_size - 1 do
let dx = x - cx in
let dy = y - cy in
-      if (dx * dx) + (dy * dy) <= r * r then
-        Genarray.set image [| y; x; 0 |] 1.0
+      if (dx * dx) + (dy * dy) <= r * r then Genarray.set image [| y; x; 0 |] 1.0
done
done


@@ -36,7 +34,8 @@ let draw_circle ~image_size image cx cy r =
@param len Number of images to generate
@return
A tuple of (images, labels) where:
-      - images is a bigarray of shape [len; image_size; image_size; 1] (batch, height, width, channels)
+      - images is a bigarray of shape [len; image_size; image_size; 1] (batch, height, width,
+        channels)
- labels is a bigarray of shape [len; 1] (batch, output) containing the circle count *)
let generate_with_kind kind ?(config = Config.default) ~len () =
(match config.seed with Some seed -> Random.init seed | None -> ());
File "tensor/shape.mli", line 1, characters 0-0:
diff --git a/_build/default/tensor/shape.mli b/_build/default/tensor/.formatted/shape.mli
index 5226630..55a8977 100644
--- a/_build/default/tensor/shape.mli
+++ b/_build/default/tensor/.formatted/shape.mli
@@ -239,5 +239,5 @@ val to_labels : t -> string array
(** Uses the matrix convention of putting the input axes last. *)


val parse_n5_layout : string -> int array
-(** Parse a N5_layout priority string (e.g., "0,1,2") into display indices.
-    Only supports integer labels (Fixed_index). *)
+(** Parse a N5_layout priority string (e.g., "0,1,2") into display indices. Only supports integer
+    labels (Fixed_index). *)
File "test/einsum/test_conv_padding.ml", line 1, characters 0-0:
diff --git a/_build/default/test/einsum/test_conv_padding.ml b/_build/default/test/einsum/.formatted/test_conv_padding.ml
index da313d4..5cade6f 100644
--- a/_build/default/test/einsum/test_conv_padding.ml
+++ b/_build/default/test/einsum/.formatted/test_conv_padding.ml
@@ -7,8 +7,8 @@ let conv2d = Nn_blocks.conv2d


(** Test that conv2d with use_padding=true preserves spatial dimensions.


-    With use_padding=true, the output spatial dimensions should match input/stride.
-    For stride=1 and any kernel_size, output should have the same spatial dims as input. *)
+    With use_padding=true, the output spatial dimensions should match input/stride. For stride=1 and
+    any kernel_size, output should have the same spatial dims as input. *)
let test_conv2d_padding_preserves_dims () =
printf "Testing conv2d with use_padding=true preserves dimensions...\n%!";
Tensor.unsafe_reinitialize ();
@@ -17,7 +17,9 @@ let test_conv2d_padding_preserves_dims () =
let input = TDSL.range_of_shape ~output_dims:[ 5; 5; 1 ] () in


(* Apply conv2d with kernel_size=3, stride=1, use_padding=true *)
-  let%op output = conv2d ~label:["test_conv"] ~kernel_size:3 ~stride:1 ~use_padding:true () input in
+  let%op output =
+    conv2d ~label:[ "test_conv" ] ~kernel_size:3 ~stride:1 ~use_padding:true () input
+  in


let ctx = Context.auto () in
Train.set_hosted output.value;
@@ -43,7 +45,9 @@ let test_conv2d_no_padding_reduces_dims () =
let input = TDSL.range_of_shape ~output_dims:[ 5; 5; 1 ] () in


(* Apply conv2d with kernel_size=3, stride=1, use_padding=false *)
-  let%op output = conv2d ~label:["test_conv"] ~kernel_size:3 ~stride:1 ~use_padding:false () input in
+  let%op output =
+    conv2d ~label:[ "test_conv" ] ~kernel_size:3 ~stride:1 ~use_padding:false () input
+  in


let ctx = Context.auto () in
Train.set_hosted output.value;
@@ -59,8 +63,8 @@ let test_conv2d_no_padding_reduces_dims () =


(** Test conv2d with stride=2 and use_padding=true.


-    With stride=2 and use_padding=true, output dims should be ceil(input/stride).
-    For 6x6 input, stride=2: output should be 3x3. *)
+    With stride=2 and use_padding=true, output dims should be ceil(input/stride). For 6x6 input,
+    stride=2: output should be 3x3. *)
let test_conv2d_stride_with_padding () =
printf "Testing conv2d with stride=2 and use_padding=true...\n%!";
Tensor.unsafe_reinitialize ();
@@ -69,7 +73,9 @@ let test_conv2d_stride_with_padding () =
let input = TDSL.range_of_shape ~output_dims:[ 6; 6; 1 ] () in


(* Apply conv2d with kernel_size=3, stride=2, use_padding=true *)
-  let%op output = conv2d ~label:["test_conv"] ~kernel_size:3 ~stride:2 ~use_padding:true () input in
+  let%op output =
+    conv2d ~label:[ "test_conv" ] ~kernel_size:3 ~stride:2 ~use_padding:true () input
+  in


let ctx = Context.auto () in
Train.set_hosted output.value;
@@ -95,7 +101,9 @@ let test_conv2d_stride_without_padding () =
let input = TDSL.range_of_shape ~output_dims:[ 6; 6; 1 ] () in


(* Apply conv2d with kernel_size=3, stride=2, use_padding=false *)
-  let%op output = conv2d ~label:["test_conv"] ~kernel_size:3 ~stride:2 ~use_padding:false () input in
+  let%op output =
+    conv2d ~label:[ "test_conv" ] ~kernel_size:3 ~stride:2 ~use_padding:false () input
+  in


let ctx = Context.auto () in
Train.set_hosted output.value;
File "test/einsum/test_conv_syntax.ml", line 1, characters 0-0:
diff --git a/_build/default/test/einsum/test_conv_syntax.ml b/_build/default/test/einsum/.formatted/test_conv_syntax.ml
index bb97681..028dbb4 100644
--- a/_build/default/test/einsum/test_conv_syntax.ml
+++ b/_build/default/test/einsum/.formatted/test_conv_syntax.ml
@@ -8,43 +8,50 @@ let test_conv_parsing () =
let spec1 = "2*o+3*k" in
let labels1 = Einsum_parser.axis_labels_of_spec spec1 in
printf "Test 1: Parsed '%s' successfully\n%!" spec1;
-  printf "  Structure: %s\n\n%!" (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels1));
+  printf "  Structure: %s\n\n%!"
+    (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels1));


(* Test 2: Simple conv expression without coefficients (multichar - requires commas) *)
let spec2 = "o+k" in
let labels2 = Einsum_parser.axis_labels_of_spec spec2 in
printf "Test 2: Parsed '%s' successfully\n%!" spec2;
-  printf "  Structure: %s\n\n%!" (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels2));
+  printf "  Structure: %s\n\n%!"
+    (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels2));


(* Test 3: Mixed spec with comma (multichar mode) *)
let spec3 = "a, 2*b+c" in
let labels3 = Einsum_parser.axis_labels_of_spec spec3 in
printf "Test 3: Parsed '%s' successfully\n%!" spec3;
-  printf "  Structure: %s\n\n%!" (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels3));
+  printf "  Structure: %s\n\n%!"
+    (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels3));


(* Test 4: Conv expression with multiple identifiers (multichar - requires commas) *)
let spec4 = "i, o+k, j" in
let labels4 = Einsum_parser.axis_labels_of_spec spec4 in
printf "Test 4: Parsed '%s' successfully (multichar mode)\n%!" spec4;
-  printf "  Structure: %s\n\n%!" (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels4));
+  printf "  Structure: %s\n\n%!"
+    (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels4));


(* Test 5: Conv expression with multi-char identifiers (multichar) *)
let spec5 = "a+bc" in
let labels5 = Einsum_parser.axis_labels_of_spec spec5 in
printf "Test 5: Parsed '%s' successfully (multichar mode)\n%!" spec5;
-  printf "  Structure: %s\n\n%!" (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels5));
+  printf "  Structure: %s\n\n%!"
+    (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels5));


(* Test 6: Test in einsum notation with multichar conv *)
let spec6 = "i, j -> 2*i+j" in
let labels6 = Einsum_parser.axis_labels_of_spec spec6 in
printf "Test 6: Parsed '%s' successfully\n%!" spec6;
-  printf "  Structure: %s\n\n%!" (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels6));
+  printf "  Structure: %s\n\n%!"
+    (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels6));


(* Test 7: Complex batch-input-output spec with conv *)
let spec7 = "batch|input->3*output+1*kernel," in
let labels7 = Einsum_parser.axis_labels_of_spec spec7 in
printf "Test 7: Parsed '%s' successfully\n%!" spec7;
-  printf "  Structure: %s\n\n%!" (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels7));
+  printf "  Structure: %s\n\n%!"
+    (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels7));


printf "All conv syntax parsing tests passed!\n%!"


@@ -55,25 +62,29 @@ let test_strided_iteration_parsing () =
let spec1 = "2*output" in
let labels1 = Einsum_parser.axis_labels_of_spec spec1 in
printf "Test 1: Parsed strided iteration '%s' successfully\n%!" spec1;
-  printf "  Structure: %s\n\n%!" (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels1));
+  printf "  Structure: %s\n\n%!"
+    (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels1));


(* Test 2: Strided iteration with single-char identifier (multichar mode) *)
let spec2 = "3*i" in
let labels2 = Einsum_parser.axis_labels_of_spec spec2 in
printf "Test 2: Parsed strided iteration '%s' successfully\n%!" spec2;
-  printf "  Structure: %s\n\n%!" (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels2));
+  printf "  Structure: %s\n\n%!"
+    (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels2));


(* Test 3: Strided iteration in einsum context (multichar due to multiplication) *)
let spec3 = "input -> 2*output" in
let labels3 = Einsum_parser.axis_labels_of_spec spec3 in
printf "Test 3: Parsed einsum with strided iteration '%s' successfully\n%!" spec3;
-  printf "  Structure: %s\n\n%!" (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels3));
+  printf "  Structure: %s\n\n%!"
+    (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels3));


(* Test 4: Mixed regular labels and strided iteration (multichar due to comma) *)
let spec4 = "regular, 3*strided" in
let labels4 = Einsum_parser.axis_labels_of_spec spec4 in
printf "Test 4: Parsed mixed labels with strided iteration '%s' successfully\n%!" spec4;
-  printf "  Structure: %s\n\n%!" (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels4));
+  printf "  Structure: %s\n\n%!"
+    (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels4));


printf "\nAll strided iteration parsing tests completed!\n%!"


@@ -138,37 +149,43 @@ let test_use_padding_syntax () =
let spec1 = "o=+k" in
let labels1 = Einsum_parser.axis_labels_of_spec spec1 in
printf "Test 1: Parsed '%s' (use_padding=true)\n%!" spec1;
-  printf "  Structure: %s\n\n%!" (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels1));
+  printf "  Structure: %s\n\n%!"
+    (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels1));


(* Test 2: use_padding=false with < syntax *)
let spec2 = "o<+k" in
let labels2 = Einsum_parser.axis_labels_of_spec spec2 in
printf "Test 2: Parsed '%s' (use_padding=false)\n%!" spec2;
-  printf "  Structure: %s\n\n%!" (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels2));
+  printf "  Structure: %s\n\n%!"
+    (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels2));


(* Test 3: use_padding with stride *)
let spec3 = "2*o=+k" in
let labels3 = Einsum_parser.axis_labels_of_spec spec3 in
printf "Test 3: Parsed '%s' (stride with use_padding=true)\n%!" spec3;
-  printf "  Structure: %s\n\n%!" (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels3));
+  printf "  Structure: %s\n\n%!"
+    (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels3));


(* Test 4: use_padding with dilation *)
let spec4 = "o<+3*k" in
let labels4 = Einsum_parser.axis_labels_of_spec spec4 in
printf "Test 4: Parsed '%s' (dilation with use_padding=false)\n%!" spec4;
-  printf "  Structure: %s\n\n%!" (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels4));
+  printf "  Structure: %s\n\n%!"
+    (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels4));


(* Test 5: use_padding with stride and dilation *)
let spec5 = "2*o=+3*k" in
let labels5 = Einsum_parser.axis_labels_of_spec spec5 in
printf "Test 5: Parsed '%s' (stride, dilation, use_padding=true)\n%!" spec5;
-  printf "  Structure: %s\n\n%!" (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels5));
+  printf "  Structure: %s\n\n%!"
+    (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels5));


(* Test 6: unspecified use_padding (legacy syntax) *)
let spec6 = "o+k" in
let labels6 = Einsum_parser.axis_labels_of_spec spec6 in
printf "Test 6: Parsed '%s' (unspecified use_padding)\n%!" spec6;
-  printf "  Structure: %s\n\n%!" (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels6));
+  printf "  Structure: %s\n\n%!"
+    (Sexp.to_string_hum (Einsum_parser.sexp_of_parsed_axis_labels labels6));


printf "All use_padding syntax tests completed!\n%!"


File "test/einsum/test_max_pool2d.ml", line 1, characters 0-0:
diff --git a/_build/default/test/einsum/test_max_pool2d.ml b/_build/default/test/einsum/.formatted/test_max_pool2d.ml
index 51df77c..053a29f 100644
--- a/_build/default/test/einsum/test_max_pool2d.ml
+++ b/_build/default/test/einsum/.formatted/test_max_pool2d.ml
@@ -7,8 +7,7 @@ let max_pool2d = Nn_blocks.max_pool2d


(** Test basic max_pool2d operation with default parameters.


-    Default: stride=2, window_size=2
-    For 4x4 input, output should be 2x2. *)
+    Default: stride=2, window_size=2 For 4x4 input, output should be 2x2. *)
let test_max_pool2d_basic () =
printf "Testing max_pool2d with default parameters (stride=2, window=2)...\n%!";
Tensor.unsafe_reinitialize ();
@@ -34,9 +33,8 @@ let test_max_pool2d_basic () =


(** Test max_pool2d with stride=2, window=3.


-    For 7x7 input with stride=2, window=3 (no padding):
-    Output size = (7 - 3) / 2 + 1 = 3.
-    Valid convolution requires: input = stride * (output - 1) + window = 2 * 2 + 3 = 7 *)
+    For 7x7 input with stride=2, window=3 (no padding): Output size = (7 - 3) / 2 + 1 = 3. Valid
+    convolution requires: input = stride * (output - 1) + window = 2 * 2 + 3 = 7 *)
let test_max_pool2d_window3 () =
printf "Testing max_pool2d with stride=2, window=3...\n%!";
Tensor.unsafe_reinitialize ();
@@ -61,9 +59,8 @@ let test_max_pool2d_window3 () =


(** Test max_pool2d with output dimension 1.


-    For 3x3 input with stride=2, window=3 (no padding):
-    Output size = (3 - 3) / 2 + 1 = 1.
-    This tests the edge case where the kernel exactly covers the input. *)
+    For 3x3 input with stride=2, window=3 (no padding): Output size = (3 - 3) / 2 + 1 = 1. This
+    tests the edge case where the kernel exactly covers the input. *)
let test_max_pool2d_output_dim_1 () =
printf "Testing max_pool2d with output dimension 1...\n%!";
Tensor.unsafe_reinitialize ();
File "test/training/circles_conv.ml", line 1, characters 0-0:
diff --git a/_build/default/test/training/circles_conv.ml b/_build/default/test/training/.formatted/circles_conv.ml
index fb025c0..357625f 100644
--- a/_build/default/test/training/circles_conv.ml
+++ b/_build/default/test/training/.formatted/circles_conv.ml
@@ -1,7 +1,7 @@
(** Circle counting training test using synthetic dataset.


-    This test trains a model to classify images by the number of circles they contain.
-    Uses cross-entropy loss for classification.
+    This test trains a model to classify images by the number of circles they contain. Uses
+    cross-entropy loss for classification.


{2 Known Issues with conv2d in Training}


@@ -17,8 +17,8 @@
hidden dimension(s)" errors during SGD update compilation, as the gradient tensors cannot
determine their shapes.


-    3. {b Workaround}: Use an MLP instead - OCANNL's matrix multiplication handles
-    multi-dimensional inputs automatically without explicit flattening.
+    3. {b Workaround}: Use an MLP instead - OCANNL's matrix multiplication handles multi-dimensional
+    inputs automatically without explicit flattening.


These issues suggest that [conv2d] may need:
- An explicit [out_channels] parameter to constrain output shape
@@ -44,7 +44,8 @@ let () =
(* Configuration for circle dataset *)
let image_size = 16 in
let max_circles = 3 in
-  let num_classes = max_circles in (* Classes: 1, 2, 3 circles -> indices 0, 1, 2 *)
+  let num_classes = max_circles in
+  (* Classes: 1, 2, 3 circles -> indices 0, 1, 2 *)
let config =
Datasets.Circles.Config.
{ image_size; max_radius = 4; min_radius = 2; max_circles; seed = Some seed }
@@ -83,9 +84,10 @@ let () =
let%op batch_images = images @| batch_n in
let%op batch_labels = labels_one_hot @| batch_n in


-  (* Try lenet - this will likely fail due to conv2d shape inference issues.
-     Fallback to MLP if needed. *)
-  let use_lenet = false in (* Set to true to test lenet - currently fails *)
+  (* Try lenet - this will likely fail due to conv2d shape inference issues. Fallback to MLP if
+     needed. *)
+  let use_lenet = false in
+  (* Set to true to test lenet - currently fails *)


let logits =
if use_lenet then (
@@ -111,7 +113,6 @@ let () =
let%op sample_loss = neg (log correct_prob) in
let%op batch_loss = (sample_loss ++ "...|... => 0") /. !..batch_size in


-
(* Training setup *)
let epochs = 10 in
let total_steps = epochs * n_batches in
@@ -133,7 +134,6 @@ let () =
printf "\nStarting training for %d epochs (%d steps)...\n%!" epochs total_steps;


let open Operation.At in
-
for epoch = 1 to epochs do
let epoch_loss = ref 0. in
Train.sequential_loop (Context.bindings sgd_routine) ~f:(fun () ->
File "arrayjit/lib/assignments.ml", line 1, characters 0-0:
diff --git a/_build/default/arrayjit/lib/assignments.ml b/_build/default/arrayjit/lib/.formatted/assignments.ml
index 2c5a13e..0940272 100644
--- a/_build/default/arrayjit/lib/assignments.ml
+++ b/_build/default/arrayjit/lib/.formatted/assignments.ml
@@ -192,10 +192,10 @@ let%track4_sexp to_low_level code =
=
let projections : Indexing.projections = Lazy.force projections in
let basecase rev_iters =
-      (* Create a substitution from product iterators to loop iterators.
-         Fresh loop symbols are needed because product_iterators may be shared across
-         different operations/tensors, but each lowered operation needs private loop symbols
-         to avoid conflicts in low_level.ml's symbol-to-tensor tracking. *)
+      (* Create a substitution from product iterators to loop iterators. Fresh loop symbols are
+         needed because product_iterators may be shared across different operations/tensors, but
+         each lowered operation needs private loop symbols to avoid conflicts in low_level.ml's
+         symbol-to-tensor tracking. *)
let subst_map =
let loop_iters = Array.of_list_rev rev_iters in
Array.mapi projections.product_iterators ~f:(fun i prod_iter ->
File "arrayjit/lib/indexing.ml", line 1, characters 0-0:
diff --git a/_build/default/arrayjit/lib/indexing.ml b/_build/default/arrayjit/lib/.formatted/indexing.ml
index 018c9e9..0d03161 100644
--- a/_build/default/arrayjit/lib/indexing.ml
+++ b/_build/default/arrayjit/lib/.formatted/indexing.ml
@@ -139,8 +139,8 @@ type projections = {
*)
product_iterators : symbol array;
(** The product space iterators (concatentation of the relevant batch, output, input axes) for
-          iterating over the [product_space] axes, where same axes are at same array indices.
-          These may be shared; lowering creates fresh symbols for loop indices. *)
+          iterating over the [product_space] axes, where same axes are at same array indices. These
+          may be shared; lowering creates fresh symbols for loop indices. *)
project_lhs : axis_index array;
(** A projection that takes an [product_space]-bound index and produces an index into the
result of an operation. *)
File "test/einsum/test_einsum_parser.ml", line 1, characters 0-0:
diff --git a/_build/default/test/einsum/test_einsum_parser.ml b/_build/default/test/einsum/.formatted/test_einsum_parser.ml
index c305169..ac88c8a 100644
--- a/_build/default/test/einsum/test_einsum_parser.ml
+++ b/_build/default/test/einsum/.formatted/test_einsum_parser.ml
@@ -12,8 +12,7 @@ let test_single_char () =
(* Test 2: With batch and input *)
let spec2 = "b|i->o" in
let labels2 = Einsum_parser.axis_labels_of_spec spec2 in
-  printf "  'b|i->o' -> batch:%d input:%d output:%d\n"
-    (List.length labels2.given_batch)
+  printf "  'b|i->o' -> batch:%d input:%d output:%d\n" (List.length labels2.given_batch)
(List.length labels2.given_input)
(List.length labels2.given_output);


@@ -21,13 +20,9 @@ let test_single_char () =
let spec3 = "ij;jk=>ik" in
let l1, l2_opt, l3 = Einsum_parser.einsum_of_spec spec3 in
let l2 = Option.value_exn l2_opt in
-  printf "  'ij;jk=>ik' -> (%d,%d);(%d,%d)=>(%d,%d)\n"
-    (List.length l1.given_input)
-    (List.length l1.given_output)
-    (List.length l2.given_input)
-    (List.length l2.given_output)
-    (List.length l3.given_input)
-    (List.length l3.given_output);
+  printf "  'ij;jk=>ik' -> (%d,%d);(%d,%d)=>(%d,%d)\n" (List.length l1.given_input)
+    (List.length l1.given_output) (List.length l2.given_input) (List.length l2.given_output)
+    (List.length l3.given_input) (List.length l3.given_output);


printf "\n"


File "lib/nn_blocks.ml", line 1, characters 0-0:
diff --git a/_build/default/lib/nn_blocks.ml b/_build/default/lib/.formatted/nn_blocks.ml
index b634a26..beac7cc 100644
--- a/_build/default/lib/nn_blocks.ml
+++ b/_build/default/lib/.formatted/nn_blocks.ml
@@ -237,7 +237,8 @@ let%op conv2d ~label ?(kernel_size = 3) ?(stride = 1) ?(use_padding = true) () x


(** Depthwise separable convolution - more efficient for mobile/edge devices. Consists of depthwise
conv (spatial filtering per channel) followed by pointwise conv (1x1 conv for channel mixing) *)
-let%op depthwise_separable_conv2d ~label ?(kernel_size = 3) ?(stride = 1) ?(use_padding = true) () x =
+let%op depthwise_separable_conv2d ~label ?(kernel_size = 3) ?(stride = 1) ?(use_padding = true) () x
+    =
(* Depthwise: each input channel is convolved with its own filter *)
Shape.set_dim kh kernel_size;
Shape.set_dim kw kernel_size;
@@ -271,8 +272,8 @@ let%op avg_pool2d ?(stride = 2) ?(window_size = 2) () x =
Shape.set_dim ww window_size;
let sum =
x
-    +++ "... | stride*oh< + wh, stride*ow< + ww, ..c..; wh, ww => ... | oh, ow, ..c.." [ "wh"; "ww" ]
-          (0.0 + 0.0)
+    +++ "... | stride*oh< + wh, stride*ow< + ww, ..c..; wh, ww => ... | oh, ow, ..c.."
+          [ "wh"; "ww" ] (0.0 + 0.0)
in
sum /. (dim wh *. dim ww)


File "tensor/ppx_shared.ml", line 1, characters 0-0:
diff --git a/_build/default/tensor/ppx_shared.ml b/_build/default/tensor/.formatted/ppx_shared.ml
index 5bf48c7..2d5d0db 100644
--- a/_build/default/tensor/ppx_shared.ml
+++ b/_build/default/tensor/.formatted/ppx_shared.ml
@@ -115,12 +115,12 @@ let ndarray_constant expr =


(** Convert an einsum spec string to an OCaml expression that constructs the runtime string.


-    This function parses the einsum spec using the Einsum_parser, then reconstructs a runtime
-    string expression, handling:
-    - stride and dilation values: if they look like integer literals, emit them directly;
-      otherwise emit [Int.to_string identifier] to convert at runtime
-    - use_padding: if unspecified (legacy syntax), emit [if use_padding then "=" else "<"]
-      to read the value from [Row.use_padding] at runtime
+    This function parses the einsum spec using the Einsum_parser, then reconstructs a runtime string
+    expression, handling:
+    - stride and dilation values: if they look like integer literals, emit them directly; otherwise
+      emit [Int.to_string identifier] to convert at runtime
+    - use_padding: if unspecified (legacy syntax), emit [if use_padding then "=" else "<"] to read
+      the value from [Row.use_padding] at runtime


Example: ["stride*x=+k; y => z"] where [stride] is a variable, generates an expression that
evaluates to e.g. ["2*x=+k; y => z"] if [stride = 2]. *)
@@ -216,11 +216,12 @@ let substitute_identifiers_in_einsum_spec ~loc str_input =
let output_segments =
row_to_segments ~kind:"output" parsed.bcast_output parsed.given_beg_output parsed.given_output
in
-    let has_batch = not (List.is_empty batch_segments) || Option.is_some parsed.bcast_batch in
-    let has_input = not (List.is_empty input_segments) || Option.is_some parsed.bcast_input in
+    let has_batch = (not (List.is_empty batch_segments)) || Option.is_some parsed.bcast_batch in
+    let has_input = (not (List.is_empty input_segments)) || Option.is_some parsed.bcast_input in
let segments =
if has_batch then
-        batch_segments @ [ estring ~loc "|" ]
+        batch_segments
+        @ [ estring ~loc "|" ]
@ (if has_input then input_segments @ [ estring ~loc "->" ] else [])
@ output_segments
else if has_input then input_segments @ [ estring ~loc "->" ] @ output_segments
@@ -248,33 +249,34 @@ let substitute_identifiers_in_einsum_spec ~loc str_input =
let combined =
String.concat
(List.filter_map all_segments ~f:(fun e ->
-               match e.pexp_desc with Pexp_constant (Pconst_string (s, _, _)) -> Some s | _ -> None))
+               match e.pexp_desc with
+               | Pexp_constant (Pconst_string (s, _, _)) -> Some s
+               | _ -> None))
in
estring ~loc combined
else [%expr String.concat ~sep:"" [%e elist ~loc all_segments]]
-  with Parse_error _ ->
+  with Parse_error _ -> (
(* If parsing fails, try as axis_labels_spec *)
-    (try
-       let parsed = axis_labels_of_spec str_input in
-       let segments = parsed_to_segments parsed in
-       let all_literals =
-         List.for_all segments ~f:(fun e ->
-             match e.pexp_desc with Pexp_constant (Pconst_string _) -> true | _ -> false)
-       in
-       if all_literals then
-         let combined =
-           String.concat
-             (List.filter_map segments ~f:(fun e ->
-                  match e.pexp_desc with
-                  | Pexp_constant (Pconst_string (s, _, _)) -> Some s
-                  | _ -> None))
-         in
-         estring ~loc combined
-       else [%expr String.concat ~sep:"" [%e elist ~loc segments]]
-     with Parse_error msg ->
-       (* Fall back to returning the original string with an error note *)
-       pexp_extension ~loc
-       @@ Location.error_extensionf ~loc "Failed to parse einsum spec: %s" msg)
+    try
+      let parsed = axis_labels_of_spec str_input in
+      let segments = parsed_to_segments parsed in
+      let all_literals =
+        List.for_all segments ~f:(fun e ->
+            match e.pexp_desc with Pexp_constant (Pconst_string _) -> true | _ -> false)
+      in
+      if all_literals then
+        let combined =
+          String.concat
+            (List.filter_map segments ~f:(fun e ->
+                 match e.pexp_desc with
+                 | Pexp_constant (Pconst_string (s, _, _)) -> Some s
+                 | _ -> None))
+        in
+        estring ~loc combined
+      else [%expr String.concat ~sep:"" [%e elist ~loc segments]]
+    with Parse_error msg ->
+      (* Fall back to returning the original string with an error note *)
+      pexp_extension ~loc @@ Location.error_extensionf ~loc "Failed to parse einsum spec: %s" msg)


let string_expr ~loc s = Ast_helper.Exp.constant @@ Pconst_string (s, loc, None)


File "tensor/shape.ml", line 1, characters 0-0:
diff --git a/_build/default/tensor/shape.ml b/_build/default/tensor/.formatted/shape.ml
index 0adfd23..fc5663f 100644
--- a/_build/default/tensor/shape.ml
+++ b/_build/default/tensor/.formatted/shape.ml
@@ -1662,9 +1662,9 @@ let%debug4_sexp derive_projections (update_step : update_step) : Idx.projections
Utils.unique_keep_first ~equal:(fun (p, _) (q, _) -> Row.equal_proj_id p q)
@@ List.filter_map all_dims ~f:(Row.get_product_proj proj_env)
in
-  (* Deduplicate by iterator symbol. When Conv_input with d=1 over dimension is used,
-     multiple proj_ids can share the same iterator (e.g., input height and kernel height).
-     We keep the first occurrence for each unique iterator symbol. *)
+  (* Deduplicate by iterator symbol. When Conv_input with d=1 over dimension is used, multiple
+     proj_ids can share the same iterator (e.g., input height and kernel height). We keep the first
+     occurrence for each unique iterator symbol. *)
let all_product_projs_with_iters =
List.map all_product_projs ~f:(fun (p, d) -> (p, d, Row.proj_to_iterator_exn proj_env p))
in
File "tensor/row.ml", line 1, characters 0-0:
diff --git a/_build/default/tensor/row.ml b/_build/default/tensor/.formatted/row.ml
index ef72fd4..f8e422b 100644
--- a/_build/default/tensor/row.ml
+++ b/_build/default/tensor/.formatted/row.ml
@@ -89,18 +89,15 @@ let get_dim ~d ?label ?proj_id () =
Dim { d; label; proj_id }


let effective_kernel_span ~dilation ~kernel_size =
-  (* The effective kernel span with dilation is: 1 + (kernel_size - 1) * dilation
-     This is the actual range of input indices covered by the kernel. *)
-  1 + (kernel_size - 1) * dilation
+  (* The effective kernel span with dilation is: 1 + (kernel_size - 1) * dilation This is the actual
+     range of input indices covered by the kernel. *)
+  1 + ((kernel_size - 1) * dilation)


let kernel_size_of_span ~dilation ~span =
-  (* Inverse of effective_kernel_span. Given span, find kernel_size such that
-     effective_kernel_span ~dilation ~kernel_size = span.
-     Since effective_kernel_span = 1 + (kernel_size - 1) * dilation,
-     we have: span - 1 = (kernel_size - 1) * dilation
-              kernel_size = (span - 1) / dilation + 1 *)
-  if (span - 1) % dilation <> 0 then None
-  else Some ((span - 1) / dilation + 1)
+  (* Inverse of effective_kernel_span. Given span, find kernel_size such that effective_kernel_span
+     ~dilation ~kernel_size = span. Since effective_kernel_span = 1 + (kernel_size - 1) * dilation,
+     we have: span - 1 = (kernel_size - 1) * dilation kernel_size = (span - 1) / dilation + 1 *)
+  if (span - 1) % dilation <> 0 then None else Some (((span - 1) / dilation) + 1)


type 'a dim_hashtbl = 'a Hashtbl.M(Dim_var).t [@@deriving sexp]


@@ -1629,13 +1626,12 @@ let%track6_sexp rec unify_dim ~stage origin (eq : dim * dim) env : constraint_ l
| Affine { stride; over; conv = Some { dilation; kernel = Dim k; use_padding = false }; _ }, Dim s
| Dim s, Affine { stride; over; conv = Some { dilation; kernel = Dim k; use_padding = false }; _ }
->
-      (* Reverse: solve for output_size given input_size s.
-         input_size = stride * (output_size - 1) + effective_kernel_span
-         output_size = (input_size - effective_kernel_span) / stride + 1 *)
+      (* Reverse: solve for output_size given input_size s. input_size = stride * (output_size - 1)
+         + effective_kernel_span output_size = (input_size - effective_kernel_span) / stride + 1 *)
let span : int = effective_kernel_span ~dilation ~kernel_size:k.d in
let numerator : int = s.d - span in
if numerator >= 0 && numerator % stride = 0 then
-        unify_dim ~stage origin (get_dim ~d:(numerator / stride + 1) (), over) env
+        unify_dim ~stage origin (get_dim ~d:((numerator / stride) + 1) (), over) env
else
raise
@@ Shape_error
@@ -1646,12 +1642,11 @@ let%track6_sexp rec unify_dim ~stage origin (eq : dim * dim) env : constraint_ l
| ( Dim i,
Affine
{ stride; over = Dim s; conv = Some { dilation; kernel = Var v; use_padding = false }; _ } )
-    ->
-      (* Infer kernel dimension from the relationship:
-         input_size = stride * (output_size - 1) + effective_kernel_span
-         effective_kernel_span = input_size - stride * (output_size - 1) *)
+    -> (
+      (* Infer kernel dimension from the relationship: input_size = stride * (output_size - 1) +
+         effective_kernel_span effective_kernel_span = input_size - stride * (output_size - 1) *)
let span = i.d - (stride * (s.d - 1)) in
-      (match kernel_size_of_span ~dilation ~span with
+      match kernel_size_of_span ~dilation ~span with
| Some k -> unify_dim ~stage origin (Var v, get_dim ~d:k ()) env
| None ->
raise
@@ -1694,9 +1689,11 @@ let%track6_sexp rec unify_dim ~stage origin (eq : dim * dim) env : constraint_ l
if s1 = s2 && span1 = span2 then unify_dim ~stage origin (o1, o2) env
else if s1 >= s2 && s1 % s2 = 0 then
let stride = s1 / s2 in
-        let new_span = (span1 - span2) / s2 + 1 in
+        let new_span = ((span1 - span2) / s2) + 1 in
(* Encode new_span via a helper conv with dilation=1 *)
-        let helper_kernel_size = Option.value ~default:new_span (kernel_size_of_span ~dilation:1 ~span:new_span) in
+        let helper_kernel_size =
+          Option.value ~default:new_span (kernel_size_of_span ~dilation:1 ~span:new_span)
+        in
let helper_conv =
Some
{
@@ -1710,9 +1707,11 @@ let%track6_sexp rec unify_dim ~stage origin (eq : dim * dim) env : constraint_ l
env
else if s2 >= s1 && s2 % s1 = 0 then
let stride = s2 / s1 in
-        let new_span = (span2 - span1) / s1 + 1 in
+        let new_span = ((span2 - span1) / s1) + 1 in
(* Encode new_span via a helper conv with dilation=1 *)
-        let helper_kernel_size = Option.value ~default:new_span (kernel_size_of_span ~dilation:1 ~span:new_span) in
+        let helper_kernel_size =
+          Option.value ~default:new_span (kernel_size_of_span ~dilation:1 ~span:new_span)
+        in
let helper_conv =
Some
{
@@ -1751,8 +1750,10 @@ let%track6_sexp rec unify_dim ~stage origin (eq : dim * dim) env : constraint_ l
if s1 = s2 && span1 = span2 then unify_dim ~stage origin (o1, o2) env
else if s1 >= s2 && s1 % s2 = 0 then
let stride = s1 / s2 in
-        let new_span = (span1 - span2) / s2 + 1 in
-        let helper_kernel_size = Option.value ~default:new_span (kernel_size_of_span ~dilation:1 ~span:new_span) in
+        let new_span = ((span1 - span2) / s2) + 1 in
+        let helper_kernel_size =
+          Option.value ~default:new_span (kernel_size_of_span ~dilation:1 ~span:new_span)
+        in
let helper_conv =
Some
{
@@ -1766,8 +1767,10 @@ let%track6_sexp rec unify_dim ~stage origin (eq : dim * dim) env : constraint_ l
env
else if s2 >= s1 && s2 % s1 = 0 then
let stride = s2 / s1 in
-        let new_span = (span2 - span1) / s1 + 1 in
-        let helper_kernel_size = Option.value ~default:new_span (kernel_size_of_span ~dilation:1 ~span:new_span) in
+        let new_span = ((span2 - span1) / s1) + 1 in
+        let helper_kernel_size =
+          Option.value ~default:new_span (kernel_size_of_span ~dilation:1 ~span:new_span)
+        in
let helper_conv =
Some
{
@@ -2764,7 +2767,8 @@ let%debug5_sexp solve_row_ineq ~(stage : stage) origin ~(cur : t) ~(subr : t) en
stride_offset = _;
},
Dim s' )
-                  when (stride * (s.d - 1)) + effective_kernel_span ~dilation ~kernel_size:k.d <> s'.d ->
+                  when (stride * (s.d - 1)) + effective_kernel_span ~dilation ~kernel_size:k.d
+                       <> s'.d ->
get_dim ~d:1 ~proj_id:50 ()
| ( Dim s',
Affine
@@ -2774,7 +2778,8 @@ let%debug5_sexp solve_row_ineq ~(stage : stage) origin ~(cur : t) ~(subr : t) en
conv = Some { kernel = Dim k; dilation; use_padding = false };
stride_offset = _;
} )
-                  when (stride * (s.d - 1)) + effective_kernel_span ~dilation ~kernel_size:k.d <> s'.d ->
+                  when (stride * (s.d - 1)) + effective_kernel_span ~dilation ~kernel_size:k.d
+                       <> s'.d ->
get_dim ~d:1 ~proj_id:50 ()
| ( Affine
{
@@ -2806,10 +2811,10 @@ let%debug5_sexp solve_row_ineq ~(stage : stage) origin ~(cur : t) ~(subr : t) en
conv = Some { kernel = Dim k2; dilation = dilation2; use_padding = false };
stride_offset = _;
} )
-                  when stride1 * (s1.d - 1)
-                     + effective_kernel_span ~dilation:dilation1 ~kernel_size:k1.d
-                     <> stride2 * (s2.d - 1)
-                        + effective_kernel_span ~dilation:dilation2 ~kernel_size:k2.d ->
+                  when (stride1 * (s1.d - 1))
+                       + effective_kernel_span ~dilation:dilation1 ~kernel_size:k1.d
+                       <> (stride2 * (s2.d - 1))
+                          + effective_kernel_span ~dilation:dilation2 ~kernel_size:k2.d ->
get_dim ~d:1 ~proj_id:52 ()
| Var _, _ -> d1
| _, Var _ -> d2
@@ -3672,8 +3677,13 @@ let%track7_sexp get_proj_index (proj_env : proj_env) (proj : proj) : Idx.axis_in
| [ (1, s) ] when !offset = 0 -> Idx.Iterator s
| _ -> Idx.Affine { symbols; offset = !offset })
| Conv_input
-        { stride; over; conv = Some { dilation; kernel; kernel_size; use_padding }; stride_offset; target_id }
-      -> (
+        {
+          stride;
+          over;
+          conv = Some { dilation; kernel; kernel_size; use_padding };
+          stride_offset;
+          target_id;
+        } -> (
let over_idx = loop over in
let kernel_idx = loop kernel in
let symbols = ref [] in
@@ -3914,13 +3924,13 @@ let%debug4_sexp solve_proj_equations (eqs : proj_equation list)
@@ Shape_error
("Multiple constraints on the same projection", [ Index_mismatch [ idx; idx2 ] ])));
let product_dim = ref @@ Map.empty (module Proj_id) in
-  (* Collect projection IDs that will get their index from Conv_input (target_id projections).
-     These should NOT get fresh iterators from product_dim processing. *)
+  (* Collect projection IDs that will get their index from Conv_input (target_id projections). These
+     should NOT get fresh iterators from product_dim processing. *)
let conv_input_targets =
Set.of_list (module Proj_id)
@@ List.filter_map !p_conv_input ~f:(fun (p, _) ->
-           let repr, _ = Utils.union_find ~equal:Proj_id.equal !proj_classes ~key:p ~rank:0 in
-           Some repr)
+        let repr, _ = Utils.union_find ~equal:Proj_id.equal !proj_classes ~key:p ~rank:0 in
+        Some repr)
in
List.iter !p_dims ~f:(fun (p, d) ->
let repr, _ = Utils.union_find ~equal:Proj_id.equal !proj_classes ~key:p ~rank:0 in
@@ -3934,8 +3944,8 @@ let%debug4_sexp solve_proj_equations (eqs : proj_equation list)
"Conflicting dimensions for the same projection: %{p#Proj_id} %{d#Int} \
%{d2#Int}"],
[] )));
-  (* Create fresh iterators for product dimensions, EXCEPT for those that will get
-     their index from Conv_input (they will be processed later). *)
+  (* Create fresh iterators for product dimensions, EXCEPT for those that will get their index from
+     Conv_input (they will be processed later). *)
Map.iteri !product_dim ~f:(fun ~key:p ~data:_ ->
let repr, _ = Utils.union_find ~equal:Proj_id.equal !proj_classes ~key:p ~rank:0 in
if not (Set.mem conv_input_targets repr) then
@@ -3995,8 +4005,8 @@ let%debug4_sexp solve_proj_equations (eqs : proj_equation list)
("Cannot unify two Conv_input projections", [ Index_mismatch [ idx1; idx2 ] ])
with _ -> () (* Ignore errors for now *));


-  (* Now create fresh iterators for product dimensions that still don't have an index.
-     This is done after p_conv_input processing so Conv_input projections don't conflict. *)
+  (* Now create fresh iterators for product dimensions that still don't have an index. This is done
+     after p_conv_input processing so Conv_input projections don't conflict. *)
Map.iteri !product_dim ~f:(fun ~key:p ~data:_ ->
let repr, _ = Utils.union_find ~equal:Proj_id.equal !proj_classes ~key:p ~rank:0 in
Utils.mref_add_missing projs repr ~f:(fun () -> Idx.(Iterator (get_symbol ()))));
dune build @fmt failed
"/usr/bin/env" "bash" "-c" "opam exec -- dune build @fmt --ignore-promoted-rules || (echo "dune build @fmt failed"; exit 2)" failed with exit status 2
2025-12-05 14:58.34: Job failed: Failed: Build failed