2025-05-22 20:00.59: New job: test ahrefs/ocannl https://github.com/ahrefs/ocannl.git#refs/heads/master (39741884b740497ac10065d5e464e6c70f9151f4) (linux-x86_64:(lint-fmt)) Base: ocaml/opam:debian-12-ocaml-4.08@sha256:48fa4a7216c3973bb95572cf5dca98cbbcefe90f288f552e7ac70a8ccd438aa7 ocamlformat version: version 0.27.0 (from opam) To reproduce locally: git clone --recursive "https://github.com/ahrefs/ocannl.git" -b "master" && cd "ocannl" && git reset --hard 39741884 cat > Dockerfile <<'END-OF-DOCKERFILE' FROM ocaml/opam:debian-12-ocaml-4.08@sha256:48fa4a7216c3973bb95572cf5dca98cbbcefe90f288f552e7ac70a8ccd438aa7 USER 1000:1000 RUN cd ~/opam-repository && (git cat-file -e 35eb2f107a989a2d623b0bbe170696398fcb9b1e || git fetch origin master) && git reset -q --hard 35eb2f107a989a2d623b0bbe170696398fcb9b1e && git log --no-decorate -n1 --oneline && opam update -u RUN opam depext -i dune WORKDIR /src RUN opam depext -i ocamlformat=0.27.0 COPY --chown=1000:1000 . /src/ RUN opam exec -- dune build @fmt --ignore-promoted-rules || (echo "dune build @fmt failed"; exit 2) END-OF-DOCKERFILE docker build . END-REPRO-BLOCK 2025-05-22 20:00.59: Using cache hint "ahrefs/ocannl-ocaml/opam:debian-12-ocaml-4.08@sha256:48fa4a7216c3973bb95572cf5dca98cbbcefe90f288f552e7ac70a8ccd438aa7-debian-12-4.08_opam-2.3-ocamlformat-35eb2f107a989a2d623b0bbe170696398fcb9b1e" 2025-05-22 20:00.59: Using OBuilder spec: ((from ocaml/opam:debian-12-ocaml-4.08@sha256:48fa4a7216c3973bb95572cf5dca98cbbcefe90f288f552e7ac70a8ccd438aa7) (user (uid 1000) (gid 1000)) (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "cd ~/opam-repository && (git cat-file -e 35eb2f107a989a2d623b0bbe170696398fcb9b1e || git fetch origin master) && git reset -q --hard 35eb2f107a989a2d623b0bbe170696398fcb9b1e && git log --no-decorate -n1 --oneline && opam update -u")) (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam depext -i dune")) (workdir /src) (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam depext -i ocamlformat=0.27.0")) (copy (src .) (dst /src/)) (run (shell "opam exec -- dune build @fmt --ignore-promoted-rules || (echo \"dune build @fmt failed\"; exit 2)")) ) 2025-05-22 20:00.59: Waiting for resource in pool OCluster 2025-05-22 20:00.59: Waiting for worker… 2025-05-22 20:01.31: Got resource from pool OCluster Building on asteria.caelum.ci.dev HEAD is now at 9afb61d2 In progress / broken: Format -> PPrint migration first pass by Claude HEAD is now at 39741884 Untested: convert remaining uses of Format except where printing Sexp values (from ocaml/opam:debian-12-ocaml-4.08@sha256:48fa4a7216c3973bb95572cf5dca98cbbcefe90f288f552e7ac70a8ccd438aa7) 2025-05-22 20:01.32 ---> using "d1b97f3f32fc7cff4791d73e3fff398d19cc5b0541c709028ff05a921e22d2c8" from cache /: (user (uid 1000) (gid 1000)) /: (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "cd ~/opam-repository && (git cat-file -e 35eb2f107a989a2d623b0bbe170696398fcb9b1e || git fetch origin master) && git reset -q --hard 35eb2f107a989a2d623b0bbe170696398fcb9b1e && git log --no-decorate -n1 --oneline && opam update -u")) 35eb2f107a Merge pull request #27838 from maiste/release-dune-3.18.2 <><> Updating package repositories ><><><><><><><><><><><><><><><><><><><><><><> [default] Initialised default (at git+file:///home/opam/opam-repository): [INFO] opam 2.1 and 2.2 include many performance and security improvements over 2.0; please consider upgrading (https://opam.ocaml.org/doc/Install.html) Everything as up-to-date as possible (run with --verbose to show unavailable upgrades). However, you may "opam upgrade" these packages explicitly, which will ask permission to downgrade or uninstall the conflicting packages. Nothing to do. # Run eval $(opam env) to update the current shell environment 2025-05-22 20:01.32 ---> using "0ed37ff9180ea5331ab17e3106ce3fc10bf21b69021c66107f159798cee036fc" from cache /: (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam depext -i dune")) # Detecting depexts using vars: arch=x86_64, os=linux, os-distribution=debian, os-family=debian # No extra OS packages requirements found. # All required OS packages found. # Now letting opam install the packages The following actions will be performed: - install dune 3.18.2 <><> Gathering sources ><><><><><><><><><><><><><><><><><><><><><><><><><><><><> [dune.3.18.2] found in cache <><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><> -> installed dune.3.18.2 Done. # Run eval $(opam env) to update the current shell environment 2025-05-22 20:01.32 ---> using "dc3dc92082cbd6b1d2902dc06db6b555f449a0b1c6f054b5888f3ddab10a5d9e" from cache /: (workdir /src) /src: (run (cache (opam-archives (target /home/opam/.opam/download-cache))) (network host) (shell "opam depext -i ocamlformat=0.27.0")) # Detecting depexts using vars: arch=x86_64, os=linux, os-distribution=debian, os-family=debian # No extra OS packages requirements found. # All required OS packages found. # Now letting opam install the packages The following actions will be performed: - install sexplib0 v0.14.0 [required by base] - install dune-build-info 3.18.2 [required by ocamlformat-lib] - install cmdliner 1.3.0 [required by ocamlformat] - install menhirLib 20240715 [required by ocamlformat-lib] - install menhirCST 20240715 [required by menhir] - install ocamlbuild 0.16.1 [required by fpath, astring, uuseg] - install menhirSdk 20240715 [required by ocamlformat-lib] - install either 1.0.0 [required by ocamlformat-lib] - install ocaml-version 4.0.0 [required by ocamlformat-lib] - install camlp-streams 5.0.1 [required by ocamlformat-lib] - install csexp 1.5.2 [required by ocamlformat] - install seq base [required by re] - install fix 20250428 [required by ocamlformat-lib] - install ocamlfind 1.9.8 [required by ocp-indent, astring, fpath, uuseg] - install menhir 20240715 [required by ocamlformat-lib] - install dune-configurator 3.18.2 [required by base] - install re 1.11.0 [required by ocamlformat] - install topkg 1.0.8 [required by fpath, astring, uuseg] - install base-bytes base [required by ocp-indent] - install base v0.14.3 [required by ocamlformat-lib] - install uutf 1.0.4 [required by ocamlformat-lib] - install astring 0.8.5 [required by ocamlformat-lib] - install ocp-indent 1.8.1 [required by ocamlformat-lib] - install stdio v0.14.0 [required by ocamlformat-lib] - install uucp 15.0.0 [required by uuseg] - install fpath 0.7.3 [required by ocamlformat-lib] - install uuseg 15.0.0 [required by ocamlformat-lib] - install ocamlformat-lib 0.27.0 [required by ocamlformat] - install ocamlformat 0.27.0 ===== 29 to install ===== <><> Gathering sources ><><><><><><><><><><><><><><><><><><><><><><><><><><><><> [astring.0.8.5] found in cache [base.v0.14.3] found in cache [camlp-streams.5.0.1] found in cache [cmdliner.1.3.0] found in cache [csexp.1.5.2] found in cache [dune-build-info.3.18.2] found in cache [dune-configurator.3.18.2] found in cache [either.1.0.0] found in cache [fix.20250428] found in cache [fpath.0.7.3] found in cache [menhir.20240715] found in cache [menhirCST.20240715] found in cache [menhirLib.20240715] found in cache [menhirSdk.20240715] found in cache [ocaml-version.4.0.0] found in cache [ocamlbuild.0.16.1] found in cache [ocamlfind.1.9.8] found in cache [ocamlformat.0.27.0] found in cache [ocamlformat-lib.0.27.0] found in cache [ocp-indent.1.8.1] found in cache [re.1.11.0] found in cache [sexplib0.v0.14.0] found in cache [stdio.v0.14.0] found in cache [topkg.1.0.8] found in cache [uucp.15.0.0] found in cache [uuseg.15.0.0] found in cache [uutf.1.0.4] found in cache <><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><> -> installed seq.base -> installed camlp-streams.5.0.1 -> installed csexp.1.5.2 -> installed cmdliner.1.3.0 -> installed either.1.0.0 -> installed fix.20250428 -> installed menhirCST.20240715 -> installed menhirLib.20240715 -> installed menhirSdk.20240715 -> installed ocaml-version.4.0.0 -> installed re.1.11.0 -> installed sexplib0.v0.14.0 -> installed dune-build-info.3.18.2 -> installed dune-configurator.3.18.2 -> installed ocamlfind.1.9.8 -> installed base-bytes.base -> installed ocamlbuild.0.16.1 -> installed ocp-indent.1.8.1 -> installed base.v0.14.3 -> installed topkg.1.0.8 -> installed stdio.v0.14.0 -> installed uutf.1.0.4 -> installed astring.0.8.5 -> installed fpath.0.7.3 -> installed menhir.20240715 -> installed uucp.15.0.0 -> installed uuseg.15.0.0 -> installed ocamlformat-lib.0.27.0 -> installed ocamlformat.0.27.0 Done. <><> ocp-indent.1.8.1 installed successfully ><><><><><><><><><><><><><><><><><> => This package requires additional configuration for use in editors. Install package 'user-setup', or manually: * for Emacs, add these lines to ~/.emacs: (add-to-list 'load-path "/home/opam/.opam/4.08/share/emacs/site-lisp") (require 'ocp-indent) * for Vim, add this line to ~/.vimrc: set rtp^="/home/opam/.opam/4.08/share/ocp-indent/vim" # Run eval $(opam env) to update the current shell environment 2025-05-22 20:01.32 ---> using "5e3a5282f655843df8e02a2497598f2918acc59345107286c51ff04d386b492b" from cache /src: (copy (src .) (dst /src/)) 2025-05-22 20:01.32 ---> saved as "491a415c3bb5e4af8baed0325b207194cf59d8fb5b2ad2e968261b8a3077c3ce" /src: (run (shell "opam exec -- dune build @fmt --ignore-promoted-rules || (echo \"dune build @fmt failed\"; exit 2)")) File "arrayjit/bin/dune", line 6, characters 21-34: 6 | (pps ppx_minidebug ppx_sexp_conv)) ^^^^^^^^^^^^^ Error: Library "ppx_sexp_conv" not found. -> required by _build/default/arrayjit/bin/read_config.exe -> required by %{dep:../../arrayjit/bin/read_config.exe} at test/dune:25 -> required by _build/default/test/config/ocannl_backend.txt -> required by %{read:config/ocannl_backend.txt} at test/dune:44 -> required by Computing directory contents of _build/default/test File "arrayjit/bin/dune", line 6, characters 7-20: 6 | (pps ppx_minidebug ppx_sexp_conv)) ^^^^^^^^^^^^^ Error: Library "ppx_minidebug" not found. -> required by _build/default/arrayjit/bin/.merlin-conf/exe-read_config -> required by _build/default/arrayjit/bin/read_config.exe -> required by %{dep:../../arrayjit/bin/read_config.exe} at test/dune:25 -> required by _build/default/test/config/ocannl_backend.txt -> required by %{read:config/ocannl_backend.txt} at test/dune:44 -> required by Computing directory contents of _build/default/test File "arrayjit/bin/dune", line 1, characters 0-0: diff --git a/_build/default/arrayjit/bin/dune b/_build/default/arrayjit/bin/.formatted/dune index c96c606..a066be4 100644 --- a/_build/default/arrayjit/bin/dune +++ b/_build/default/arrayjit/bin/.formatted/dune @@ -4,4 +4,4 @@ (libraries utils) (preprocess (pps ppx_minidebug ppx_sexp_conv)) - (modes exe)) \ No newline at end of file + (modes exe)) File "arrayjit/bin/read_config.ml", line 1, characters 0-0: diff --git a/_build/default/arrayjit/bin/read_config.ml b/_build/default/arrayjit/bin/.formatted/read_config.ml index 7e0ed33..a0e7afe 100644 --- a/_build/default/arrayjit/bin/read_config.ml +++ b/_build/default/arrayjit/bin/.formatted/read_config.ml @@ -2,22 +2,18 @@ open Base open Stdio let extract_config arg = - let prefixes = ["--read="; "--read-"; "--read_"] in + let prefixes = [ "--read="; "--read-"; "--read_" ] in List.find_map prefixes ~f:(fun prefix -> - Option.map (String.chop_prefix arg ~prefix) ~f:(fun config -> config)) + Option.map (String.chop_prefix arg ~prefix) ~f:(fun config -> config)) let () = - let config_opt = - Array.find_map Stdlib.Sys.argv ~f:extract_config - in + let config_opt = Array.find_map Stdlib.Sys.argv ~f:extract_config in match config_opt with - | Some config -> + | Some config -> ( let value = Utils.get_global_arg ~default:"" ~arg_name:config in let filename = "ocannl_" ^ config ^ ".txt" in - (try - Out_channel.write_all filename ~data:value; - printf "Wrote value of '%s' to %s\n" config filename - with exn -> - eprintf "Error writing to %s: %s\n" filename (Exn.to_string exn)) - | None -> - printf "No --read=<config>, --read-<config>, or --read_<config> argument found.\n" + try + Out_channel.write_all filename ~data:value; + printf "Wrote value of '%s' to %s\n" config filename + with exn -> eprintf "Error writing to %s: %s\n" filename (Exn.to_string exn)) + | None -> printf "No --read=<config>, --read-<config>, or --read_<config> argument found.\n" File "lib/tensor.mli", line 1, characters 0-0: diff --git a/_build/default/lib/tensor.mli b/_build/default/lib/.formatted/tensor.mli index 2b10084..c42347f 100644 --- a/_build/default/lib/tensor.mli +++ b/_build/default/lib/.formatted/tensor.mli @@ -299,7 +299,7 @@ val to_doc : t -> PPrint.document - val print : +val print : ?spy:bool -> with_grad:bool -> with_code:bool -> File "arrayjit/lib/lowered_backend_missing.ml", line 1, characters 0-0: diff --git a/_build/default/arrayjit/lib/lowered_backend_missing.ml b/_build/default/arrayjit/lib/.formatted/lowered_backend_missing.ml index cb9affa..a5b0e8c 100644 --- a/_build/default/arrayjit/lib/lowered_backend_missing.ml +++ b/_build/default/arrayjit/lib/.formatted/lowered_backend_missing.ml @@ -95,13 +95,15 @@ struct failwith @@ "Backend " ^ Config.name ^ " missing -- install the corresponding library" let static_properties = - Sexp.List [ - Sexp.Atom (Config.name ^ "_missing"); - Sexp.List [ - Sexp.Atom "error"; - Sexp.Atom ("Backend " ^ Config.name ^ " missing -- install the corresponding library") + Sexp.List + [ + Sexp.Atom (Config.name ^ "_missing"); + Sexp.List + [ + Sexp.Atom "error"; + Sexp.Atom ("Backend " ^ Config.name ^ " missing -- install the corresponding library"); + ]; ] - ] let get_debug_info _stream = failwith @@ "Backend " ^ Config.name ^ " missing -- install the corresponding library" File "arrayjit/lib/cc_backend.ml", line 1, characters 0-0: diff --git a/_build/default/arrayjit/lib/cc_backend.ml b/_build/default/arrayjit/lib/.formatted/cc_backend.ml index 7e1200b..16382fa 100644 --- a/_build/default/arrayjit/lib/cc_backend.ml +++ b/_build/default/arrayjit/lib/.formatted/cc_backend.ml @@ -89,6 +89,7 @@ let%diagn_sexp compile ~(name : string) bindings (lowered : Low_level.optimized) let use_host_memory = use_host_memory let procs = [| lowered |] + let full_printf_support = not @@ Bool.of_string @@ Utils.get_global_arg ~default:"false" ~arg_name:"prefer_backend_uniformity" File "bin/micrograd_demo_logging.ml", line 1, characters 0-0: diff --git a/_build/default/bin/micrograd_demo_logging.ml b/_build/default/bin/.formatted/micrograd_demo_logging.ml index ff983c1..bd11af4 100644 --- a/_build/default/bin/micrograd_demo_logging.ml +++ b/_build/default/bin/.formatted/micrograd_demo_logging.ml @@ -36,4 +36,4 @@ let () = Train.run step; Tensor.print ~with_code:false ~with_grad:false `Default g; Tensor.print ~with_code:false ~with_grad:true `Default a; - Tensor.print ~with_code:false ~with_grad:true `Default b \ No newline at end of file + Tensor.print ~with_code:false ~with_grad:true `Default b File "arrayjit/lib/schedulers.ml", line 1, characters 0-0: diff --git a/_build/default/arrayjit/lib/schedulers.ml b/_build/default/arrayjit/lib/.formatted/schedulers.ml index 556961e..e497391 100644 --- a/_build/default/arrayjit/lib/schedulers.ml +++ b/_build/default/arrayjit/lib/.formatted/schedulers.ml @@ -188,17 +188,21 @@ module Multicore (Backend : For_add_scheduler) : let suggested_num_streams _device = Domain.recommended_domain_count () - 2 let static_properties = - Sexp.List [ - Sexp.Atom "multicore_devices"; - Sexp.List [ - Sexp.Atom "device"; - Sexp.List [ - Sexp.List [Sexp.Atom "device_name"; Sexp.Atom "CPU"]; - Sexp.List [Sexp.Atom "device_ordinal"; [%sexp_of: int] 0]; - Sexp.List [Sexp.Atom "num_domains"; [%sexp_of: int] (Domain.recommended_domain_count ())]; - ] + Sexp.List + [ + Sexp.Atom "multicore_devices"; + Sexp.List + [ + Sexp.Atom "device"; + Sexp.List + [ + Sexp.List [ Sexp.Atom "device_name"; Sexp.Atom "CPU" ]; + Sexp.List [ Sexp.Atom "device_ordinal"; [%sexp_of: int] 0 ]; + Sexp.List + [ Sexp.Atom "num_domains"; [%sexp_of: int] (Domain.recommended_domain_count ()) ]; + ]; + ]; ] - ] let%track7_sexp cleanup_stream (stream : stream) : unit = (* Allow running in parallel. *) @@ -274,17 +278,20 @@ module Sync (Backend : For_add_scheduler) = struct let await _stream = () let static_properties = - Sexp.List [ - Sexp.Atom "sync_devices"; - Sexp.List [ - Sexp.Atom "device"; - Sexp.List [ - Sexp.List [Sexp.Atom "device_name"; Sexp.Atom "CPU"]; - Sexp.List [Sexp.Atom "device_ordinal"; Sexp.Atom "0"]; - Sexp.List [Sexp.Atom "threads"; Sexp.Atom "1"]; - ] + Sexp.List + [ + Sexp.Atom "sync_devices"; + Sexp.List + [ + Sexp.Atom "device"; + Sexp.List + [ + Sexp.List [ Sexp.Atom "device_name"; Sexp.Atom "CPU" ]; + Sexp.List [ Sexp.Atom "device_ordinal"; Sexp.Atom "0" ]; + Sexp.List [ Sexp.Atom "threads"; Sexp.Atom "1" ]; + ]; + ]; ] - ] (* let global_run_no = ref 0 *) let schedule_task _stream task = Ir.Task.run task File "arrayjit/lib/indexing.ml", line 1, characters 0-0: diff --git a/_build/default/arrayjit/lib/indexing.ml b/_build/default/arrayjit/lib/.formatted/indexing.ml index 566bb07..1c35dc1 100644 --- a/_build/default/arrayjit/lib/indexing.ml +++ b/_build/default/arrayjit/lib/.formatted/indexing.ml @@ -199,24 +199,18 @@ let derive_index ~product_syms ~(projection : axis_index array) = module Pp_helpers = struct open PPrint - + let pp_comma () = comma ^^ space let pp_symbol sym = string (symbol_ident sym) let pp_static_symbol { static_symbol; static_range } = match static_range with | None -> pp_symbol static_symbol - | Some range -> - infix 4 1 colon (pp_symbol static_symbol) - (brackets (string "0.." ^^ OCaml.int (range - 1))) - - let pp_axis_index = function - | Iterator sym -> pp_symbol sym - | Fixed_idx i -> OCaml.int i + | Some range -> + infix 4 1 colon (pp_symbol static_symbol) (brackets (string "0.." ^^ OCaml.int (range - 1))) - let pp_indices idcs = - separate (pp_comma ()) (Array.to_list idcs |> List.map ~f:pp_axis_index) - + let pp_axis_index = function Iterator sym -> pp_symbol sym | Fixed_idx i -> OCaml.int i + let pp_indices idcs = separate (pp_comma ()) (Array.to_list idcs |> List.map ~f:pp_axis_index) let print ppf doc = ToFormatter.pretty 1.0 80 ppf doc end @@ -238,5 +232,6 @@ module Doc_helpers = struct let pp_axis_index idx = match idx with Iterator sym -> pp_symbol sym | Fixed_idx i -> PPrint.OCaml.int i - let pp_indices idcs = PPrint.separate (pp_comma ()) (Array.to_list idcs |> List.map ~f:pp_axis_index) + let pp_indices idcs = + PPrint.separate (pp_comma ()) (Array.to_list idcs |> List.map ~f:pp_axis_index) end File "bin/micrograd_basic.ml", line 1, characters 0-0: diff --git a/_build/default/bin/micrograd_basic.ml b/_build/default/bin/.formatted/micrograd_basic.ml index 382f09a..66ad733 100644 --- a/_build/default/bin/micrograd_basic.ml +++ b/_build/default/bin/.formatted/micrograd_basic.ml @@ -8,7 +8,7 @@ module Rand = Ir.Rand.Lib let _get_local_debug_runtime = Utils.get_local_debug_runtime -let%diagn_sexp _suspended() = +let%diagn_sexp _suspended () = let module Backend = (val Backends.fresh_backend ~backend_name:"multicore_cc" ()) in let stream = Backend.(new_stream @@ get_device ~ordinal:0) in let ctx = Backend.make_context stream in @@ -33,7 +33,7 @@ let%diagn_sexp _suspended() = Tensor.print ~with_code:false ~with_grad:true `Default @@ a; Tensor.print ~with_code:false ~with_grad:true `Default @@ b -let%diagn_sexp () : unit = +let%diagn_sexp () : unit = let module Backend = (val Backends.fresh_backend ()) in let stream = Backend.(new_stream @@ get_device ~ordinal:0) in let ctx = Backend.make_context stream in File "arrayjit/lib/assignments.ml", line 1, characters 0-0: diff --git a/_build/default/arrayjit/lib/assignments.ml b/_build/default/arrayjit/lib/.formatted/assignments.ml index 92c5b53..3792de5 100644 --- a/_build/default/arrayjit/lib/assignments.ml +++ b/_build/default/arrayjit/lib/.formatted/assignments.ml @@ -282,7 +282,7 @@ let get_ident_within_code ?no_dots c = let doc_hum ?name ?static_indices () c = let ident = get_ident_within_code c in let buffer_ident = function Node tn -> ident tn | Merge_buffer tn -> ident tn ^ ".merge" in - + let open PPrint in let doc_of_fetch_op (op : fetch_op) = match op with @@ -298,76 +298,83 @@ let doc_hum ?name ?static_indices () c = | Embed_symbol { static_symbol; static_range = _ } -> string ("!@" ^ Indexing.symbol_ident static_symbol) in - + let rec doc_of_code = function | Noop -> empty - | Seq (c1, c2) -> - doc_of_code c1 ^^ doc_of_code c2 + | Seq (c1, c2) -> doc_of_code c1 ^^ doc_of_code c2 | Block_comment (s, Noop) -> string ("# \"" ^ s ^ "\";") ^^ break 1 - | Block_comment (s, c) -> - string ("# \"" ^ s ^ "\";") ^^ break 1 ^^ doc_of_code c + | Block_comment (s, c) -> string ("# \"" ^ s ^ "\";") ^^ break 1 ^^ doc_of_code c | Accum_ternop { initialize_neutral; accum; op; lhs; rhs1; rhs2; rhs3; projections } -> let proj_spec = if Lazy.is_val projections then (Lazy.force projections).debug_info.spec else "<not-in-yet>" in (* Uncurried syntax for ternary operations. *) - string (ident lhs) ^^ space ^^ - string (Ops.assign_op_cd_syntax ~initialize_neutral accum) ^^ space ^^ - string (Ops.ternop_cd_syntax op) ^^ - string "(" ^^ string (buffer_ident rhs1) ^^ string ", " ^^ - string (buffer_ident rhs2) ^^ string ", " ^^ - string (buffer_ident rhs3) ^^ string ")" ^^ - (if not (String.equal proj_spec ".") then - string (" ~logic:\"" ^ proj_spec ^ "\"") - else empty) ^^ - string ";" ^^ break 1 + string (ident lhs) + ^^ space + ^^ string (Ops.assign_op_cd_syntax ~initialize_neutral accum) + ^^ space + ^^ string (Ops.ternop_cd_syntax op) + ^^ string "(" + ^^ string (buffer_ident rhs1) + ^^ string ", " + ^^ string (buffer_ident rhs2) + ^^ string ", " + ^^ string (buffer_ident rhs3) + ^^ string ")" + ^^ (if not (String.equal proj_spec ".") then string (" ~logic:\"" ^ proj_spec ^ "\"") + else empty) + ^^ string ";" ^^ break 1 | Accum_binop { initialize_neutral; accum; op; lhs; rhs1; rhs2; projections } -> let proj_spec = if Lazy.is_val projections then (Lazy.force projections).debug_info.spec else "<not-in-yet>" in - string (ident lhs) ^^ space ^^ - string (Ops.assign_op_cd_syntax ~initialize_neutral accum) ^^ space ^^ - string (buffer_ident rhs1) ^^ space ^^ - string (Ops.binop_cd_syntax op) ^^ space ^^ - string (buffer_ident rhs2) ^^ - (if (not (String.equal proj_spec ".")) || - List.mem ~equal:Ops.equal_binop Ops.[ Mul; Div ] op - then string (" ~logic:\"" ^ proj_spec ^ "\"") - else empty) ^^ - string ";" ^^ break 1 + string (ident lhs) + ^^ space + ^^ string (Ops.assign_op_cd_syntax ~initialize_neutral accum) + ^^ space + ^^ string (buffer_ident rhs1) + ^^ space + ^^ string (Ops.binop_cd_syntax op) + ^^ space + ^^ string (buffer_ident rhs2) + ^^ (if + (not (String.equal proj_spec ".")) + || List.mem ~equal:Ops.equal_binop Ops.[ Mul; Div ] op + then string (" ~logic:\"" ^ proj_spec ^ "\"") + else empty) + ^^ string ";" ^^ break 1 | Accum_unop { initialize_neutral; accum; op; lhs; rhs; projections } -> let proj_spec = if Lazy.is_val projections then (Lazy.force projections).debug_info.spec else "<not-in-yet>" in - string (ident lhs) ^^ space ^^ - string (Ops.assign_op_cd_syntax ~initialize_neutral accum) ^^ space ^^ - (if not @@ Ops.equal_unop op Ops.Identity then - string (Ops.unop_cd_syntax op ^ " ") - else empty) ^^ - string (buffer_ident rhs) ^^ - (if not (String.equal proj_spec ".") then - string (" ~logic:\"" ^ proj_spec ^ "\"") - else empty) ^^ - string ";" ^^ break 1 + string (ident lhs) + ^^ space + ^^ string (Ops.assign_op_cd_syntax ~initialize_neutral accum) + ^^ space + ^^ (if not @@ Ops.equal_unop op Ops.Identity then string (Ops.unop_cd_syntax op ^ " ") + else empty) + ^^ string (buffer_ident rhs) + ^^ (if not (String.equal proj_spec ".") then string (" ~logic:\"" ^ proj_spec ^ "\"") + else empty) + ^^ string ";" ^^ break 1 | Fetch { array; fetch_op; dims = _ } -> string (ident array) ^^ string " := " ^^ doc_of_fetch_op fetch_op ^^ string ";" ^^ break 1 in - + (* Create the header document *) - let header_doc = - match name, static_indices with - | Some n, Some si -> - string (n ^ " (") ^^ - separate (comma ^^ space) - (List.map si ~f:Indexing.Doc_helpers.pp_static_symbol) ^^ - string "):" ^^ space + let header_doc = + match (name, static_indices) with + | Some n, Some si -> + string (n ^ " (") + ^^ separate (comma ^^ space) (List.map si ~f:Indexing.Doc_helpers.pp_static_symbol) + ^^ string "):" ^^ space | Some n, None -> string (n ^ ":") ^^ space | _ -> empty in - + header_doc ^^ nest 2 (doc_of_code c) let%track6_sexp lower ~unoptim_ll_source ~ll_source ~cd_source ~name static_indices (proc : t) : File "bin/moons_benchmark.ml", line 1, characters 0-0: diff --git a/_build/default/bin/moons_benchmark.ml b/_build/default/bin/.formatted/moons_benchmark.ml index 0f55116..1bcb12e 100644 --- a/_build/default/bin/moons_benchmark.ml +++ b/_build/default/bin/.formatted/moons_benchmark.ml @@ -264,7 +264,8 @@ let _mem_benchmarks = ~f:(fun batch_size -> List.concat_map [ 0; (* 1; 2; *) 3 ] ~f:(fun inlining_cutoff -> List.concat_map [ (* 1; 3; *) 7 (* *) ] ~f:(fun seed -> - List.concat_map [ (* "gccjit" ; *) "multicore_cc"; "cuda" ] ~f:(fun backend_name -> + List.concat_map [ (* "gccjit" ; *) "multicore_cc"; "cuda" ] + ~f:(fun backend_name -> List.concat_map [ (* CDSL.double; *) CDSL.single; CDSL.half ] ~f:(fun value_prec -> [ File "arrayjit/lib/cuda_backend.ml", line 1, characters 0-0: diff --git a/_build/default/arrayjit/lib/cuda_backend.ml b/_build/default/arrayjit/lib/.formatted/cuda_backend.ml index dc74b88..7f1247e 100644 --- a/_build/default/arrayjit/lib/cuda_backend.ml +++ b/_build/default/arrayjit/lib/.formatted/cuda_backend.ml @@ -287,8 +287,8 @@ end) : Ir.Backend_impl.Lowered_backend = struct | Void_prec -> "void" let binop_syntax prec v = - (* TODO: consider using binop_syntax inherited from Pure_C_config and overriding only - where different. *) + (* TODO: consider using binop_syntax inherited from Pure_C_config and overriding only where + different. *) let open PPrint in let f op_str v1 v2 = group @@ parens (v1 ^^ space ^^ string op_str ^^ space ^^ v2) in let func fn v1 v2 = group (string fn ^^ parens (separate comma [ v1; v2 ])) in File "arrayjit/lib/c_syntax.ml", line 1, characters 0-0: diff --git a/_build/default/arrayjit/lib/c_syntax.ml b/_build/default/arrayjit/lib/.formatted/c_syntax.ml index db4196f..f18f001 100644 --- a/_build/default/arrayjit/lib/c_syntax.ml +++ b/_build/default/arrayjit/lib/.formatted/c_syntax.ml @@ -355,8 +355,7 @@ module C_syntax (B : C_syntax_config) = struct B.pp_log_statement ~log_param_c_expr_doc:log_param_doc ~base_message_literal:base_message ~args_docs:[] else string "/* " ^^ string message ^^ string " */" - | Staged_compilation callback -> - callback () + | Staged_compilation callback -> callback () | Set_local ({ scope_id; tn = { prec; _ } }, value) -> let local_defs, value_doc = pp_float (Lazy.force prec) value in let assignment = File "arrayjit/lib/low_level.ml", line 1, characters 0-0: diff --git a/_build/default/arrayjit/lib/low_level.ml b/_build/default/arrayjit/lib/.formatted/low_level.ml index cd4a3eb..7b622ad 100644 --- a/_build/default/arrayjit/lib/low_level.ml +++ b/_build/default/arrayjit/lib/.formatted/low_level.ml @@ -826,11 +826,10 @@ let function_header_doc ?name ?static_indices () = let open PPrint in match (name, static_indices) with | Some name, Some static_indices -> - !^name ^^ space ^^ - parens (separate comma_sep (List.map ~f:pp_static_symbol static_indices)) ^^ - colon ^^ space - | Some name, None -> - !^name ^^ colon ^^ space + !^name ^^ space + ^^ parens (separate comma_sep (List.map ~f:pp_static_symbol static_indices)) + ^^ colon ^^ space + | Some name, None -> !^name ^^ colon ^^ space | _ -> empty let get_ident_within_code ?no_dots ?(blacklist = []) llcs = @@ -897,53 +896,48 @@ let get_ident_within_code ?no_dots ?(blacklist = []) llcs = let to_doc_cstyle ?name ?static_indices () llc = let ident_label = get_ident_within_code [| llc |] in let open PPrint in - let doc_ident la = string (ident_label la) in let doc_local { tn; scope_id } = string ("v" ^ Int.to_string scope_id ^ "_") ^^ doc_ident tn in - + let rec doc_of_code c = match c with | Noop -> empty | Seq (c1, c2) -> - let docs = List.filter_map [c1; c2] ~f:(function - | Noop -> None - | c -> Some (doc_of_code c)) + let docs = + List.filter_map [ c1; c2 ] ~f:(function Noop -> None | c -> Some (doc_of_code c)) in separate hardline docs | For_loop { index = i; from_; to_; body; trace_it = _ } -> - let header = string "for " ^^ pp_symbol i ^^ string " = " ^^ - int from_ ^^ string " to " ^^ int to_ ^^ string " {" in + let header = + string "for " ^^ pp_symbol i ^^ string " = " ^^ int from_ ^^ string " to " ^^ int to_ + ^^ string " {" + in let body_doc = nest 2 (break 1 ^^ doc_of_code body) in group (header ^^ body_doc ^^ break 1 ^^ string "}") | Zero_out tn -> string "zero_out " ^^ doc_ident tn ^^ string ";" | Set p -> - p.debug <- ""; (* We don't use debug string in PPrint version *) + p.debug <- ""; + (* We don't use debug string in PPrint version *) let prec = Lazy.force p.tn.prec in - group ( - doc_ident p.tn ^^ - brackets (pp_indices p.idcs) ^^ - string " := " ^^ - doc_of_float prec p.llv ^^ - string ";" - ) + group + (doc_ident p.tn + ^^ brackets (pp_indices p.idcs) + ^^ string " := " ^^ doc_of_float prec p.llv ^^ string ";") | Comment message -> string ("/* " ^ message ^ " */") | Staged_compilation callback -> callback () | Set_local (id, llv) -> let prec = Lazy.force id.tn.prec in group (doc_local id ^^ string " := " ^^ doc_of_float prec llv ^^ string ";") - and doc_of_float prec value = match value with - | Local_scope { id; body; _ } -> - group ( - doc_local id ^^ string " {" ^^ - nest 2 (break 1 ^^ doc_of_code body) ^^ - break 1 ^^ string "}" - ) + | Local_scope { id; body; _ } -> + group + (doc_local id ^^ string " {" + ^^ nest 2 (break 1 ^^ doc_of_code body) + ^^ break 1 ^^ string "}") | Get_local id -> doc_local id | Get_global (Ops.C_function s, None) -> string (s ^ "()") - | Get_global (Ops.C_function s, Some idcs) -> - string s ^^ parens (pp_indices idcs) + | Get_global (Ops.C_function s, Some idcs) -> string s ^^ parens (pp_indices idcs) | Get_global (Ops.External_unsafe { ptr; prec; dims = _ }, None) -> string (Ops.ptr_to_string_hum ptr prec) | Get_global (Ops.External_unsafe { ptr; prec; dims = _ }, Some idcs) -> @@ -954,91 +948,69 @@ let to_doc_cstyle ?name ?static_indices () llc = | Get_global (Ops.Merge_buffer { source_node_id }, Some idcs) -> let tn = Option.value_exn ~here:[%here] @@ Tnode.find ~id:source_node_id in group (doc_ident tn ^^ string ".merge" ^^ brackets (pp_indices idcs)) - | Get (tn, idcs) -> - group (doc_ident tn ^^ brackets (pp_indices idcs)) + | Get (tn, idcs) -> group (doc_ident tn ^^ brackets (pp_indices idcs)) | Constant c -> string (Printf.sprintf "%.16g" c) | Embed_index idx -> pp_axis_index idx | Ternop (op, v1, v2, v3) -> let prefix, comma1, comma2, postfix = Ops.ternop_c_syntax prec op in - group ( - string prefix ^^ - doc_of_float prec v1 ^^ - string comma1 ^^ space ^^ - doc_of_float prec v2 ^^ - string comma2 ^^ space ^^ - doc_of_float prec v3 ^^ - string postfix - ) + group + (string prefix ^^ doc_of_float prec v1 ^^ string comma1 ^^ space ^^ doc_of_float prec v2 + ^^ string comma2 ^^ space ^^ doc_of_float prec v3 ^^ string postfix) | Binop (Arg1, v1, _v2) -> doc_of_float prec v1 | Binop (Arg2, _v1, v2) -> doc_of_float prec v2 | Binop (op, v1, v2) -> let prefix, infix, postfix = Ops.binop_c_syntax prec op in - group ( - string prefix ^^ - doc_of_float prec v1 ^^ - string infix ^^ space ^^ - doc_of_float prec v2 ^^ - string postfix - ) + group + (string prefix ^^ doc_of_float prec v1 ^^ string infix ^^ space ^^ doc_of_float prec v2 + ^^ string postfix) | Unop (Identity, v) -> doc_of_float prec v | Unop (op, v) -> let prefix, postfix = Ops.unop_c_syntax prec op in string prefix ^^ doc_of_float prec v ^^ string postfix - in - hardline ^^ - nest 2 ( - function_header_doc ?name ?static_indices () ^^ - doc_of_code llc - ) + in + hardline ^^ nest 2 (function_header_doc ?name ?static_indices () ^^ doc_of_code llc) let doc_hum ?name ?static_indices () llc = let ident_label = get_ident_within_code [| llc |] in let open PPrint in - let doc_ident la = string (ident_label la) in let doc_local { tn; scope_id } = string ("v" ^ Int.to_string scope_id ^ "_") ^^ doc_ident tn in - + let rec doc_of_code c = match c with | Noop -> empty | Seq (c1, c2) -> - let docs = List.filter_map [c1; c2] ~f:(function - | Noop -> None - | c -> Some (doc_of_code c)) + let docs = + List.filter_map [ c1; c2 ] ~f:(function Noop -> None | c -> Some (doc_of_code c)) in separate hardline docs | For_loop { index = i; from_; to_; body; trace_it = _ } -> - let header = string "for " ^^ pp_symbol i ^^ string " = " ^^ - int from_ ^^ string " to " ^^ int to_ ^^ string " {" in + let header = + string "for " ^^ pp_symbol i ^^ string " = " ^^ int from_ ^^ string " to " ^^ int to_ + ^^ string " {" + in let body_doc = nest 2 (break 1 ^^ doc_of_code body) in group (header ^^ body_doc ^^ break 1 ^^ string "}") | Zero_out tn -> string "zero_out " ^^ doc_ident tn ^^ string ";" | Set p -> (* We don't use debug string in PPrint version *) - group ( - doc_ident p.tn ^^ - brackets (pp_indices p.idcs) ^^ - string " := " ^^ - doc_of_float p.llv ^^ - string ";" - ) + group + (doc_ident p.tn + ^^ brackets (pp_indices p.idcs) + ^^ string " := " ^^ doc_of_float p.llv ^^ string ";") | Comment message -> string ("/* " ^ message ^ " */") | Staged_compilation callback -> callback () - | Set_local (id, llv) -> - group (doc_local id ^^ string " := " ^^ doc_of_float llv ^^ string ";") - + | Set_local (id, llv) -> group (doc_local id ^^ string " := " ^^ doc_of_float llv ^^ string ";") and doc_of_float value = match value with - | Local_scope { id; body; _ } -> - group ( - doc_local id ^^ string " {" ^^ - nest 2 (break 1 ^^ doc_of_code body) ^^ - break 1 ^^ string "}" - ) + | Local_scope { id; body; _ } -> + group + (doc_local id ^^ string " {" + ^^ nest 2 (break 1 ^^ doc_of_code body) + ^^ break 1 ^^ string "}") | Get_local id -> doc_local id | Get_global (Ops.C_function s, None) -> string (s ^ "()") - | Get_global (Ops.C_function s, Some idcs) -> - string s ^^ parens (pp_indices idcs) + | Get_global (Ops.C_function s, Some idcs) -> string s ^^ parens (pp_indices idcs) | Get_global (Ops.External_unsafe { ptr; prec; dims = _ }, None) -> string (Ops.ptr_to_string_hum ptr prec) | Get_global (Ops.External_unsafe { ptr; prec; dims = _ }, Some idcs) -> @@ -1049,60 +1021,38 @@ let doc_hum ?name ?static_indices () llc = | Get_global (Ops.Merge_buffer { source_node_id }, Some idcs) -> let tn = Option.value_exn ~here:[%here] @@ Tnode.find ~id:source_node_id in group (doc_ident tn ^^ string ".merge" ^^ brackets (pp_indices idcs)) - | Get (tn, idcs) -> - group (doc_ident tn ^^ brackets (pp_indices idcs)) + | Get (tn, idcs) -> group (doc_ident tn ^^ brackets (pp_indices idcs)) | Constant c -> string (Printf.sprintf "%.16g" c) | Embed_index idx -> pp_axis_index idx | Ternop (op, v1, v2, v3) -> let prefix = Ops.ternop_cd_syntax op in - group ( - string prefix ^^ - parens ( - doc_of_float v1 ^^ string "," ^^ space ^^ - doc_of_float v2 ^^ string "," ^^ space ^^ - doc_of_float v3 - ) - ) + group + (string prefix + ^^ parens + (doc_of_float v1 ^^ string "," ^^ space ^^ doc_of_float v2 ^^ string "," ^^ space + ^^ doc_of_float v3)) | Binop (Arg1, v1, _v2) -> doc_of_float v1 | Binop (Arg2, _v1, v2) -> doc_of_float v2 | Binop (op, v1, v2) -> if Ops.is_binop_nice_infix op then let infix = Ops.binop_cd_syntax op in - group ( - parens ( - doc_of_float v1 ^^ space ^^ - string infix ^^ space ^^ - doc_of_float v2 - ) - ) + group (parens (doc_of_float v1 ^^ space ^^ string infix ^^ space ^^ doc_of_float v2)) else let prefix = Ops.binop_cd_fallback_syntax op in - group ( - string prefix ^^ - parens ( - doc_of_float v1 ^^ string "," ^^ space ^^ - doc_of_float v2 - ) - ) + group (string prefix ^^ parens (doc_of_float v1 ^^ string "," ^^ space ^^ doc_of_float v2)) | Unop (Identity, v) -> doc_of_float v | Unop (op, v) -> let prefix = Ops.unop_cd_syntax op in string prefix ^^ parens (doc_of_float v) in - - hardline ^^ - nest 2 ( - function_header_doc ?name ?static_indices () ^^ - doc_of_code llc - ) + + hardline ^^ nest 2 (function_header_doc ?name ?static_indices () ^^ doc_of_code llc) let%diagn2_sexp optimize ~unoptim_ll_source ~ll_source ~(name : string) (static_indices : Indexing.static_symbol list) (llc : t) : optimized = - Option.iter unoptim_ll_source ~f:(fun callback -> - callback (doc_hum ~name ~static_indices () llc)); + Option.iter unoptim_ll_source ~f:(fun callback -> callback (doc_hum ~name ~static_indices () llc)); let result = optimize_proc static_indices llc in - Option.iter ll_source ~f:(fun callback -> - callback (doc_hum ~name ~static_indices () result.llc)); + Option.iter ll_source ~f:(fun callback -> callback (doc_hum ~name ~static_indices () result.llc)); result let loop_over_dims dims ~body = dune build @fmt failed "/usr/bin/env" "bash" "-c" "opam exec -- dune build @fmt --ignore-promoted-rules || (echo "dune build @fmt failed"; exit 2)" failed with exit status 2 2025-05-22 20:01.34: Job failed: Failed: Build failed